Re: [PATCH v4 1/7] powerpc/mm: update ptep_set_access_flag to not do full mm tlb flush
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-11-23 10:32:08
"Aneesh Kumar K.V" [off-list ref] writes:
quoted hunk ↗ jump to hunk
diff --git a/arch/powerpc/include/asm/book3s/32/pgtable.h b/arch/powerpc/include/asm/book3s/32/pgtable.h index 6b8b2d57fdc8..0713626e9189 100644 --- a/arch/powerpc/include/asm/book3s/32/pgtable.h +++ b/arch/powerpc/include/asm/book3s/32/pgtable.h@@ -224,7 +224,9 @@ static inline void huge_ptep_set_wrprotect(struct mm_struct *mm, static inline void __ptep_set_access_flags(struct mm_struct *mm, - pte_t *ptep, pte_t entry) + pte_t *ptep, pte_t entry, + unsigned long address, + unsigned long pg_sz)
I'd much rather you called these page_size, rather than pg_sz. It's confusing enough that we have things called "psize" which are not page sizes, but then adding pg_sz as well just makes it worse. So can we stick with page_size for things that are page sizes (in bytes), and psize for things that are MMU_PAGE_xx values. cheers