[PATCH] powerpc/mm/radix: Invalidate ERAT on tlbiel for POWER9 DD1

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE3557d

3 messages, 2 authors, 2016-11-16 · open the first message on its own page

[PATCH] powerpc/mm/radix: Invalidate ERAT on tlbiel for POWER9 DD1

From: Michael Neuling <hidden>
Date: 2016-11-16 04:18:28

On POWER9 DD1, when we do a local TLB invalidate we also need to explicitly
invalidate the ERAT.

Signed-off-by: Michael Neuling <redacted>
---
 arch/powerpc/mm/tlb-radix.c | 8 ++++++++
 1 file changed, 8 insertions(+)
diff --git a/arch/powerpc/mm/tlb-radix.c b/arch/powerpc/mm/tlb-radix.c
index bda8c43be7..4b087fc3c7 100644
--- a/arch/powerpc/mm/tlb-radix.c
+++ b/arch/powerpc/mm/tlb-radix.c
@@ -50,6 +50,10 @@ static inline void _tlbiel_pid(unsigned long pid, unsigned long ric)
 	for (set = 0; set < POWER9_TLB_SETS_RADIX ; set++) {
 		__tlbiel_pid(pid, set, ric);
 	}
+	if (cpu_has_feature(CPU_FTR_POWER9_DD1))
+		asm volatile("isync \n"
+			     PPC_SLBIA(0x7)
+			     : : :"memory");
 	return;
 }
 
@@ -83,6 +87,10 @@ static inline void _tlbiel_va(unsigned long va, unsigned long pid,
 	asm volatile(PPC_TLBIEL(%0, %4, %3, %2, %1)
 		     : : "r"(rb), "i"(r), "i"(prs), "i"(ric), "r"(rs) : "memory");
 	asm volatile("ptesync": : :"memory");
+	if (cpu_has_feature(CPU_FTR_POWER9_DD1))
+		asm volatile("isync \n"
+			     PPC_SLBIA(0x7)
+			     : : :"memory");
 }
 
 static inline void _tlbie_va(unsigned long va, unsigned long pid,
-- 
2.9.3

Re: [PATCH] powerpc/mm/radix: Invalidate ERAT on tlbiel for POWER9 DD1

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2016-11-16 04:36:06

On Wed, 2016-11-16 at 15:18 +1100, Michael Neuling wrote:
+               asm volatile("isync \n"
+                            PPC_SLBIA(0x7)
+                            : : :"memory");
        return;
 }
We probably don't need the isync's
quoted hunk
@@ -83,6 +87,10 @@ static inline void _tlbiel_va(unsigned long va,
unsigned long pid,
        asm volatile(PPC_TLBIEL(%0, %4, %3, %2, %1)
                     : : "r"(rb), "i"(r), "i"(prs), "i"(ric), "r"(rs)
: "memory");
        asm volatile("ptesync": : :"memory");
+       if (cpu_has_feature(CPU_FTR_POWER9_DD1))
+               asm volatile("isync \n"
+                            PPC_SLBIA(0x7)
+                            : : :"memory");
 }

Re: [PATCH] powerpc/mm/radix: Invalidate ERAT on tlbiel for POWER9 DD1

From: Michael Neuling <hidden>
Date: 2016-11-16 05:14:54

T24gV2VkLCAyMDE2LTExLTE2IGF0IDE1OjM1ICsxMTAwLCBCZW5qYW1pbiBIZXJyZW5zY2htaWR0
IHdyb3RlOgo+IE9uIFdlZCwgMjAxNi0xMS0xNiBhdCAxNToxOCArMTEwMCwgTWljaGFlbCBOZXVs
aW5nIHdyb3RlOgo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGFzbSB2b2xhdGls
ZSgiaXN5bmMgXG4iCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgIFBQQ19TTEJJQSgweDcpCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDogOiA6Im1lbW9yeSIpOwo+ID4gwqDC
oMKgwqDCoMKgwqDCoHJldHVybjsKPiA+IMKgfQo+ID4gCj4gCj4gV2UgcHJvYmFibHkgZG9uJ3Qg
bmVlZCB0aGUgaXN5bmMncwoKWWVwLCB0ZXN0aW5nIGNvbmZpcm1zIHRoYXQgdG9vLiBJJ2xsIHJl
c2VuZC4KClRoYW5rcywKTWlrZXkKCj4gCj4gPiBAQCAtODMsNiArODcsMTAgQEAgc3RhdGljIGlu
bGluZSB2b2lkIF90bGJpZWxfdmEodW5zaWduZWQgbG9uZyB2YSwKPiA+IHVuc2lnbmVkIGxvbmcg
cGlkLAo+ID4gwqDCoMKgwqDCoMKgwqDCoGFzbSB2b2xhdGlsZShQUENfVExCSUVMKCUwLCAlNCwg
JTMsICUyLCAlMSkKPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg
OiA6ICJyIihyYiksICJpIihyKSwgImkiKHBycyksICJpIihyaWMpLCAiciIocnMpCj4gPiA6ICJt
ZW1vcnkiKTsKPiA+IMKgwqDCoMKgwqDCoMKgwqBhc20gdm9sYXRpbGUoInB0ZXN5bmMiOiA6IDoi
bWVtb3J5Iik7Cj4gPiArwqDCoMKgwqDCoMKgwqBpZiAoY3B1X2hhc19mZWF0dXJlKENQVV9GVFJf
UE9XRVI5X0REMSkpCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgYXNtIHZvbGF0
aWxlKCJpc3luYyBcbiIKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgUFBDX1NMQklBKDB4NykKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgOiA6IDoibWVtb3J5Iik7Cj4gPiDC
oH0KPiAKPiA=
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help