# Re: \[PATCH\] powerpc/powernv: Don't warn on PE init if unfreeze is unsupported

- From: Gavin Shan \<hidden\>
- Date: 2016-11-16 01:21:12 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2016/11/9493666
- Thread: https://ratatoskr.run/linuxppc-dev/2016/11/9493665/t.md

```text
On Wed, Nov 16, 2016 at 12:12:26PM +1100, Russell Currey wrote:
>Whenever a PE is initialised in powernv, opal_pci_eeh_freeze_clear() is
>called.  This is to remove any existing freeze, and has no negative side
>effects if the PE is already in an unfrozen state.  On PHB backends that
>don't support this operation and return OPAL_UNSUPPORTED, this creates a
>scary and misleading warning message.
>
>Skip the warning message on init if OPAL_UNSUPPORTED is returned.
>
>As far as I'm aware, this currently only affects NPUs.
>
>Fixes: 313483d ("powerpc/powernv: Unfreeze PE on allocation")
>Signed-off-by: Russell Currey <redacted>

Acked-by: Gavin Shan <redacted>

>---
> arch/powerpc/platforms/powernv/pci-ioda.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
>index d4b33dd..dcdfee0 100644
>--- a/arch/powerpc/platforms/powernv/pci-ioda.c
>+++ b/arch/powerpc/platforms/powernv/pci-ioda.c
>@@ -145,7 +145,7 @@ static struct pnv_ioda_pe *pnv_ioda_init_pe(struct pnv_phb *phb, int pe_no)
> 	 */
> 	rc = opal_pci_eeh_freeze_clear(phb->opal_id, pe_no,
> 				       OPAL_EEH_ACTION_CLEAR_FREEZE_ALL);
>-	if (rc != OPAL_SUCCESS)
>+	if (rc != OPAL_SUCCESS && rc != OPAL_UNSUPPORTED)
> 		pr_warn("%s: Error %lld unfreezing PHB#%d-PE#%d\n",
> 			__func__, rc, phb->hose->global_number, pe_no);
>
>-- 
>2.10.2
>
```