[PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting"

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE3586d

5 messages, 4 authors, 2016-10-25 · open the first message on its own page

[PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting"

From: Colin King <hidden>
Date: 2016-10-24 22:02:28

From: Colin Ian King <redacted>

trivial fix to spelling mistake in pr_debug message

Signed-off-by: Colin Ian King <redacted>
---
 arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c
index a1b63e0..c8929cb 100644
--- a/arch/powerpc/platforms/pseries/hotplug-cpu.c
+++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c
@@ -553,7 +553,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index)
 {
 	int rc;
 
-	pr_debug("Attemping to remove CPU %s, drc index: %x\n",
+	pr_debug("Attempting to remove CPU %s, drc index: %x\n",
 		 dn->name, drc_index);
 
 	rc = dlpar_offline_cpu(dn);
-- 
2.9.3

Re: [PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting"

From: Kees Cook <hidden>
Date: 2016-10-24 22:13:29

On Mon, Oct 24, 2016 at 3:02 PM, Colin King [off-list ref] wrote:
quoted hunk
From: Colin Ian King <redacted>

trivial fix to spelling mistake in pr_debug message

Signed-off-by: Colin Ian King <redacted>
---
 arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c
index a1b63e0..c8929cb 100644
--- a/arch/powerpc/platforms/pseries/hotplug-cpu.c
+++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c
@@ -553,7 +553,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index)
 {
        int rc;

-       pr_debug("Attemping to remove CPU %s, drc index: %x\n",
+       pr_debug("Attempting to remove CPU %s, drc index: %x\n",
                 dn->name, drc_index);

        rc = dlpar_offline_cpu(dn);
--
2.9.3
Reviewed-by: Kees Cook <redacted>

scripts/spelling.txt should likely get an addition for "attemping". It
already has "attemps"...

-Kees

-- 
Kees Cook
Nexus Security

Re: [PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting"

From: Joe Perches <joe@perches.com>
Date: 2016-10-24 22:20:20

On Mon, 2016-10-24 at 15:13 -0700, Kees Cook wrote:
On Mon, Oct 24, 2016 at 3:02 PM, Colin King [off-list ref] wrote:
quoted
From: Colin Ian King <redacted>

trivial fix to spelling mistake in pr_debug message

Signed-off-by: Colin Ian King <redacted>
---
 arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c
index a1b63e0..c8929cb 100644
--- a/arch/powerpc/platforms/pseries/hotplug-cpu.c
+++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c
@@ -553,7 +553,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index)
 {
        int rc;

-       pr_debug("Attemping to remove CPU %s, drc index: %x\n",
+       pr_debug("Attempting to remove CPU %s, drc index: %x\n",
                 dn->name, drc_index);

        rc = dlpar_offline_cpu(dn);
--
2.9.3
Reviewed-by: Kees Cook <redacted>

scripts/spelling.txt should likely get an addition for "attemping". It
already has "attemps"...
There may not be enough of these to be useful and to my
knowledge Colin isn't fixing comments

$ grep -rP --include=*.[ch] -wi "at+emp*t?ing" * | grep -vi attempting
arch/x86/platform/uv/uv_nmi.c:/* Ping non-responding cpus attemping to force them into the NMI handler */
arch/powerpc/platforms/pseries/hotplug-cpu.c:	pr_debug("Attemping to remove CPU %s, drc index: %x\n",

Re: [PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting"

From: Colin Ian King <hidden>
Date: 2016-10-24 22:24:45

On 24/10/16 23:20, Joe Perches wrote:
On Mon, 2016-10-24 at 15:13 -0700, Kees Cook wrote:
quoted
On Mon, Oct 24, 2016 at 3:02 PM, Colin King [off-list ref] wrote:
quoted
From: Colin Ian King <redacted>

trivial fix to spelling mistake in pr_debug message

Signed-off-by: Colin Ian King <redacted>
---
 arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c
index a1b63e0..c8929cb 100644
--- a/arch/powerpc/platforms/pseries/hotplug-cpu.c
+++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c
@@ -553,7 +553,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index)
 {
        int rc;

-       pr_debug("Attemping to remove CPU %s, drc index: %x\n",
+       pr_debug("Attempting to remove CPU %s, drc index: %x\n",
                 dn->name, drc_index);

        rc = dlpar_offline_cpu(dn);
--
2.9.3
Reviewed-by: Kees Cook <redacted>

scripts/spelling.txt should likely get an addition for "attemping". It
already has "attemps"...
There may not be enough of these to be useful and to my
knowledge Colin isn't fixing comments
Indeed, I'm just using my kernelscan tool to scrape for errors in kernel
messages as these are seen by users as opposed to comments. Plus the
occurrences of the mistakes I'm finding are generally very small.
$ grep -rP --include=*.[ch] -wi "at+emp*t?ing" * | grep -vi attempting
arch/x86/platform/uv/uv_nmi.c:/* Ping non-responding cpus attemping to force them into the NMI handler */
arch/powerpc/platforms/pseries/hotplug-cpu.c:	pr_debug("Attemping to remove CPU %s, drc index: %x\n",

Re: [PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting"

From: Nathan Fontenot <hidden>
Date: 2016-10-25 14:02:31

On 10/24/2016 05:02 PM, Colin King wrote:
From: Colin Ian King <redacted>

trivial fix to spelling mistake in pr_debug message

Signed-off-by: Colin Ian King <redacted>
Reviewed-by: Nathan Fontenot <redacted>
quoted hunk
---
 arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c
index a1b63e0..c8929cb 100644
--- a/arch/powerpc/platforms/pseries/hotplug-cpu.c
+++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c
@@ -553,7 +553,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index)
 {
 	int rc;

-	pr_debug("Attemping to remove CPU %s, drc index: %x\n",
+	pr_debug("Attempting to remove CPU %s, drc index: %x\n",
 		 dn->name, drc_index);

 	rc = dlpar_offline_cpu(dn);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help