Re: [PATCH] kernel: irq: fix build failure

8 messages, 4 authors, 2016-10-24 · open the first message on its own page

Re: [PATCH] kernel: irq: fix build failure

From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: 2016-10-10 15:56:09 

On Thursday 06 October 2016 11:06 PM, Sudip Mukherjee wrote:
The allmodconfig build of powerpc is failing with the error:
ERROR: ".irq_set_parent" [drivers/mfd/tps65217.ko] undefined!

export the symbol to fix the failure.
Hi Thomas,
powerpc and arm allmodconfig builds still fails with the same error.
Build logs of next-20161010 are at:
arm at https://travis-ci.org/sudipm-mukherjee/parport/jobs/166321467
powerpc at https://travis-ci.org/sudipm-mukherjee/parport/jobs/166321473

Regards
Sudip
quoted hunk
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---

build log is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/165418652

  kernel/irq/manage.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 0c5f1a5..5072814 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -721,6 +721,7 @@ int irq_set_parent(int irq, int parent_irq)
  	irq_put_desc_unlock(desc, flags);
  	return 0;
  }
+EXPORT_SYMBOL(irq_set_parent);
  #endif

  /*

Re: [PATCH] kernel: irq: fix build failure

From: Thomas Gleixner <hidden>
Date: 2016-10-20 12:58:16 

On Mon, 10 Oct 2016, Sudip Mukherjee wrote:

On Thursday 06 October 2016 11:06 PM, Sudip Mukherjee wrote:
quoted
The allmodconfig build of powerpc is failing with the error:
ERROR: ".irq_set_parent" [drivers/mfd/tps65217.ko] undefined!

export the symbol to fix the failure.
Hi Thomas,
powerpc and arm allmodconfig builds still fails with the same error.
Build logs of next-20161010 are at:
arm at https://travis-ci.org/sudipm-mukherjee/parport/jobs/166321467
powerpc at https://travis-ci.org/sudipm-mukherjee/parport/jobs/166321473
I know. This is under discussion with the driver folks as we are not going
to blindly export stuff just because someone slapped a irq_set_parent()
into the code w/o knowing why.

Thanks,

	tglx

Re: [PATCH] kernel: irq: fix build failure

From: Stephen Rothwell <hidden>
Date: 2016-10-21 01:00:24 

Hi Thomas,

On Thu, 20 Oct 2016 14:55:45 +0200 (CEST) Thomas Gleixner [off-list ref] wrote:
On Mon, 10 Oct 2016, Sudip Mukherjee wrote:
quoted
On Thursday 06 October 2016 11:06 PM, Sudip Mukherjee wrote:
quoted
The allmodconfig build of powerpc is failing with the error:
ERROR: ".irq_set_parent" [drivers/mfd/tps65217.ko] undefined!

export the symbol to fix the failure.  
Hi Thomas,
powerpc and arm allmodconfig builds still fails with the same error.
Build logs of next-20161010 are at:
arm at https://travis-ci.org/sudipm-mukherjee/parport/jobs/166321467
powerpc at https://travis-ci.org/sudipm-mukherjee/parport/jobs/166321473  
I know. This is under discussion with the driver folks as we are not going
to blindly export stuff just because someone slapped a irq_set_parent()
into the code w/o knowing why.
Do we have any idea if a resolution is close.  This was first reported
in linux-next in September 14/15.  :-(

-- 
Cheers,
Stephen Rothwell

Re: [PATCH] kernel: irq: fix build failure

From: Thomas Gleixner <hidden>
Date: 2016-10-21 08:10:33 

On Fri, 21 Oct 2016, Stephen Rothwell wrote:
On Thu, 20 Oct 2016 14:55:45 +0200 (CEST) Thomas Gleixner [off-list ref] wrote:
quoted
I know. This is under discussion with the driver folks as we are not going
to blindly export stuff just because someone slapped a irq_set_parent()
into the code w/o knowing why.
Do we have any idea if a resolution is close.  This was first reported
in linux-next in September 14/15.  :-(
Grr. Yes. As much as I hate it, I'll go and export it for now. Should be
able to get it into rc2.

Thanks,

	tglx

Re: [PATCH] kernel: irq: fix build failure

From: Stephen Rothwell <hidden>
Date: 2016-10-21 10:20:32 

Hi Thomas,

On Fri, 21 Oct 2016 10:07:41 +0200 (CEST) Thomas Gleixner [off-list ref] wrote:
On Fri, 21 Oct 2016, Stephen Rothwell wrote:
quoted
On Thu, 20 Oct 2016 14:55:45 +0200 (CEST) Thomas Gleixner [off-list ref] wrote:
quoted
I know. This is under discussion with the driver folks as we are not going
to blindly export stuff just because someone slapped a irq_set_parent()
into the code w/o knowing why.  
Do we have any idea if a resolution is close.  This was first reported
in linux-next in September 14/15.  :-(  
Grr. Yes. As much as I hate it, I'll go and export it for now. Should be
able to get it into rc2.
Thanks.

-- 
Cheers,
Stephen Rothwell

Re: [PATCH] kernel: irq: fix build failure

From: Lee Jones <hidden>
Date: 2016-10-24 10:19:52 

On Fri, 21 Oct 2016, Thomas Gleixner wrote:

On Fri, 21 Oct 2016, Stephen Rothwell wrote:
quoted
On Thu, 20 Oct 2016 14:55:45 +0200 (CEST) Thomas Gleixner [off-list ref] wrote:
quoted
I know. This is under discussion with the driver folks as we are not going
to blindly export stuff just because someone slapped a irq_set_parent()
into the code w/o knowing why.
Do we have any idea if a resolution is close.  This was first reported
in linux-next in September 14/15.  :-(
Grr. Yes. As much as I hate it, I'll go and export it for now. Should be
able to get it into rc2.
Did this get in?  I still have people complaining about it.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] kernel: irq: fix build failure

From: Stephen Rothwell <hidden>
Date: 2016-10-24 11:32:36 

Hi Lee,

On Mon, 24 Oct 2016 11:22:15 +0100 Lee Jones [off-list ref] wrote:
On Fri, 21 Oct 2016, Thomas Gleixner wrote:
quoted
On Fri, 21 Oct 2016, Stephen Rothwell wrote:
quoted
On Thu, 20 Oct 2016 14:55:45 +0200 (CEST) Thomas Gleixner [off-list ref] wrote:
quoted
I know. This is under discussion with the driver folks as we are not going
to blindly export stuff just because someone slapped a irq_set_parent()
into the code w/o knowing why.  
Do we have any idea if a resolution is close.  This was first reported
in linux-next in September 14/15.  :-(  
Grr. Yes. As much as I hate it, I'll go and export it for now. Should be
able to get it into rc2.  
Did this get in?  I still have people complaining about it.
It is in -rc2.  Commit 3118dac501bc.

-- 
Cheers,
Stephen Rothwell

Re: [PATCH] kernel: irq: fix build failure

From: Lee Jones <hidden>
Date: 2016-10-24 12:06:10 

On Mon, 24 Oct 2016, Stephen Rothwell wrote:
On Mon, 24 Oct 2016 11:22:15 +0100 Lee Jones [off-list ref] wrote:
quoted
On Fri, 21 Oct 2016, Thomas Gleixner wrote:
quoted
On Fri, 21 Oct 2016, Stephen Rothwell wrote:
quoted
On Thu, 20 Oct 2016 14:55:45 +0200 (CEST) Thomas Gleixner [off-list ref] wrote:
quoted
I know. This is under discussion with the driver folks as we are not going
to blindly export stuff just because someone slapped a irq_set_parent()
into the code w/o knowing why.  
Do we have any idea if a resolution is close.  This was first reported
in linux-next in September 14/15.  :-(  
Grr. Yes. As much as I hate it, I'll go and export it for now. Should be
able to get it into rc2.  
Did this get in?  I still have people complaining about it.
It is in -rc2.  Commit 3118dac501bc.
Ah, I was searching for patches authored my Thomas.

I see it now, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help