[PATCH] powerpc/64: whitelist unresolved modversions CRCs

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE3617d

5 messages, 4 authors, 2016-09-22 · open the first message on its own page

[PATCH] powerpc/64: whitelist unresolved modversions CRCs

From: Nicholas Piggin <npiggin@gmail.com>
Date: 2016-09-14 02:45:25

These are a symptom of CRC generation failure in generic
build code, and not powerpc specific.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---

Hi Michal,

Please merge this via your trees with Al's patches. I have
a patch that can catch crc generation failure generically,
and both Arnd and I have some ideas to fix crc generation
for .S exports. This should get powerpc building again with
your tree.

Thanks,
Nick


 arch/powerpc/relocs_check.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/relocs_check.sh b/arch/powerpc/relocs_check.sh
index 2e4ebd0..ec2d5c8 100755
--- a/arch/powerpc/relocs_check.sh
+++ b/arch/powerpc/relocs_check.sh
@@ -30,6 +30,7 @@ bad_relocs=$(
 	# On PPC64:
 	#	R_PPC64_RELATIVE, R_PPC64_NONE
 	#	R_PPC64_ADDR64 mach_<name>
+	#	R_PPC64_ADDR64 __crc_<name>
 	# On PPC:
 	#	R_PPC_RELATIVE, R_PPC_ADDR16_HI,
 	#	R_PPC_ADDR16_HA,R_PPC_ADDR16_LO,
@@ -41,7 +42,8 @@ R_PPC_ADDR16_HI
 R_PPC_ADDR16_HA
 R_PPC_RELATIVE
 R_PPC_NONE' |
-	grep -E -v '\<R_PPC64_ADDR64[[:space:]]+mach_'
+	grep -E -v '\<R_PPC64_ADDR64[[:space:]]+mach_' |
+	grep -E -v '\<R_PPC64_ADDR64[[:space:]]+__crc_'
 )
 
 if [ -z "$bad_relocs" ]; then
-- 
2.9.3

Re: [PATCH] powerpc/64: whitelist unresolved modversions CRCs

From: Stephen Rothwell <hidden>
Date: 2016-09-14 23:41:14

Hi Nick,

On Wed, 14 Sep 2016 12:45:07 +1000 Nicholas Piggin [off-list ref] wrote:
These are a symptom of CRC generation failure in generic
build code, and not powerpc specific.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
OK, so I will use this as a merge fix patch for the kbuild tree today
(instead of the revert I have been doing).

-- 
Cheers,
Stephen Rothwell

Re: [PATCH] powerpc/64: whitelist unresolved modversions CRCs

From: Stephen Rothwell <hidden>
Date: 2016-09-14 23:49:51

Hi Nick,

On Wed, 14 Sep 2016 12:45:07 +1000 Nicholas Piggin [off-list ref] wrote:
These are a symptom of CRC generation failure in generic
build code, and not powerpc specific.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
This fixes my build problems.

Tested-by: Stephen Rothwell <redacted>

-- 
Cheers,
Stephen Rothwell

Re: [PATCH] powerpc/64: whitelist unresolved modversions CRCs

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-09-15 04:54:16

Nicholas Piggin [off-list ref] writes:
These are a symptom of CRC generation failure in generic
build code, and not powerpc specific.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>

cheers

Re: [PATCH] powerpc/64: whitelist unresolved modversions CRCs

From: Michal Marek <hidden>
Date: 2016-09-22 12:48:16

On 2016-09-14 04:45, Nicholas Piggin wrote:
These are a symptom of CRC generation failure in generic
build code, and not powerpc specific.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---

Hi Michal,

Please merge this via your trees with Al's patches.
Done, thanks for the patch.

Michal
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help