# Re: \[RFC PATCH v3 00/12\] powerpc: "paca-\>soft\_enabled" based local atomic operation implementation

- From: Madhavan Srinivasan \<hidden\>
- Date: 2016-08-26 01:31:15 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2016/08/9492305
- Thread: https://ratatoskr.run/linuxppc-dev/2016/08/9492280/t.md

```text


On Thursday 25 August 2016 12:45 PM, Nicholas Piggin wrote:
> On Thu, 25 Aug 2016 11:59:51 +0530
> Madhavan Srinivasan [ref] wrote:
>
>> Local atomic operations are fast and highly reentrant per CPU counters.
>> Used for percpu variable updates. Local atomic operations only guarantee
>> variable modification atomicity wrt the CPU which owns the data and
>> these needs to be executed in a preemption safe way.
> This is looking really nice. I like how you're able to specify
> the mask nicely in the handler, and test the mask without adding
> any instructions to fastpaths.

Thanks.

>
> So far, I only have a few trivial nitpicks as you can see. I'll
> apply the series and give it a more careful look tomorrow.
Yes. Please.

Also, just noticed that i broke the Booke build, will fix that and respin it right away.
Thanks for the review

Maddy

> Thanks,
> Nick
>
```