# Re: \[RFC PATCH v3 11/12\] powerpc: Support to replay PMIs

- From: Nicholas Piggin \<npiggin@gmail.com\>
- Date: 2016-08-25 07:08:39 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2016/08/9492294
- Thread: https://ratatoskr.run/linuxppc-dev/2016/08/9492280/t.md

```text
On Thu, 25 Aug 2016 12:00:02 +0530
Madhavan Srinivasan [ref] wrote:

> Code to replay the Performance Monitoring Interrupts(PMI).
> In the masked_interrupt handler, for PMIs we reset the MSR[EE]
> and return. In the __check_irq_replay(), replay the PMI interrupt
> by calling performance_monitor_common handler.
> 
> Patch also adds a new soft_irq_set_mask() to update paca->soft_enabled.
> New Kconfig is added "CONFIG_IRQ_DEBUG_SUPPORT" to add a warn_on
> to alert the usage of soft_irq_set_mask() for disabling lower
> bitmask interrupts.
> 
> Have also moved the code under the CONFIG_TRACE_IRQFLAGS in
> arch_local_irq_restore() to new Kconfig as suggested.

Should you make a single patch out of this and patch 10?
It doesn't make sense to mask perf interrupts if we can't
replay them.

Perhaps split the CONFIG_IRQ_DEBUG_SUPPORT change into its
own patch first and have the PMU masking and replaying as
a single patch?

Just a suggestion.
```