[PATCH] crypto: powerpc - CRYPT_CRC32C_VPMSUM should depend on ALTIVEC

The optimised crc32c implementation depends on VMX (aka. Altivec)
instructions, so the kernel must be built with Altivec support in order
for the crc32c code to build.

Fixes: 6dd7a82cc54e ("crypto: powerpc - Add POWER8 optimised crc32c")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 crypto/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/Kconfig b/crypto/Kconfig
index a9377bef25e3..84d71482bf08 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig

@@ -439,7 +439,7 @@ config CRYPTO_CRC32C_INTEL
 
 config CRYPT_CRC32C_VPMSUM
 	tristate "CRC32c CRC algorithm (powerpc64)"
-	depends on PPC64
+	depends on PPC64 && ALTIVEC
 	select CRYPTO_HASH
 	select CRC32
 	help

-- 
2.7.4

Hi Michael,

The optimised crc32c implementation depends on VMX (aka. Altivec)
instructions, so the kernel must be built with Altivec support in
order for the crc32c code to build.

Thanks for that, looks good.

Acked-by: Anton Blanchard <redacted>

Anton Blanchard [off-list ref] writes:

Hi Michael,

quoted

The optimised crc32c implementation depends on VMX (aka. Altivec)
instructions, so the kernel must be built with Altivec support in
order for the crc32c code to build.

Thanks for that, looks good.

Acked-by: Anton Blanchard <redacted>

Thanks. Herbert, expecting you'll pick this up.

cheers

On Fri, Aug 05, 2016 at 01:28:03PM +1000, Michael Ellerman wrote:

Anton Blanchard [off-list ref] writes:

quoted

Hi Michael,

quoted

The optimised crc32c implementation depends on VMX (aka. Altivec)
instructions, so the kernel must be built with Altivec support in
order for the crc32c code to build.

Thanks for that, looks good.

Acked-by: Anton Blanchard <redacted>

Thanks. Herbert, expecting you'll pick this up.

In that case Anton can you please post it to linux-crypto?

Thanks,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Herbert Xu [off-list ref] writes:

On Fri, Aug 05, 2016 at 01:28:03PM +1000, Michael Ellerman wrote:

quoted

Anton Blanchard [off-list ref] writes:

quoted

Hi Michael,

quoted

The optimised crc32c implementation depends on VMX (aka. Altivec)
instructions, so the kernel must be built with Altivec support in
order for the crc32c code to build.

Thanks for that, looks good.

Acked-by: Anton Blanchard <redacted>

Thanks. Herbert, expecting you'll pick this up.

In that case Anton can you please post it to linux-crypto?

Sorry that's my fault, will repost to linux-crypto.

cheers