# Re: \[PATCH v3 10/21\] powerpc/mm: Define radix\_enabled() in one place \& use static inline

- From: Michael Ellerman \<mpe@ellerman.id.au\>
- Date: 2016-07-30 10:08:16 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2016/07/9491682
- Thread: https://ratatoskr.run/linuxppc-dev/2016/07/9491623/t.md

```text
Balbir Singh [ref] writes:

> On Fri, 2016-07-29 at 21:42 +1000, Michael Ellerman wrote:
>> Nicholas Piggin [ref] writes:
>> > Won't MMU_FTRS_POSSIBLE just do the right thing when
>> > !CONFIG_PPC_RADIX_MMU?
>> Yes it should.
>>
>> I'll have to work out why Aneesh thought he needed to do it explicitly
>> and whether that is needed or not.
>
> IIRC, If CONFIG_PPC_RADIX_MMU=3Dn MMU_FTR_RAIDX will not be present in the
> MMU_FTRS_POSSIBLE mask=C2=A0

That's right.

The obvious thing to do would be to define MMU_FTR_RADIX to 0 when
RADIX=3Dn, but that doesn't work because it breaks the ASM FTR macros
(because they check (mmu_features & mask) =3D=3D mask).

So instead we just remove it from the possible mask.

cheers
```
