# Re: \[PATCH for-4.8 V2 03/10\] powerpc/mm/radix: Add radix\_set\_pte to use in early init

- From: Nicholas Piggin \<npiggin@gmail.com\>
- Date: 2016-07-25 08:57:08 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2016/07/9491523
- Thread: https://ratatoskr.run/linuxppc-dev/2016/07/9491480/t.md

```text
On Mon, 25 Jul 2016 18:36:09 +1000
Michael Ellerman [ref] wrote:

> "Aneesh Kumar K.V" [ref] writes:
> 
> > We want to use the static key based feature check in set_pte_at.
> > Since we call radix__map_kernel_page early in boot before jump
> > label is initialized we can't call set_pte_at there. Add
> > radix__set_pte for the same.  
> 
> Although this is an OK solution to this problem, I think it
> highlights a bigger problem, which is that we're still doing the
> feature patching too late.
> 
> If we can move the feature patching prior to MMU init, then all (or
> more of) these problems with pre vs post patching go away.
> 
> I'll see if I can come up with something tomorrow.

Agreed, that would be much nicer if you can make it work.

Thanks,
Nick
```
