Re: [PATCH][v2] driver/memory: Update dependency of IFC for Layerscape
From: Boris Brezillon <hidden>
Date: 2016-07-04 09:33:09
+PPC maintainers. Hi Raghav, Since you're touching powerpc drivers, the least you could do is add ppc maintainers in Cc, so that they can ack/review your patch... On Fri, 1 Jul 2016 21:32:30 +0530 Raghav Dogra [off-list ref] wrote:
This patch enables IFC NAND support on ARM layerscape platform. It fixes the dependency to enable NAND. The include files are being modified to ensure complilation for both PowerPC and ARM architectures.
Still think this could be separated in 2 commits: - the first one getting rid of the asm/prom.h inclusion - the second one changing the Kconfig dependency
quoted hunk
Signed-off-by: Raghav Dogra <redacted> --- Applicable to git://git.infradead.org/l2-mtd.git Changes for v2: updated commit description drivers/memory/Kconfig | 2 +- drivers/memory/fsl_ifc.c | 4 +++- drivers/mtd/nand/Kconfig | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-)diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig index 81ddb17..5645705 100644 --- a/drivers/memory/Kconfig +++ b/drivers/memory/Kconfig@@ -104,7 +104,7 @@ config FSL_CORENET_CF config FSL_IFC bool - depends on FSL_SOC + depends on FSL_SOC || ARCH_LAYERSCAPE config JZ4780_NEMC bool "Ingenic JZ4780 SoC NEMC driver"diff --git a/drivers/memory/fsl_ifc.c b/drivers/memory/fsl_ifc.c index 904b4af..1b182b1 100644 --- a/drivers/memory/fsl_ifc.c +++ b/drivers/memory/fsl_ifc.c@@ -31,7 +31,9 @@ #include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/fsl_ifc.h> -#include <asm/prom.h> +#include <linux/irqdomain.h> +#include <linux/of_address.h> +#include <linux/of_irq.h> struct fsl_ifc_ctrl *fsl_ifc_ctrl_dev; EXPORT_SYMBOL(fsl_ifc_ctrl_dev);diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index f05e0e9..eace3ef 100644 --- a/drivers/mtd/nand/Kconfig +++ b/drivers/mtd/nand/Kconfig@@ -438,7 +438,7 @@ config MTD_NAND_FSL_ELBC config MTD_NAND_FSL_IFC tristate "NAND support for Freescale IFC controller" - depends on MTD_NAND && FSL_SOC + depends on MTD_NAND && (FSL_SOC || ARCH_LAYERSCAPE) select FSL_IFC select MEMORY help