Thread (3 messages) 3 messages, 3 authors, 2016-07-22

Re: [kernel] powerpc/powernv/ioda: Fix endianness when reading TCEs

From: Michael Ellerman <hidden>
Date: 2016-07-22 05:50:45
Also in: stable

On Wed, 2016-20-07 at 04:26:51 UTC, Alexey Kardashevskiy wrote:
The iommu_table_ops::exchange() callback writes new TCE to the table
and returns old value and permission mask. The old TCE value is
correctly converted from BE to CPU endian; however permission mask
was calculated from BE value and therefore always returned DMA_NONE
which could cause memory leak on LE systems using VFIO SPAPR TCE IOMMU v1
driver.

This fixes pnv_tce_xchg() to have @oldtce a CPU endian.

Fixes: 05c6cfb9dce0d13d37e9d007ee6a4af36f1c0a58
Signed-off-by: Alexey Kardashevskiy <redacted>
Reviewed-by: David Gibson <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/802a345183c0308aa64969cca6

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help