[PATCH v2] irqchip/qeic: move qeic driver from drivers/soc/fsl/qe
Subsystems:
freescale quicc engine library , freescale soc drivers , irqchip drivers , the rest
3692d
5 messages,
3 authors,
2016-07-25 · open the first message on its own page
The driver stays the same.
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2:
- modify the subject and commit msg
drivers/irqchip/Makefile | 1 +
drivers/{soc/fsl/qe => irqchip}/qe_ic.c | 0
drivers/{soc/fsl/qe => irqchip}/qe_ic.h | 0
drivers/soc/fsl/qe/Makefile | 2 +-
4 files changed, 2 insertions(+), 1 deletion(-)
rename drivers/{soc/fsl/qe => irqchip}/qe_ic.c (100%)
rename drivers/{soc/fsl/qe => irqchip}/qe_ic.h (100%)
diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
index 38853a1..cef999d 100644
--- a/drivers/irqchip/Makefile
+++ b/drivers/irqchip/Makefile @@ -69,3 +69,4 @@ obj-$(CONFIG_PIC32_EVIC) += irq-pic32-evic.o
obj-$(CONFIG_MVEBU_ODMI) += irq-mvebu-odmi.o
obj-$(CONFIG_LS_SCFG_MSI) += irq-ls-scfg-msi.o
obj-$(CONFIG_EZNPS_GIC) += irq-eznps.o
+ obj-$(CONFIG_QUICC_ENGINE) += qe_ic.odiff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/irqchip/qe_ic.c
similarity index 100%
rename from drivers/soc/fsl/qe/qe_ic.c
rename to drivers/irqchip/qe_ic.c
diff --git a/drivers/soc/fsl/qe/qe_ic.h b/drivers/irqchip/qe_ic.h
similarity index 100%
rename from drivers/soc/fsl/qe/qe_ic.h
rename to drivers/irqchip/qe_ic.h
diff --git a/drivers/soc/fsl/qe/Makefile b/drivers/soc/fsl/qe/Makefile
index 2031d38..51e4726 100644
--- a/drivers/soc/fsl/qe/Makefile
+++ b/drivers/soc/fsl/qe/Makefile @@ -1,7 +1,7 @@
#
# Makefile for the linux ppc-specific parts of QE
#
- obj-$(CONFIG_QUICC_ENGINE) += qe.o qe_common.o qe_ic.o qe_io.o+ obj-$(CONFIG_QUICC_ENGINE) += qe.o qe_common.o qe_io.o obj-$(CONFIG_CPM) += qe_common.o
obj-$(CONFIG_UCC) += ucc.o
obj-$(CONFIG_UCC_SLOW) += ucc_slow.o --
2.1.0.27.g96db324
Hi Zhao Qiang,
On Thu, Jul 07, 2016 at 09:23:55AM +0800, Zhao Qiang wrote: The driver stays the same.
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2:
- modify the subject and commit msg
drivers/irqchip/Makefile | 1 +
drivers/{soc/fsl/qe => irqchip}/qe_ic.c | 0
drivers/{soc/fsl/qe => irqchip}/qe_ic.h | 0
drivers/soc/fsl/qe/Makefile | 2 +-
4 files changed, 2 insertions(+), 1 deletion(-)
rename drivers/{soc/fsl/qe => irqchip}/qe_ic.c (100%)
rename drivers/{soc/fsl/qe => irqchip}/qe_ic.h (100%)
Please merge the include file into the C file and rename to follow the
naming convention in drivers/irqchip/. e.g. irq-qeic.c or irq-qe_ic.c.
Once you have that, please resend the entire series with this as the
first patch.
thx,
Jason.
On Thu, Jul 07, 2016 at 10:25PM , Jason Cooper [off-list ref] wrote=
: -----Original Message-----
From: Jason Cooper [mailto:jason@lakedaemon.net]
Sent: Thursday, July 07, 2016 10:25 PM
To: Qiang Zhao <qiang.zhao@nxp.com>
Cc: oss@buserror.net; tglx@linutronix.de; marc.zyngier@arm.com; linuxppc-
dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; Xiaobo Xie
[off-list ref]
Subject: Re: [PATCH v2] irqchip/qeic: move qeic driver from drivers/soc/f= sl/qe =20
Hi Zhao Qiang,
=20
On Thu, Jul 07, 2016 at 09:23:55AM +0800, Zhao Qiang wrote: quoted The driver stays the same.
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2:
- modify the subject and commit msg
drivers/irqchip/Makefile | 1 +
drivers/{soc/fsl/qe =3D> irqchip}/qe_ic.c | 0 drivers/{soc/fsl/qe =3D= quoted irqchip}/qe_ic.h | 0
drivers/soc/fsl/qe/Makefile | 2 +-
4 files changed, 2 insertions(+), 1 deletion(-) rename
drivers/{soc/fsl/qe =3D> irqchip}/qe_ic.c (100%) rename
drivers/{soc/fsl/qe =3D> irqchip}/qe_ic.h (100%) =20
Please merge the include file into the C file and rename to follow the na= ming convention in drivers/irqchip/. e.g. irq-qeic.c or irq-qe_ic.c.
=20
Once you have that, please resend the entire series with this as the firs= t patch. =20
OK, I will modify the next version.=20
-Zhao Qiang
BR
On Mon, 2016-07-25 at 06:15 +0000, Qiang Zhao wrote: On Thu, Jul 07, 2016 at 10:25PM , Jason Cooper [off-list ref] wrote: quoted
-----Original Message-----
From: Jason Cooper [mailto:jason@lakedaemon.net]
Sent: Thursday, July 07, 2016 10:25 PM
To: Qiang Zhao <qiang.zhao@nxp.com>
Cc: oss@buserror.net; tglx@linutronix.de; marc.zyngier@arm.com; linuxppc-
dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; Xiaobo Xie
[off-list ref]
Subject: Re: [PATCH v2] irqchip/qeic: move qeic driver from
drivers/soc/fsl/qe
Hi Zhao Qiang,
On Thu, Jul 07, 2016 at 09:23:55AM +0800, Zhao Qiang wrote: quoted
The driver stays the same.
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2:
- modify the subject and commit msg
drivers/irqchip/Makefile | 1 +
drivers/{soc/fsl/qe => irqchip}/qe_ic.c | 0 drivers/{soc/fsl/qe =>
irqchip}/qe_ic.h | 0
drivers/soc/fsl/qe/Makefile | 2 +-
4 files changed, 2 insertions(+), 1 deletion(-) rename
drivers/{soc/fsl/qe => irqchip}/qe_ic.c (100%) rename
drivers/{soc/fsl/qe => irqchip}/qe_ic.h (100%) Please merge the include file into the C file and rename to follow the
naming
convention in drivers/irqchip/. e.g. irq-qeic.c or irq-qe_ic.c.
Once you have that, please resend the entire series with this as the first
patch. Sorry, I have no idea about "Include file", could you explain which file you
meant?
qe_ic.h
If nothing else is going to include that, then the contents can go directly
into qe_ic.c.
-Scott
On Thu, Jul 07, 2016 at 10:25PM , Jason Cooper [off-list ref] wrote=
: -----Original Message-----
From: Jason Cooper [mailto:jason@lakedaemon.net]
Sent: Thursday, July 07, 2016 10:25 PM
To: Qiang Zhao <qiang.zhao@nxp.com>
Cc: oss@buserror.net; tglx@linutronix.de; marc.zyngier@arm.com; linuxppc-
dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; Xiaobo Xie
[off-list ref]
Subject: Re: [PATCH v2] irqchip/qeic: move qeic driver from drivers/soc/f= sl/qe =20
Hi Zhao Qiang,
=20
On Thu, Jul 07, 2016 at 09:23:55AM +0800, Zhao Qiang wrote: quoted The driver stays the same.
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2:
- modify the subject and commit msg
drivers/irqchip/Makefile | 1 +
drivers/{soc/fsl/qe =3D> irqchip}/qe_ic.c | 0 drivers/{soc/fsl/qe =3D= quoted irqchip}/qe_ic.h | 0
drivers/soc/fsl/qe/Makefile | 2 +-
4 files changed, 2 insertions(+), 1 deletion(-) rename
drivers/{soc/fsl/qe =3D> irqchip}/qe_ic.c (100%) rename
drivers/{soc/fsl/qe =3D> irqchip}/qe_ic.h (100%) =20
Please merge the include file into the C file and rename to follow the na= ming convention in drivers/irqchip/. e.g. irq-qeic.c or irq-qe_ic.c.
=20
Once you have that, please resend the entire series with this as the firs= t patch.
Sorry, I have no idea about "Include file", could you explain which file yo=
u meant?
Thank you!
-Zhao Qiang