[RESEND v7,2/2] cxl: Add set and get private data to context struct

Subsystems: char and misc drivers, the rest

5 messages, 3 authors, 2016-06-30 · open the first message on its own page

[RESEND v7,2/2] cxl: Add set and get private data to context struct

From: Philippe Bergheaud <hidden>
Date: 2016-06-24 06:47:21

From: Michael Neuling <redacted>

This provides AFU drivers a means to associate private data with a cxl
context. This is particularly intended for make the new callbacks for
driver specific events easier for AFU drivers to use, as they can easily
get back to any private data structures they may use.

Signed-off-by: Michael Neuling <redacted>
Signed-off-by: Ian Munsie <redacted>
Signed-off-by: Philippe Bergheaud <felix@linux.vnet.ibm.com
Reviewed-by: Matthew R. Ochs <redacted>
---
No changes since v1. Added Matt Ochs reviewed-by tag.

 drivers/misc/cxl/api.c | 21 +++++++++++++++++++++
 drivers/misc/cxl/cxl.h |  3 +++
 include/misc/cxl.h     |  7 +++++++
 3 files changed, 31 insertions(+)
diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
index dd1988e..271bf77 100644
--- a/drivers/misc/cxl/api.c
+++ b/drivers/misc/cxl/api.c
@@ -94,6 +94,27 @@ static irq_hw_number_t cxl_find_afu_irq(struct cxl_context *ctx, int num)
 	return 0;
 }
 
+
+int cxl_set_priv(struct cxl_context *ctx, void *priv)
+{
+	if (!ctx)
+		return -EINVAL;
+
+	ctx->priv = priv;
+
+	return 0;
+}
+EXPORT_SYMBOL_GPL(cxl_set_priv);
+
+void *cxl_get_priv(struct cxl_context *ctx)
+{
+	if (!ctx)
+		return ERR_PTR(-EINVAL);
+
+	return ctx->priv;
+}
+EXPORT_SYMBOL_GPL(cxl_get_priv);
+
 int cxl_allocate_afu_irqs(struct cxl_context *ctx, int num)
 {
 	int res;
diff --git a/drivers/misc/cxl/cxl.h b/drivers/misc/cxl/cxl.h
index b0027e6..1e56304 100644
--- a/drivers/misc/cxl/cxl.h
+++ b/drivers/misc/cxl/cxl.h
@@ -478,6 +478,9 @@ struct cxl_context {
 	/* Only used in PR mode */
 	u64 process_token;
 
+	/* driver private data */
+	void *priv;
+
 	unsigned long *irq_bitmap; /* Accessed from IRQ context */
 	struct cxl_irq_ranges irqs;
 	struct list_head irq_names;
diff --git a/include/misc/cxl.h b/include/misc/cxl.h
index 17419f6..b6d040f 100644
--- a/include/misc/cxl.h
+++ b/include/misc/cxl.h
@@ -86,6 +86,13 @@ struct cxl_context *cxl_dev_context_init(struct pci_dev *dev);
 int cxl_release_context(struct cxl_context *ctx);
 
 /*
+ * Set and get private data associated with a context. Allows drivers to have a
+ * back pointer to some useful structure.
+ */
+int cxl_set_priv(struct cxl_context *ctx, void *priv);
+void *cxl_get_priv(struct cxl_context *ctx);
+
+/*
  * Allocate AFU interrupts for this context. num=0 will allocate the default
  * for this AFU as given in the AFU descriptor. This number doesn't include the
  * interrupt 0 (CAIA defines AFU IRQ 0 for page faults). Each interrupt to be
-- 
2.8.0

Re: [RESEND v7,2/2] cxl: Add set and get private data to context struct

From: Andrew Donnellan <hidden>
Date: 2016-06-28 08:09:30

On 24/06/16 16:47, Philippe Bergheaud wrote:
From: Michael Neuling <redacted>

This provides AFU drivers a means to associate private data with a cxl
context. This is particularly intended for make the new callbacks for
driver specific events easier for AFU drivers to use, as they can easily
get back to any private data structures they may use.

Signed-off-by: Michael Neuling <redacted>
Signed-off-by: Ian Munsie <redacted>
Signed-off-by: Philippe Bergheaud <felix@linux.vnet.ibm.com
Reviewed-by: Matthew R. Ochs <redacted>
As per v3:

Reviewed-by: Andrew Donnellan <redacted>

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited

Re: [RESEND, v7, 2/2] cxl: Add set and get private data to context struct

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-06-28 08:31:34

On Fri, 2016-24-06 at 06:47:07 UTC, Philippe Bergheaud wrote:
From: Michael Neuling <redacted>

This provides AFU drivers a means to associate private data with a cxl
context. This is particularly intended for make the new callbacks for
driver specific events easier for AFU drivers to use, as they can easily
get back to any private data structures they may use.

Signed-off-by: Michael Neuling <redacted>
Signed-off-by: Ian Munsie <redacted>
Signed-off-by: Philippe Bergheaud <felix@linux.vnet.ibm.com
Reviewed-by: Matthew R. Ochs <redacted>
Reviewed-by: Andrew Donnellan <redacted>
---
No changes since v1. Added Matt Ochs reviewed-by tag.
I'm not sure why this is RESEND ?

Does this pair with [v7 1/2] ?

  https://patchwork.ozlabs.org/patch/639644/

It's a lot simpler if you just resend the whole series each time there is an
update to any patch.

cheers

Re: [RESEND, v7, 2/2] cxl: Add set and get private data to context struct

From: Philippe Bergheaud <hidden>
Date: 2016-06-28 09:21:59

Michael Ellerman wrote:
On Fri, 2016-24-06 at 06:47:07 UTC, Philippe Bergheaud wrote:
quoted
From: Michael Neuling <redacted>

This provides AFU drivers a means to associate private data with a cxl
context. This is particularly intended for make the new callbacks for
driver specific events easier for AFU drivers to use, as they can easily
get back to any private data structures they may use.

Signed-off-by: Michael Neuling <redacted>
Signed-off-by: Ian Munsie <redacted>
Signed-off-by: Philippe Bergheaud <felix@linux.vnet.ibm.com
Reviewed-by: Matthew R. Ochs <redacted>
Reviewed-by: Andrew Donnellan <redacted>
---
No changes since v1. Added Matt Ochs reviewed-by tag.

I'm not sure why this is RESEND ?
Sorry. That was because I made a typo in the title (I typed v6 instead of v7).
Does this pair with [v7 1/2] ?
Yes it does.
  https://patchwork.ozlabs.org/patch/639644/

It's a lot simpler if you just resend the whole series each time there is an
update to any patch.
Got it, thank you.

Philippe

Re: [RESEND, v7, 2/2] cxl: Add set and get private data to context struct

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-06-30 12:36:39

On Fri, 2016-24-06 at 06:47:07 UTC, Philippe Bergheaud wrote:
From: Michael Neuling <redacted>

This provides AFU drivers a means to associate private data with a cxl
context. This is particularly intended for make the new callbacks for
driver specific events easier for AFU drivers to use, as they can easily
get back to any private data structures they may use.

Signed-off-by: Michael Neuling <redacted>
Signed-off-by: Ian Munsie <redacted>
Signed-off-by: Philippe Bergheaud <felix@linux.vnet.ibm.com
Reviewed-by: Matthew R. Ochs <redacted>
Reviewed-by: Andrew Donnellan <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/ad42de859ff14c079e966e61cb

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help