[PATCH][V2] powerpc/fadump: trivial fix of spelling mistake, clean up message

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE3721d

3 messages, 3 authors, 2016-07-01 · open the first message on its own page

[PATCH][V2] powerpc/fadump: trivial fix of spelling mistake, clean up message

From: Colin King <hidden>
Date: 2016-06-27 11:08:09

From: Colin Ian King <redacted>

Fix trivial spelling mistake "rgistration". Also use pr_err
instead of printk and unsplit the string to keep it all on one
line.

Signed-off-by: Colin Ian King <redacted>
---
 arch/powerpc/kernel/fadump.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
index 3cb3b02a..09cb2a7 100644
--- a/arch/powerpc/kernel/fadump.c
+++ b/arch/powerpc/kernel/fadump.c
@@ -1009,9 +1009,9 @@ static int fadump_invalidate_dump(struct fadump_mem_struct *fdm)
 	} while (wait_time);
 
 	if (rc) {
-		printk(KERN_ERR "Failed to invalidate firmware-assisted dump "
-			"rgistration. unexpected error(%d).\n", rc);
-		return rc;
+		pr_err("Failed to invalidate firmware-assisted dump registration. Unexpected error (%d).\n",
+		       rc);
+		return rc
 	}
 	fw_dump.dump_active = 0;
 	fdm_active = NULL;
-- 
2.8.1

Re: [V2] powerpc/fadump: trivial fix of spelling mistake, clean up message

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-06-30 12:36:46

On Mon, 2016-27-06 at 11:07:41 UTC, Colin King wrote:
From: Colin Ian King <redacted>

Fix trivial spelling mistake "rgistration". Also use pr_err
instead of printk and unsplit the string to keep it all on one
line.

Signed-off-by: Colin Ian King <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/4a03749f140cbee6fee66b674b

cheers

[PATCH] powerpc/fadump: Fix compile error due to missing semicolon

From: Ian Munsie <hidden>
Date: 2016-07-01 02:33:26

From: Ian Munsie <redacted>

The commit "powerpc/fadump: trivial fix of spelling mistake, clean up
message" removed a semicolon causing the following compile failure:

arch/powerpc/kernel/fadump.c: In function ‘fadump_invalidate_dump’:
arch/powerpc/kernel/fadump.c:1014:2: error: expected ‘;’ before ‘}’ token
  }
  ^

Reported-by: Huy Nguyen <redacted>
Signed-off-by: Ian Munsie <redacted>
---
 arch/powerpc/kernel/fadump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
index f066486..b3a6633 100644
--- a/arch/powerpc/kernel/fadump.c
+++ b/arch/powerpc/kernel/fadump.c
@@ -1010,7 +1010,7 @@ static int fadump_invalidate_dump(struct fadump_mem_struct *fdm)
 
 	if (rc) {
 		pr_err("Failed to invalidate firmware-assisted dump registration. Unexpected error (%d).\n", rc);
-		return rc
+		return rc;
 	}
 	fw_dump.dump_active = 0;
 	fdm_active = NULL;
-- 
2.8.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help