[PATCH 0228/1529] Fix typo

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE3684d

4 messages, 4 authors, 2016-07-17 · open the first message on its own page

[PATCH 0228/1529] Fix typo

From: Andrea Gelmini <hidden>
Date: 2016-05-21 12:06:27

Signed-off-by: Andrea Gelmini <redacted>
---
 arch/powerpc/lib/checksum_64.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/lib/checksum_64.S b/arch/powerpc/lib/checksum_64.S
index 8e6e510..f3b5b7d 100644
--- a/arch/powerpc/lib/checksum_64.S
+++ b/arch/powerpc/lib/checksum_64.S
@@ -74,7 +74,7 @@ _GLOBAL(__csum_partial)
 	ld	r11,24(r3)
 
 	/*
-	 * On POWER6 and POWER7 back to back addes take 2 cycles because of
+	 * On POWER6 and POWER7 back to back adds take 2 cycles because of
 	 * the XER dependency. This means the fastest this loop can go is
 	 * 16 cycles per iteration. The scheduling of the loop below has
 	 * been shown to hit this on both POWER6 and POWER7.
@@ -275,7 +275,7 @@ source;	ld	r10,16(r3)
 source;	ld	r11,24(r3)
 
 	/*
-	 * On POWER6 and POWER7 back to back addes take 2 cycles because of
+	 * On POWER6 and POWER7 back to back adds take 2 cycles because of
 	 * the XER dependency. This means the fastest this loop can go is
 	 * 16 cycles per iteration. The scheduling of the loop below has
 	 * been shown to hit this on both POWER6 and POWER7.
-- 
2.8.2.534.g1f66975

Re: [PATCH 0228/1529] Fix typo

From: Paul Mackerras <hidden>
Date: 2016-05-22 12:39:10

On Sat, May 21, 2016 at 02:06:18PM +0200, Andrea Gelmini wrote:
quoted hunk
Signed-off-by: Andrea Gelmini <redacted>
---
 arch/powerpc/lib/checksum_64.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/lib/checksum_64.S b/arch/powerpc/lib/checksum_64.S
index 8e6e510..f3b5b7d 100644
--- a/arch/powerpc/lib/checksum_64.S
+++ b/arch/powerpc/lib/checksum_64.S
@@ -74,7 +74,7 @@ _GLOBAL(__csum_partial)
 	ld	r11,24(r3)
 
 	/*
-	 * On POWER6 and POWER7 back to back addes take 2 cycles because of
+	 * On POWER6 and POWER7 back to back adds take 2 cycles because of
 	 * the XER dependency. This means the fastest this loop can go is
 	 * 16 cycles per iteration. The scheduling of the loop below has
 	 * been shown to hit this on both POWER6 and POWER7.
@@ -275,7 +275,7 @@ source;	ld	r10,16(r3)
 source;	ld	r11,24(r3)
 
 	/*
-	 * On POWER6 and POWER7 back to back addes take 2 cycles because of
+	 * On POWER6 and POWER7 back to back adds take 2 cycles because of
 	 * the XER dependency. This means the fastest this loop can go is
 	 * 16 cycles per iteration. The scheduling of the loop below has
 	 * been shown to hit this on both POWER6 and POWER7.
NAK - this is talking about the 'adde' instruction, not the 'add'
instruction.

Paul.

[PATCH] Clarify that adde is an instruction and we mean plural

From: Stewart Smith <hidden>
Date: 2016-05-23 01:27:18

Signed-off-by: Stewart Smith <redacted>
---
 arch/powerpc/lib/checksum_64.S | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/lib/checksum_64.S b/arch/powerpc/lib/checksum_64.S
index 8e6e510..fdec6e6 100644
--- a/arch/powerpc/lib/checksum_64.S
+++ b/arch/powerpc/lib/checksum_64.S
@@ -74,9 +74,9 @@ _GLOBAL(__csum_partial)
 	ld	r11,24(r3)
 
 	/*
-	 * On POWER6 and POWER7 back to back addes take 2 cycles because of
-	 * the XER dependency. This means the fastest this loop can go is
-	 * 16 cycles per iteration. The scheduling of the loop below has
+	 * On POWER6 and POWER7 back to back adde instructions take 2 cycles
+	 * because of the XER dependency. This means the fastest this loop can
+	 * go is 16 cycles per iteration. The scheduling of the loop below has
 	 * been shown to hit this on both POWER6 and POWER7.
 	 */
 	.align 5
@@ -275,9 +275,9 @@ source;	ld	r10,16(r3)
 source;	ld	r11,24(r3)
 
 	/*
-	 * On POWER6 and POWER7 back to back addes take 2 cycles because of
-	 * the XER dependency. This means the fastest this loop can go is
-	 * 16 cycles per iteration. The scheduling of the loop below has
+	 * On POWER6 and POWER7 back to back adde instructions take 2 cycles
+	 * because of the XER dependency. This means the fastest this loop can
+	 * go is 16 cycles per iteration. The scheduling of the loop below has
 	 * been shown to hit this on both POWER6 and POWER7.
 	 */
 	.align 5
-- 
2.5.5

Re: Clarify that adde is an instruction and we mean plural

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-07-17 10:28:21

On Mon, 2016-23-05 at 01:27:01 UTC, Stewart Smith wrote:
Signed-off-by: Stewart Smith <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/ec5619fdba66f091b5b987f980

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help