[PATCH 0213/1529] Fix typo

Subsystems: linux for powerpc (32-bit and 64-bit), pci enhanced error handling (eeh) for powerpc, the rest

STALE3737d

5 messages, 4 authors, 2016-05-24 · open the first message on its own page

[PATCH 0213/1529] Fix typo

From: Andrea Gelmini <hidden>
Date: 2016-05-21 12:04:02 

Signed-off-by: Andrea Gelmini <redacted>
---
 arch/powerpc/include/asm/eeh.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h
index fb9f376..7d34f3d 100644
--- a/arch/powerpc/include/asm/eeh.h
+++ b/arch/powerpc/include/asm/eeh.h
@@ -57,7 +57,7 @@ struct pci_dn;
 /*
  * The struct is used to trace PE related EEH functionality.
  * In theory, there will have one instance of the struct to
- * be created against particular PE. In nature, PEs corelate
+ * be created against particular PE. In nature, PEs correlate
  * to each other. the struct has to reflect that hierarchy in
  * order to easily pick up those affected PEs when one particular
  * PE has EEH errors.
-- 
2.8.2.534.g1f66975

Re: [PATCH 0213/1529] Fix typo

From: Russell Currey <hidden>
Date: 2016-05-23 01:30:21 

On Sat, 2016-05-21 at 14:03 +0200, Andrea Gelmini wrote:
Signed-off-by: Andrea Gelmini <redacted>
---
This entire comment needs to be rewritten as it's incredibly confusing, but alas

Acked-by: Russell Currey <redacted>
quoted hunk
 arch/powerpc/include/asm/eeh.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h
index fb9f376..7d34f3d 100644
--- a/arch/powerpc/include/asm/eeh.h
+++ b/arch/powerpc/include/asm/eeh.h
@@ -57,7 +57,7 @@ struct pci_dn;
 /*
  * The struct is used to trace PE related EEH functionality.
  * In theory, there will have one instance of the struct to
- * be created against particular PE. In nature, PEs corelate
+ * be created against particular PE. In nature, PEs correlate
  * to each other. the struct has to reflect that hierarchy in
  * order to easily pick up those affected PEs when one particular
  * PE has EEH errors.

Re: [PATCH 0213/1529] Fix typo

From: Robert P. J. Day <hidden>
Date: 2016-05-23 07:13:43 

On Mon, 23 May 2016, Russell Currey wrote:

On Sat, 2016-05-21 at 14:03 +0200, Andrea Gelmini wrote:
quoted
Signed-off-by: Andrea Gelmini <redacted>
---
This entire comment needs to be rewritten as it's incredibly confusing, but alas

Acked-by: Russell Currey <redacted>
quoted
 arch/powerpc/include/asm/eeh.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h
index fb9f376..7d34f3d 100644
--- a/arch/powerpc/include/asm/eeh.h
+++ b/arch/powerpc/include/asm/eeh.h
@@ -57,7 +57,7 @@ struct pci_dn;
 /*
  * The struct is used to trace PE related EEH functionality.
  * In theory, there will have one instance of the struct to
  "there will have one instance"?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: [PATCH 0213/1529] Fix typo

From: Russell Currey <hidden>
Date: 2016-05-24 00:05:07 

On Mon, 2016-05-23 at 03:12 -0400, Robert P. J. Day wrote:
On Mon, 23 May 2016, Russell Currey wrote:
quoted
On Sat, 2016-05-21 at 14:03 +0200, Andrea Gelmini wrote:
quoted
Signed-off-by: Andrea Gelmini <redacted>
---
This entire comment needs to be rewritten as it's incredibly confusing, but
alas

Acked-by: Russell Currey <redacted>
quoted
 arch/powerpc/include/asm/eeh.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/include/asm/eeh.h
b/arch/powerpc/include/asm/eeh.h
index fb9f376..7d34f3d 100644
--- a/arch/powerpc/include/asm/eeh.h
+++ b/arch/powerpc/include/asm/eeh.h
@@ -57,7 +57,7 @@ struct pci_dn;
 /*
  * The struct is used to trace PE related EEH functionality.
  * In theory, there will have one instance of the struct to
  "there will have one instance"?
See "This entire comment needs to be rewritten as it's incredibly confusing" :)

EEH documentation, both in source and in Documentation/powerpc/, is very much in
need of updates and reworks.  I'm working on it.

- Russell

Re: [PATCH 0213/1529] Fix typo

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-05-24 03:11:08 

On Tue, 2016-05-24 at 10:04 +1000, Russell Currey wrote:
On Mon, 2016-05-23 at 03:12 -0400, Robert P. J. Day wrote:
quoted
On Mon, 23 May 2016, Russell Currey wrote:
quoted
On Sat, 2016-05-21 at 14:03 +0200, Andrea Gelmini wrote:
quoted
Signed-off-by: Andrea Gelmini <redacted>
---
This entire comment needs to be rewritten as it's incredibly confusing, but
alas

Acked-by: Russell Currey <redacted>
quoted
 arch/powerpc/include/asm/eeh.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/include/asm/eeh.h
b/arch/powerpc/include/asm/eeh.h
index fb9f376..7d34f3d 100644
--- a/arch/powerpc/include/asm/eeh.h
+++ b/arch/powerpc/include/asm/eeh.h
@@ -57,7 +57,7 @@ struct pci_dn;
 /*
  * The struct is used to trace PE related EEH functionality.
  * In theory, there will have one instance of the struct to
  "there will have one instance"?
See "This entire comment needs to be rewritten as it's incredibly confusing" :)

EEH documentation, both in source and in Documentation/powerpc/, is very much in
need of updates and reworks.  I'm working on it.
Thanks. I'll wait for that, I'm not interested in merging a single byte typo
fix to an otherwise badly worded comment.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help