[PATCH] cxl: Remove duplicate #defines

Subsystems: char and misc drivers, the rest

STALE3750d

3 messages, 3 authors, 2016-05-10 · open the first message on its own page

[PATCH] cxl: Remove duplicate #defines

From: Ian Munsie <hidden>
Date: 2016-05-04 05:00:49

From: Ian Munsie <redacted>

These defines are not used, but other equivalent definitions
(CXL_SPA_SW_CMD_*) are used. Remove the unused defines.

Signed-off-by: Ian Munsie <redacted>
---
 drivers/misc/cxl/cxl.h | 9 ---------
 1 file changed, 9 deletions(-)
diff --git a/drivers/misc/cxl/cxl.h b/drivers/misc/cxl/cxl.h
index dfdbfb0..2823fb3 100644
--- a/drivers/misc/cxl/cxl.h
+++ b/drivers/misc/cxl/cxl.h
@@ -178,15 +178,6 @@ static const cxl_p2n_reg_t CXL_PSL_WED_An     = {0x0A0};
 #define CXL_PSL_SR_An_MP  (1ull << (63-62)) /* Master Process */
 #define CXL_PSL_SR_An_LE  (1ull << (63-63)) /* Little Endian */
 
-/****** CXL_PSL_LLCMD_An ****************************************************/
-#define CXL_LLCMD_TERMINATE   0x0001000000000000ULL
-#define CXL_LLCMD_REMOVE      0x0002000000000000ULL
-#define CXL_LLCMD_SUSPEND     0x0003000000000000ULL
-#define CXL_LLCMD_RESUME      0x0004000000000000ULL
-#define CXL_LLCMD_ADD         0x0005000000000000ULL
-#define CXL_LLCMD_UPDATE      0x0006000000000000ULL
-#define CXL_LLCMD_HANDLE_MASK 0x000000000000ffffULL
-
 /****** CXL_PSL_ID_An ****************************************************/
 #define CXL_PSL_ID_An_F	(1ull << (63-31))
 #define CXL_PSL_ID_An_L	(1ull << (63-30))
-- 
2.1.4

Re: [PATCH] cxl: Remove duplicate #defines

From: Andrew Donnellan <hidden>
Date: 2016-05-04 05:48:17

On 04/05/16 14:48, Ian Munsie wrote:
From: Ian Munsie <redacted>

These defines are not used, but other equivalent definitions
(CXL_SPA_SW_CMD_*) are used. Remove the unused defines.

Signed-off-by: Ian Munsie <redacted>
They definitely look unused.

Reviewed-by: Andrew Donnellan <redacted>

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited

Re: cxl: Remove duplicate #defines

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-05-10 21:48:44

On Wed, 2016-04-05 at 04:48:32 UTC, Ian Munsie wrote:
From: Ian Munsie <redacted>

These defines are not used, but other equivalent definitions
(CXL_SPA_SW_CMD_*) are used. Remove the unused defines.

Signed-off-by: Ian Munsie <redacted>
Reviewed-by: Andrew Donnellan <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/29659b682c47986d7d4e6206d9

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help