# \[PATCH v3 5/6\] pv-qspinlock: use cmpxchg\_release in \_\_pv\_queued\_spin\_unlock

- From: Pan Xinhui \<hidden\>
- Date: 2016-05-25 08:21:27 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2016/05/4757685
- Thread: https://ratatoskr.run/linuxppc-dev/2016/05/4757687/t.md

```text
cmpxchg_release is light-wight than cmpxchg, we can gain a better
performace then. On some arch like ppc, barrier impact the performace
too much.

Suggested-by:  Boqun Feng <redacted>
Signed-off-by: Pan Xinhui <redacted>
---
 kernel/locking/qspinlock_paravirt.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/locking/qspinlock_paravirt.h b/kernel/locking/qspinlock_paravirt.h
index a5b1248..2bbffe4 100644
--- a/kernel/locking/qspinlock_paravirt.h
+++ b/kernel/locking/qspinlock_paravirt.h
@@ -614,7 +614,7 @@ __visible void __pv_queued_spin_unlock(struct qspinlock *lock)
 	 * unhash. Otherwise it would be possible to have multiple @lock
 	 * entries, which would be BAD.
 	 */
-	locked = cmpxchg(&l->locked, _Q_LOCKED_VAL, 0);
+	locked = cmpxchg_release(&l->locked, _Q_LOCKED_VAL, 0);
 	if (likely(locked == _Q_LOCKED_VAL))
 		return;
 
-- 
1.9.1
```
