# Re: \[PATCH V2 26/68\] powerpc/mm/radix: Add radix pte defines

- From: Benjamin Herrenschmidt \<benh@kernel.crashing.org\>
- Date: 2016-04-23 08:30:28 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2016/04/9489531
- Thread: https://ratatoskr.run/linuxppc-dev/2016/04/9489240/t/2.md

```text
On Thu, 2016-04-21 at 14:12 +1000, Balbir Singh wrote:
> > +     } while (cpu_to_be64(old_pte) != __cmpxchg_u64((unsigned long *)ptep,
> > +                                                    cpu_to_be64(old_pte),
> > +                                                    cpu_to_be64(new_pte)));
> > +     /* We already do a sync in cmpxchg, is ptesync needed ?*/
> > +     asm volatile("ptesync" : : : "memory");
> 
> Yes, I think ptesync is required after PTE changes

Is it really on radix ? I'm not 100% sure... it's usually needed to
synchronize the writebacks of R and C...

Cheers,
Ben.
```
