[PATCH 1/2] powerpc: Remove orphaned asm implementation of abs()

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE3777d

4 messages, 1 author, 2016-04-11 · open the first message on its own page

[PATCH 1/2] powerpc: Remove orphaned asm implementation of abs()

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-03-16 10:36:12

This has been unused since ~2004, remove it.

Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 arch/powerpc/kernel/misc_32.S | 6 ------
 1 file changed, 6 deletions(-)
diff --git a/arch/powerpc/kernel/misc_32.S b/arch/powerpc/kernel/misc_32.S
index be8edd67f05b..c0cd779adfc3 100644
--- a/arch/powerpc/kernel/misc_32.S
+++ b/arch/powerpc/kernel/misc_32.S
@@ -684,12 +684,6 @@ _GLOBAL(__bswapdi2)
 	mr      r4,r10
 	blr
 
-_GLOBAL(abs)
-	srawi	r4,r3,31
-	xor	r3,r3,r4
-	sub	r3,r3,r4
-	blr
-
 #ifdef CONFIG_SMP
 _GLOBAL(start_secondary_resume)
 	/* Reset stack */
-- 
2.5.0

[PATCH 2/2] powerpc: Make generic_memcpy() private to copy_32.S

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-03-16 10:36:14

generic_memcpy() is only called from copy_32.S, so there's no reason for
it to be global.

Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 arch/powerpc/lib/copy_32.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/lib/copy_32.S b/arch/powerpc/lib/copy_32.S
index c44df2dbedd5..99f37f24185c 100644
--- a/arch/powerpc/lib/copy_32.S
+++ b/arch/powerpc/lib/copy_32.S
@@ -217,7 +217,7 @@ _GLOBAL(memcpy)
 	bdnz	40b
 65:	blr
 
-_GLOBAL(generic_memcpy)
+generic_memcpy:
 	srwi.	r7,r5,3
 	addi	r6,r3,-4
 	addi	r4,r4,-4
-- 
2.5.0

Re: [1/2] powerpc: Remove orphaned asm implementation of abs()

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-04-11 12:35:05

On Wed, 2016-16-03 at 10:36:05 UTC, Michael Ellerman wrote:
This has been unused since ~2004, remove it.

Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Applied to powerpc next.

https://git.kernel.org/powerpc/c/b05fac783a75c6e9f3af2ce082

cheers

Re: [2/2] powerpc: Make generic_memcpy() private to copy_32.S

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-04-11 12:35:08

On Wed, 2016-16-03 at 10:36:06 UTC, Michael Ellerman wrote:
generic_memcpy() is only called from copy_32.S, so there's no reason for
it to be global.

Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Applied to powerpc next.

https://git.kernel.org/powerpc/c/b4c6afdc3a1ad73542c8e92220

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help