[PATCH] cxl: Remove dead code

Subsystems: char and misc drivers, the rest

STALE3767d

5 messages, 5 authors, 2016-04-11 · open the first message on its own page

[PATCH] cxl: Remove dead code

From: Frederic Barrat <hidden>
Date: 2016-03-09 11:53:23

Function cxl_get_phys_dev() was removed from the kernel API by a
previous patch, but it's actually dead code. Remove it.

Signed-off-by: Frederic Barrat <redacted>
---
 drivers/misc/cxl/api.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
index 2107c94..8075823 100644
--- a/drivers/misc/cxl/api.c
+++ b/drivers/misc/cxl/api.c

@@ -68,15 +68,6 @@ struct cxl_context *cxl_get_context(struct pci_dev *dev)
 }
 EXPORT_SYMBOL_GPL(cxl_get_context);
 
-struct device *cxl_get_phys_dev(struct pci_dev *dev)
-{
-	struct cxl_afu *afu;
-
-	afu = cxl_pci_to_afu(dev);
-
-	return afu->adapter->dev.parent;
-}
-
 int cxl_release_context(struct cxl_context *ctx)
 {
 	if (ctx->status >= STARTED)

-- 
1.9.1

Re: [PATCH] cxl: Remove dead code

From: Ian Munsie <hidden>
Date: 2016-03-09 23:23:34

Acked-by: Ian Munsie <redacted>

Re: [PATCH] cxl: Remove dead code

From: Andrew Donnellan <hidden>
Date: 2016-03-09 23:36:13

On 09/03/16 22:53, Frederic Barrat wrote:

Function cxl_get_phys_dev() was removed from the kernel API by a
previous patch, but it's actually dead code. Remove it.

Signed-off-by: Frederic Barrat <redacted>

For those playing along at home, this applies on top of the cxl PowerVM 
series.

Reviewed-by: Andrew Donnellan <redacted>

-- 
Andrew Donnellan              Software Engineer, OzLabs
andrew.donnellan@au1.ibm.com  Australia Development Lab, Canberra
+61 2 6201 8874 (work)        IBM Australia Limited

Re: [PATCH] cxl: Remove dead code

From: Michael Neuling <hidden>
Date: 2016-03-09 23:59:49

On Wed, 2016-03-09 at 12:53 +0100, Frederic Barrat wrote:

Function cxl_get_phys_dev() was removed from the kernel API by a
previous patch, but it's actually dead code. Remove it.
=20
Signed-off-by: Frederic Barrat <redacted>

Acked-by: Michael Neuling <redacted>

quoted hunk

---
 drivers/misc/cxl/api.c | 9 ---------
 1 file changed, 9 deletions(-)
=20

diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
index 2107c94..8075823 100644
--- a/drivers/misc/cxl/api.c
+++ b/drivers/misc/cxl/api.c

@@ -68,15 +68,6 @@ struct cxl_context *cxl_get_context(struct pci_dev

*dev)
 }
 EXPORT_SYMBOL_GPL(cxl_get_context);
=20
-struct device *cxl_get_phys_dev(struct pci_dev *dev)
-{
-	struct cxl_afu *afu;
-
-	afu =3D cxl_pci_to_afu(dev);
-
-	return afu->adapter->dev.parent;
-}
-
 int cxl_release_context(struct cxl_context *ctx)
 {
 	if (ctx->status >=3D STARTED)

Re: cxl: Remove dead code

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-04-11 12:35:12

On Wed, 2016-09-03 at 11:53:13 UTC, Frederic Barrat wrote:

Function cxl_get_phys_dev() was removed from the kernel API by a
previous patch, but it's actually dead code. Remove it.

Signed-off-by: Frederic Barrat <redacted>
Acked-by: Ian Munsie <redacted>
Reviewed-by: Andrew Donnellan <redacted>
Acked-by: Michael Neuling <redacted>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/d88e397f12ba0c8c672952c471

cheers

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help