powerpc/mm: Fix HAVE_ARCH_SOFT_DIRTY dependencies

3 messages, 2 authors, 2016-02-22 · open the first message on its own page

powerpc/mm: Fix HAVE_ARCH_SOFT_DIRTY dependencies

From: Ben Hutchings <hidden>
Date: 2016-02-20 18:17:38

Soft dirty bit support was only implemented for 64-bit Book3S, and
32-bit configurations currently fail to build.

Fixes: 7207f43665b8 ("powerpc/mm: Add page soft dirty tracking")
References: https://buildd.debian.org/status/fetch.php?pkg=linux&arch=powerpc&ver=4.5%7Erc4-1%7Eexp1&stamp=1455791718
Signed-off-by: Ben Hutchings <redacted>
---
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -557,7 +557,7 @@ choice
 
 config PPC_4K_PAGES
 	bool "4k page size"
-	select HAVE_ARCH_SOFT_DIRTY if CHECKPOINT_RESTORE && PPC_BOOK3S
+	select HAVE_ARCH_SOFT_DIRTY if CHECKPOINT_RESTORE && PPC_BOOK3S_64
 
 config PPC_16K_PAGES
 	bool "16k page size"
@@ -566,7 +566,7 @@ config PPC_16K_PAGES
 config PPC_64K_PAGES
 	bool "64k page size"
 	depends on !PPC_FSL_BOOK3E && (44x || PPC_STD_MMU_64 || PPC_BOOK3E_64)
-	select HAVE_ARCH_SOFT_DIRTY if CHECKPOINT_RESTORE && PPC_BOOK3S
+	select HAVE_ARCH_SOFT_DIRTY if CHECKPOINT_RESTORE && PPC_BOOK3S_64
 
 config PPC_256K_PAGES
 	bool "256k page size"

Re: powerpc/mm: Fix HAVE_ARCH_SOFT_DIRTY dependencies

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-02-22 08:24:00

On Sat, 2016-20-02 at 17:58:37 UTC, Ben Hutchings wrote:
Soft dirty bit support was only implemented for 64-bit Book3S, and
32-bit configurations currently fail to build.

Fixes: 7207f43665b8 ("powerpc/mm: Add page soft dirty tracking")
References: https://buildd.debian.org/status/fetch.php?pkg=linux&arch=powerpc&ver=4.5%7Erc4-1%7Eexp1&stamp=1455791718
Signed-off-by: Ben Hutchings <redacted>
Thanks for the patch Ben.

I merged a similar but not identical patch into my fixes branch last week, and
Linus merged it over the weekend. Let me know if it isn't sufficient for you:

  https://git.kernel.org/torvalds/c/19f97c983071

cheers

Re: powerpc/mm: Fix HAVE_ARCH_SOFT_DIRTY dependencies

From: Ben Hutchings <hidden>
Date: 2016-02-22 09:39:36

On Mon, 2016-02-22 at 19:24 +1100, Michael Ellerman wrote:
On Sat, 2016-20-02 at 17:58:37 UTC, Ben Hutchings wrote:
quoted
Soft dirty bit support was only implemented for 64-bit Book3S, and
32-bit configurations currently fail to build.

Fixes: 7207f43665b8 ("powerpc/mm: Add page soft dirty tracking")
References: https://buildd.debian.org/status/fetch.php?pkg=linux&arch=powerpc&ver=4.5%7Erc4-1%7Eexp1&stamp=1455791718
Signed-off-by: Ben Hutchings <redacted>
Thanks for the patch Ben.

I merged a similar but not identical patch into my fixes branch last week, and
Linus merged it over the weekend. Let me know if it isn't sufficient for you:

  https://git.kernel.org/torvalds/c/19f97c983071
Yes that works, thanks.

Ben.

-- 
Ben Hutchings
The generation of random numbers is too important to be left to chance.
                                                            - Robert Coveyou
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help