# RE: \[PATCH\] mtd/ifc: Add support for IFC controller version 2.0

- From: Raghav Dogra \<hidden\>
- Date: 2016-02-15 06:33:36 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2016/02/9488099
- Thread: https://ratatoskr.run/linuxppc-dev/2016/02/9487899/t.md

```text


> -----Original Message-----
> From: Brian Norris [mailto:computersforpeace@gmail.com]
> Sent: Saturday, February 13, 2016 1:14 AM
> To: Li Yang <redacted>
> Cc: Raghav Dogra <redacted>; <redacted>;
> linuxppc-dev [ref]; oss@buserror.net; Prabhakar
> Kushwaha [ref]; Jaiprakash Singh
> [ref]
> Subject: Re: [PATCH] mtd/ifc: Add support for IFC controller version 2.0
>=20
> On Thu, Feb 04, 2016 at 05:07:16PM -0600, Li Yang wrote:
> > On Wed, Feb 3, 2016 at 12:36 AM, Raghav Dogra [ref]
> wrote:
> > > The new IFC controller version 2.0 has a different memory map page.
> > > Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB.
> > > This patch segregates the IFC global and runtime registers to
> > > appropriate PAGE sizes.
> >
> > If the global registers and the runtime registers are so independent
> > that they have to be on different page boundaries, it would make more
> > sense for them to be defined as separate reg regions in the device
> > tree at the very beginning.  Then we would only need to change the
> > device tree now and it would be future proof for any page size.
>=20
> To be clear: Scott, you were NACK'ing the DT binding change request, righ=
t? I
> though we had an Ack on the previous revision (that Raghav failed to carr=
y).
>=20
> > >
> > > Signed-off-by: Jaiprakash Singh <redacted>
> > > Signed-off-by: Raghav Dogra <redacted>
> >
> > The patch cannot apply on latest 4.5-rc cleanly either.  Otherwise,
>=20
> Yeah... neither this patch nor its (allegedly) dependent patch [1] apply
> cleanly.
>=20
> If you expect me to take this patch via MTD, please rebase to l2-mtd.git =
as
> stated here:
>=20
> http://linux-mtd.infradead.org/source.html
>
I expect Scott to pick this patch, and apply via linuxppc-dev. I will send =
the patch on based on git://git.kernel.org/pub/scm/linux/kernel/git/torvald=
s/linux.git
Branch "master"

-Raghav

> > Acked-by: Li Yang <redacted>
>=20
> Brian
>=20
> [1] https://patchwork.ozlabs.org/patch/564785/
```
