# Re: \[PATCH 3/3\] mtd/ifc: Segregate IFC fcm and runtime registers

- From: Scott Wood \<oss@buserror.net\>
- Date: 2016-02-01 22:26:58 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2016/02/9487877
- Thread: https://ratatoskr.run/linuxppc-dev/2016/02/9487864/t.md

```text
On Mon, 2016-02-01 at 16:16 +0530, Raghav Dogra wrote:
>  /*
>   * IFC Controller Registers
>   */
> -struct fsl_ifc_regs {
> +struct fsl_ifc_fcm {
>  	__be32 ifc_rev;
>  	u32 res1[0x2];
>  	struct {

This struct is not specific to fcm (i.e. nand).  Please choose a better name,
such as fsl_ifc_global (which would match "gregs").

-Scott
```
