[PATCH] powerpc/book3s_32: Fix build error with checkpoint restart

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE3837d

2 messages, 2 authors, 2016-01-31 · open the first message on its own page

[PATCH] powerpc/book3s_32: Fix build error with checkpoint restart

From: Aneesh Kumar K.V <hidden>
Date: 2016-01-29 17:03:06

In file included from mm/vmscan.c:54:0:
include/linux/swapops.h: In function ‘pte_to_swp_entry’:
include/linux/swapops.h:69:2: error: implicit declaration of function ‘pte_swp_soft_dirty’ [-Werror=implicit-function-declaration]
  if (pte_swp_soft_dirty(pte))
  ^
include/linux/swapops.h:70:3: error: implicit declaration of function ‘pte_swp_clear_soft_dirty’ [-Werror=implicit-function-declaration]
   pte = pte_swp_clear_soft_dirty(pte);

We support soft dirty tracking only with book3s 64 for now.
So change the Kconfig dependency accordingly. Also CHECKPOINT_RESTORE
feature is not really dependent on SOFT_DIRTY. We track the dependency
between MEM_SOFT_DIRTY and ARCH_SOFT_DIRTY through headers

Signed-off-by: Aneesh Kumar K.V <redacted>
---
 arch/powerpc/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 09b94174d372..599329332613 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -558,7 +558,7 @@ choice
 
 config PPC_4K_PAGES
 	bool "4k page size"
-	select HAVE_ARCH_SOFT_DIRTY if CHECKPOINT_RESTORE && PPC_BOOK3S
+	select HAVE_ARCH_SOFT_DIRTY if PPC_BOOK3S_64
 
 config PPC_16K_PAGES
 	bool "16k page size"
@@ -567,7 +567,7 @@ config PPC_16K_PAGES
 config PPC_64K_PAGES
 	bool "64k page size"
 	depends on !PPC_FSL_BOOK3E && (44x || PPC_STD_MMU_64 || PPC_BOOK3E_64)
-	select HAVE_ARCH_SOFT_DIRTY if CHECKPOINT_RESTORE && PPC_BOOK3S
+	select HAVE_ARCH_SOFT_DIRTY if PPC_BOOK3S_64
 
 config PPC_256K_PAGES
 	bool "256k page size"
-- 
2.5.0

Re: powerpc/book3s_32: Fix build error with checkpoint restart

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-01-31 08:37:38

On Fri, 2016-29-01 at 17:02:49 UTC, "Aneesh Kumar K.V" wrote:
In file included from mm/vmscan.c:54:0:
include/linux/swapops.h: In function ���pte_to_swp_entry���:
include/linux/swapops.h:69:2: error: implicit declaration of function ���pte_swp_soft_dirty��� [-Werror=implicit-function-declaration]
  if (pte_swp_soft_dirty(pte))
  ^
include/linux/swapops.h:70:3: error: implicit declaration of function ���pte_swp_clear_soft_dirty��� [-Werror=implicit-function-declaration]
   pte = pte_swp_clear_soft_dirty(pte);

We support soft dirty tracking only with book3s 64 for now.
So change the Kconfig dependency accordingly. Also CHECKPOINT_RESTORE
feature is not really dependent on SOFT_DIRTY. We track the dependency
between MEM_SOFT_DIRTY and ARCH_SOFT_DIRTY through headers

Signed-off-by: Aneesh Kumar K.V <redacted>
Applied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/19f97c98307115f5a6b0bbf848

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help