[PATCH] dma driver: fix potential oom issue of fsldma
Subsystems:
dma generic offload engine subsystem , freescale dma driver , the rest
3822d
3 messages,
2 authors,
2016-03-07 · open the first message on its own page
From: Xuelin Shi <redacted>
missing unmap sources and destinations while doing dequeue.
Signed-off-by: Xuelin Shi <redacted>
---
drivers/dma/fsldma.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index 2209f75..aac85c3 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c @@ -522,6 +522,8 @@ static dma_cookie_t fsldma_run_tx_complete_actions(struct fsldma_chan *chan,
chan_dbg ( chan , "LD %p callback \n " , desc );
txd -> callback ( txd -> callback_param );
}
+ + dma_descriptor_unmap ( txd ); }
/* Run any dependencies */ --
1.8.4
The change looks to be correct. But we need better formatting and description.
Make the title something like:
dmaengine: fsldma: fix memory leak
On Thu, Dec 24, 2015 at 1:26 AM, Xuelin Shi [off-list ref] wrote: From: Xuelin Shi <redacted>
missing unmap sources and destinations while doing dequeue.
How can this describe your change?
Regards,
Leo quoted hunk
Signed-off-by: Xuelin Shi <redacted>
---
drivers/dma/fsldma.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index 2209f75..aac85c3 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c @@ -522,6 +522,8 @@ static dma_cookie_t fsldma_run_tx_complete_actions(struct fsldma_chan *chan,
chan_dbg ( chan , "LD %p callback \n " , desc );
txd -> callback ( txd -> callback_param );
}
+ + dma_descriptor_unmap ( txd ); }
/* Run any dependencies */
- - 1.8.4
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
On Thu, Dec 24, 2015 at 1:26 AM, Xuelin Shi [off-list ref] wrote: From: Xuelin Shi <redacted>
And please cc dmaengine maintainers and its mailing list when you send
next version.
quoted hunk
missing unmap sources and destinations while doing dequeue.
Signed-off-by: Xuelin Shi <redacted>
---
drivers/dma/fsldma.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index 2209f75..aac85c3 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c @@ -522,6 +522,8 @@ static dma_cookie_t fsldma_run_tx_complete_actions(struct fsldma_chan *chan,
chan_dbg ( chan , "LD %p callback \n " , desc );
txd -> callback ( txd -> callback_param );
}
+ + dma_descriptor_unmap ( txd ); }
/* Run any dependencies */
- - 1.8.4
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev