[PATCH] powerpc/numa: Use of_get_next_parent to simplify code

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE3948d

2 messages, 2 authors, 2015-10-15 · open the first message on its own page

[PATCH] powerpc/numa: Use of_get_next_parent to simplify code

From: Christophe JAILLET <hidden>
Date: 2015-10-11 20:31:40 

of_get_next_parent can be used to simplify the while() loop and
avoid the need of a temp variable.

Signed-off-by: Christophe JAILLET <redacted>
---
 arch/powerpc/mm/numa.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index 8b9502a..b85d442 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -276,7 +276,6 @@ static int of_node_to_nid_single(struct device_node *device)
 /* Walk the device tree upwards, looking for an associativity id */
 int of_node_to_nid(struct device_node *device)
 {
-	struct device_node *tmp;
 	int nid = -1;
 
 	of_node_get(device);
@@ -285,9 +284,7 @@ int of_node_to_nid(struct device_node *device)
 		if (nid != -1)
 			break;
 
-	        tmp = device;
-		device = of_get_parent(tmp);
-		of_node_put(tmp);
+		device = of_get_next_parent(device);
 	}
 	of_node_put(device);
 
-- 
2.1.4

Re: powerpc/numa: Use of_get_next_parent to simplify code

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2015-10-15 11:11:03 

On Sun, 2015-11-10 at 20:23:27 UTC, Christophe Jaillet wrote:
of_get_next_parent can be used to simplify the while() loop and
avoid the need of a temp variable.

Signed-off-by: Christophe JAILLET <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/1def37586fb1f3bbbedeaa64

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help