# Re: \[PATCH 09/31\] powerpc/mm: Don't use pte\_val as lvalue

- From: Scott Wood \<hidden\>
- Date: 2015-09-22 02:22:38 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2015/09/9486165
- Thread: https://ratatoskr.run/linuxppc-dev/2015/09/9486115/t.md

```text
On Mon, Sep 21, 2015 at 12:10:36PM +0530, Aneesh Kumar K.V wrote:
> +static inline pte_t pte_mkwrite(pte_t pte)
> +{
> +	pte_basic_t ptev;
> +
> +	ptev = pte_val(pte) & ~_PAGE_RO;
> +	ptev |= _PAGE_RW;
> +	return __pte(pte);
> +}

s/__pte(pte)/__pte(ptev)/

...to fix an endless handle_mm_fault() loop.

CONFIG_STRICT_MM_TYPECHECKS would have caught this.

-Scott
```