Re: [PATCH 00/29] cxlflash: Miscellaneous bug fixes and corrections

Hi Matt & Manoj,

Can you also add linuxppc-dev@lists.ozlabs.org to the Cc list for
version 2?

Cheers,
-Ian

Excerpts from Matthew R. Ochs's message of 2015-09-15 06:12:29 +1000:

quoted

On Sep 13, 2015, at 8:12 PM, Ian Munsie [off-list ref] wrote:

Hi Matt & Manoj,

Just a general comment about this series - I'd like to see more detailed
commit messages for almost all these patches. Of course James is the
scsi maintainer and it's up to him whether to take these as is or not,
but generally when you write a commit message for a bug fix you want to
explain:

- What problem can occur, possibly including an example
- Why it occurs
- How this patch addresses it

You don't necessarily need to go overboard because at some point people
can just read the code, but some of these patches don't have any detail
beyond a single subject line, which is too little.

Speaking of the subject line - if the patch is fixing a bug there should
be some indication of that in the subject (it should probably include
the word "fix" somewhere). If the subject just states what you are
changing then it's not immediately obvious that it is a bug fix.

This is a reasonable request. Will incorporate your suggestions
and send out in a v2 series. Thanks for the examples of what you
would like to see.


-matt

On Sep 15, 2015, at 9:50 PM, Ian Munsie [off-list ref] wrote:

Hi Matt & Manoj,

Can you also add linuxppc-dev@lists.ozlabs.org to the Cc list for
version 2?

Will do.