[PATCH V2] powerpc/85xx: Remove unused pci fixup hooks on c293pcie

Subsystems: linux for powerpc (32-bit and 64-bit), linux for powerpc embedded ppc85xx, the rest

STALE4044d

3 messages, 2 authors, 2015-08-18 · open the first message on its own page

[PATCH V2] powerpc/85xx: Remove unused pci fixup hooks on c293pcie

From: Zhiqiang Hou <hidden>
Date: 2015-08-10 09:59:24

From: Hou Zhiqiang <redacted>

The c293pcie board is an endpoint device and it doesn't need PM,
so remove hooks pcibios_fixup_phb and pcibios_fixup_bus.

Signed-off-by: Hou Zhiqiang <redacted>
---
Test on c293pcie board:
V2:
    Rename the title of this patch.
    Remove pcibios_fixup_bus that isn't used in EP.

 arch/powerpc/platforms/85xx/c293pcie.c | 4 ----
 1 file changed, 4 deletions(-)
diff --git a/arch/powerpc/platforms/85xx/c293pcie.c b/arch/powerpc/platforms/85xx/c293pcie.c
index 84476b6..61bc851 100644
--- a/arch/powerpc/platforms/85xx/c293pcie.c
+++ b/arch/powerpc/platforms/85xx/c293pcie.c
@@ -66,10 +66,6 @@ define_machine(c293_pcie) {
 	.probe			= c293_pcie_probe,
 	.setup_arch		= c293_pcie_setup_arch,
 	.init_IRQ		= c293_pcie_pic_init,
-#ifdef CONFIG_PCI
-	.pcibios_fixup_bus	= fsl_pcibios_fixup_bus,
-	.pcibios_fixup_phb      = fsl_pcibios_fixup_phb,
-#endif
 	.get_irq		= mpic_get_irq,
 	.restart		= fsl_rstcr_restart,
 	.calibrate_decr		= generic_calibrate_decr,
-- 
2.1.0.27.g96db324

RE: [PATCH V2] powerpc/85xx: Remove unused pci fixup hooks on c293pcie

From: Hou Zhiqiang <hidden>
Date: 2015-08-18 09:26:09

SGkgU2NvdHQsDQoNClJlbW92ZWQgYm90aCBwY2liaW9zX2ZpeHVwX3BoYiBhbmQgcGNpYmlvc19m
aXh1cF9idXMuDQpDb3VsZCB5b3UgcGxlYXNlIGhlbHAgdG8gYXBwbHkgaXQ/DQoNCj4gLS0tLS1P
cmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogWmhpcWlhbmcgSG91IFttYWlsdG86QjQ4Mjg2
QGZyZWVzY2FsZS5jb21dDQo+IFNlbnQ6IDIwMTXE6jjUwjEwyNUgMTc6NDANCj4gVG86IGdhbGFr
QGtlcm5lbC5jcmFzaGluZy5vcmc7IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnOyBXb29k
IFNjb3R0LQ0KPiBCMDc0MjENCj4gQ2M6IEh1IE1pbmdrYWktQjIxMjg0OyBXYW5nIERvbmdzaGVu
Zy1CNDA1MzQ7IEhvdSBaaGlxaWFuZy1CNDgyODYNCj4gU3ViamVjdDogW1BBVENIIFYyXSBwb3dl
cnBjLzg1eHg6IFJlbW92ZSB1bnVzZWQgcGNpIGZpeHVwIGhvb2tzIG9uDQo+IGMyOTNwY2llDQo+
IA0KPiBGcm9tOiBIb3UgWmhpcWlhbmcgPEI0ODI4NkBmcmVlc2NhbGUuY29tPg0KPiANCj4gVGhl
IGMyOTNwY2llIGJvYXJkIGlzIGFuIGVuZHBvaW50IGRldmljZSBhbmQgaXQgZG9lc24ndCBuZWVk
IFBNLCBzbw0KPiByZW1vdmUgaG9va3MgcGNpYmlvc19maXh1cF9waGIgYW5kIHBjaWJpb3NfZml4
dXBfYnVzLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogSG91IFpoaXFpYW5nIDxCNDgyODZAZnJlZXNj
YWxlLmNvbT4NCj4gLS0tDQo+IFRlc3Qgb24gYzI5M3BjaWUgYm9hcmQ6DQo+IFYyOg0KPiAgICAg
UmVuYW1lIHRoZSB0aXRsZSBvZiB0aGlzIHBhdGNoLg0KPiAgICAgUmVtb3ZlIHBjaWJpb3NfZml4
dXBfYnVzIHRoYXQgaXNuJ3QgdXNlZCBpbiBFUC4NCj4gDQo+ICBhcmNoL3Bvd2VycGMvcGxhdGZv
cm1zLzg1eHgvYzI5M3BjaWUuYyB8IDQgLS0tLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDQgZGVsZXRp
b25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy84NXh4L2My
OTNwY2llLmMNCj4gYi9hcmNoL3Bvd2VycGMvcGxhdGZvcm1zLzg1eHgvYzI5M3BjaWUuYw0KPiBp
bmRleCA4NDQ3NmI2Li42MWJjODUxIDEwMDY0NA0KPiAtLS0gYS9hcmNoL3Bvd2VycGMvcGxhdGZv
cm1zLzg1eHgvYzI5M3BjaWUuYw0KPiArKysgYi9hcmNoL3Bvd2VycGMvcGxhdGZvcm1zLzg1eHgv
YzI5M3BjaWUuYw0KPiBAQCAtNjYsMTAgKzY2LDYgQEAgZGVmaW5lX21hY2hpbmUoYzI5M19wY2ll
KSB7DQo+ICAJLnByb2JlCQkJPSBjMjkzX3BjaWVfcHJvYmUsDQo+ICAJLnNldHVwX2FyY2gJCT0g
YzI5M19wY2llX3NldHVwX2FyY2gsDQo+ICAJLmluaXRfSVJRCQk9IGMyOTNfcGNpZV9waWNfaW5p
dCwNCj4gLSNpZmRlZiBDT05GSUdfUENJDQo+IC0JLnBjaWJpb3NfZml4dXBfYnVzCT0gZnNsX3Bj
aWJpb3NfZml4dXBfYnVzLA0KPiAtCS5wY2liaW9zX2ZpeHVwX3BoYiAgICAgID0gZnNsX3BjaWJp
b3NfZml4dXBfcGhiLA0KPiAtI2VuZGlmDQo+ICAJLmdldF9pcnEJCT0gbXBpY19nZXRfaXJxLA0K
PiAgCS5yZXN0YXJ0CQk9IGZzbF9yc3Rjcl9yZXN0YXJ0LA0KPiAgCS5jYWxpYnJhdGVfZGVjcgkJ
PSBnZW5lcmljX2NhbGlicmF0ZV9kZWNyLA0KPiAtLQ0KPiAyLjEuMC4yNy5nOTZkYjMyNA0KDQpU
aGFua3MsDQpaaGlxaWFuZw0KDQo=

Re: [PATCH V2] powerpc/85xx: Remove unused pci fixup hooks on c293pcie

From: Scott Wood <hidden>
Date: 2015-08-18 15:46:09

On Tue, 2015-08-18 at 04:26 -0500, Hou Zhiqiang-B48286 wrote:
Hi Scott,

Removed both pcibios_fixup_phb and pcibios_fixup_bus.
Could you please help to apply it?
I applied it and sent a pull request yesterday.

-Scott
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help