[PATCH] net: fs_enet: explicitly remove I flag on TX partial frames

Subsystems: freescale soc fs_enet driver, networking drivers, the rest

STALE4011d

2 messages, 2 authors, 2015-08-11 · open the first message on its own page

[PATCH] net: fs_enet: explicitly remove I flag on TX partial frames

From: Christophe Leroy <hidden>
Date: 2015-08-11 10:11:43

We are not interested in interrupts for partially transmitted frames,
we have to clear BD_ENET_TX_INTR explicitly otherwise it may remain
from a previously used descriptor.

Signed-off-by: Christophe Leroy <redacted>
---
 drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
index b9ad34e..84c18ee 100644
--- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
+++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
@@ -585,7 +585,8 @@ static int fs_enet_start_xmit(struct sk_buff *skb, struct net_device *dev)
 	frag = skb_shinfo(skb)->frags;
 	while (nr_frags) {
 		CBDC_SC(bdp,
-			BD_ENET_TX_STATS | BD_ENET_TX_LAST | BD_ENET_TX_TC);
+			BD_ENET_TX_STATS | BD_ENET_TX_INTR | BD_ENET_TX_LAST |
+			BD_ENET_TX_TC);
 		CBDS_SC(bdp, BD_ENET_TX_READY);
 
 		if ((CBDR_SC(bdp) & BD_ENET_TX_WRAP) == 0)
-- 
2.1.0

Re: [PATCH] net: fs_enet: explicitly remove I flag on TX partial frames

From: David Miller <davem@davemloft.net>
Date: 2015-08-11 19:05:47

From: Christophe Leroy <redacted>
Date: Tue, 11 Aug 2015 12:11:00 +0200 (CEST)
We are not interested in interrupts for partially transmitted frames,
we have to clear BD_ENET_TX_INTR explicitly otherwise it may remain
from a previously used descriptor.

Signed-off-by: Christophe Leroy <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help