[PATCH] c293/pci: remove hook pcibios_fixup_phb

Subsystems: linux for powerpc (32-bit and 64-bit), linux for powerpc embedded ppc85xx, the rest

STALE4017d

4 messages, 2 authors, 2015-08-10 · open the first message on its own page

[PATCH] c293/pci: remove hook pcibios_fixup_phb

From: Zhiqiang Hou <hidden>
Date: 2015-07-21 12:47:02

From: Hou Zhiqiang <redacted>

The c293pcie board is an endpoint device, and it does't need PM.

Signed-off-by: Hou Zhiqiang <redacted>
---
 arch/powerpc/platforms/85xx/c293pcie.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/platforms/85xx/c293pcie.c b/arch/powerpc/platforms/85xx/c293pcie.c
index 84476b6..213d5b8 100644
--- a/arch/powerpc/platforms/85xx/c293pcie.c
+++ b/arch/powerpc/platforms/85xx/c293pcie.c
@@ -68,7 +68,6 @@ define_machine(c293_pcie) {
 	.init_IRQ		= c293_pcie_pic_init,
 #ifdef CONFIG_PCI
 	.pcibios_fixup_bus	= fsl_pcibios_fixup_bus,
-	.pcibios_fixup_phb      = fsl_pcibios_fixup_phb,
 #endif
 	.get_irq		= mpic_get_irq,
 	.restart		= fsl_rstcr_restart,
-- 
2.1.0.27.g96db324

RE: [PATCH] c293/pci: remove hook pcibios_fixup_phb

From: Hou Zhiqiang <hidden>
Date: 2015-07-31 11:14:41

SGkgRG9uZ3NoZW5nIGFuZCBTY290dCwNCg0KRG8geW91IGhhdmUgYW55IGNvbW1lbnQ/DQoNCj4g
LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogWmhpcWlhbmcgSG91IFttYWlsdG86
QjQ4Mjg2QGZyZWVzY2FsZS5jb21dDQo+IFNlbnQ6IDIwMTXE6jfUwjIxyNUgMTg6MTANCj4gVG86
IGdhbGFrQGtlcm5lbC5jcmFzaGluZy5vcmc7IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3Jn
DQo+IENjOiBIdSBNaW5na2FpLUIyMTI4NDsgV2FuZyBEb25nc2hlbmctQjQwNTM0OyBIb3UgWmhp
cWlhbmctQjQ4Mjg2DQo+IFN1YmplY3Q6IFtQQVRDSF0gYzI5My9wY2k6IHJlbW92ZSBob29rIHBj
aWJpb3NfZml4dXBfcGhiDQo+IA0KPiBGcm9tOiBIb3UgWmhpcWlhbmcgPEI0ODI4NkBmcmVlc2Nh
bGUuY29tPg0KPiANCj4gVGhlIGMyOTNwY2llIGJvYXJkIGlzIGFuIGVuZHBvaW50IGRldmljZSwg
YW5kIGl0IGRvZXMndCBuZWVkIFBNLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogSG91IFpoaXFpYW5n
IDxCNDgyODZAZnJlZXNjYWxlLmNvbT4NCj4gLS0tDQo+ICBhcmNoL3Bvd2VycGMvcGxhdGZvcm1z
Lzg1eHgvYzI5M3BjaWUuYyB8IDEgLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgZGVsZXRpb24oLSkN
Cj4gDQo+IGRpZmYgLS1naXQgYS9hcmNoL3Bvd2VycGMvcGxhdGZvcm1zLzg1eHgvYzI5M3BjaWUu
Yw0KPiBiL2FyY2gvcG93ZXJwYy9wbGF0Zm9ybXMvODV4eC9jMjkzcGNpZS5jDQo+IGluZGV4IDg0
NDc2YjYuLjIxM2Q1YjggMTAwNjQ0DQo+IC0tLSBhL2FyY2gvcG93ZXJwYy9wbGF0Zm9ybXMvODV4
eC9jMjkzcGNpZS5jDQo+ICsrKyBiL2FyY2gvcG93ZXJwYy9wbGF0Zm9ybXMvODV4eC9jMjkzcGNp
ZS5jDQo+IEBAIC02OCw3ICs2OCw2IEBAIGRlZmluZV9tYWNoaW5lKGMyOTNfcGNpZSkgew0KPiAg
CS5pbml0X0lSUQkJPSBjMjkzX3BjaWVfcGljX2luaXQsDQo+ICAjaWZkZWYgQ09ORklHX1BDSQ0K
PiAgCS5wY2liaW9zX2ZpeHVwX2J1cwk9IGZzbF9wY2liaW9zX2ZpeHVwX2J1cywNCj4gLQkucGNp
Ymlvc19maXh1cF9waGIgICAgICA9IGZzbF9wY2liaW9zX2ZpeHVwX3BoYiwNCj4gICNlbmRpZg0K
PiAgCS5nZXRfaXJxCQk9IG1waWNfZ2V0X2lycSwNCj4gIAkucmVzdGFydAkJPSBmc2xfcnN0Y3Jf
cmVzdGFydCwNCj4gLS0NCj4gMi4xLjAuMjcuZzk2ZGIzMjQNCg0KVGhhbmtzLA0KWmhpcWlhbmcN
Cg==

Re: [PATCH] c293/pci: remove hook pcibios_fixup_phb

From: Scott Wood <hidden>
Date: 2015-07-31 17:24:36

On Fri, 2015-07-31 at 05:59 -0500, Hou Zhiqiang-B48286 wrote:
Hi Dongsheng and Scott,

Do you have any comment?
quoted
-----Original Message-----
From: Zhiqiang Hou [mailto:B48286@freescale.com]
Sent: 2015年7月21日 18:10
To: galak@kernel.crashing.org; linuxppc-dev@lists.ozlabs.org
Cc: Hu Mingkai-B21284; Wang Dongsheng-B40534; Hou Zhiqiang-B48286
Subject: [PATCH] c293/pci: remove hook pcibios_fixup_phb

From: Hou Zhiqiang <redacted>

The c293pcie board is an endpoint device, and it does't need PM.

Signed-off-by: Hou Zhiqiang <redacted>
---
 arch/powerpc/platforms/85xx/c293pcie.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/platforms/85xx/c293pcie.c
b/arch/powerpc/platforms/85xx/c293pcie.c
index 84476b6..213d5b8 100644
--- a/arch/powerpc/platforms/85xx/c293pcie.c
+++ b/arch/powerpc/platforms/85xx/c293pcie.c
@@ -68,7 +68,6 @@ define_machine(c293_pcie) {
    .init_IRQ               = c293_pcie_pic_init,
 #ifdef CONFIG_PCI
    .pcibios_fixup_bus      = fsl_pcibios_fixup_bus,
-   .pcibios_fixup_phb      = fsl_pcibios_fixup_phb,
 #endif
    .get_irq                = mpic_get_irq,
    .restart                = fsl_rstcr_restart,
If this is an endpoint why do you need pcibios_fixup_bus?

-Scott

RE: [PATCH] c293/pci: remove hook pcibios_fixup_phb

From: Hou Zhiqiang <hidden>
Date: 2015-08-10 10:04:01

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogMjAxNeW5tDjmnIgx5pelIDE6MjQNCj4gVG86IEhvdSBaaGlxaWFuZy1CNDgy
ODYNCj4gQ2M6IGdhbGFrQGtlcm5lbC5jcmFzaGluZy5vcmc7IGxpbnV4cHBjLWRldkBsaXN0cy5v
emxhYnMub3JnOyBIdSBNaW5na2FpLQ0KPiBCMjEyODQ7IFdhbmcgRG9uZ3NoZW5nLUI0MDUzNA0K
PiBTdWJqZWN0OiBSZTogW1BBVENIXSBjMjkzL3BjaTogcmVtb3ZlIGhvb2sgcGNpYmlvc19maXh1
cF9waGINCj4gDQo+IE9uIEZyaSwgMjAxNS0wNy0zMSBhdCAwNTo1OSAtMDUwMCwgSG91IFpoaXFp
YW5nLUI0ODI4NiB3cm90ZToNCj4gPiBIaSBEb25nc2hlbmcgYW5kIFNjb3R0LA0KPiA+DQo+ID4g
RG8geW91IGhhdmUgYW55IGNvbW1lbnQ/DQo+ID4NCj4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2Fn
ZS0tLS0tDQo+ID4gPiBGcm9tOiBaaGlxaWFuZyBIb3UgW21haWx0bzpCNDgyODZAZnJlZXNjYWxl
LmNvbV0NCj4gPiA+IFNlbnQ6IDIwMTXlubQ35pyIMjHml6UgMTg6MTANCj4gPiA+IFRvOiBnYWxh
a0BrZXJuZWwuY3Jhc2hpbmcub3JnOyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZw0KPiA+
ID4gQ2M6IEh1IE1pbmdrYWktQjIxMjg0OyBXYW5nIERvbmdzaGVuZy1CNDA1MzQ7IEhvdSBaaGlx
aWFuZy1CNDgyODYNCj4gPiA+IFN1YmplY3Q6IFtQQVRDSF0gYzI5My9wY2k6IHJlbW92ZSBob29r
IHBjaWJpb3NfZml4dXBfcGhiDQo+ID4gPg0KPiA+ID4gRnJvbTogSG91IFpoaXFpYW5nIDxCNDgy
ODZAZnJlZXNjYWxlLmNvbT4NCj4gPiA+DQo+ID4gPiBUaGUgYzI5M3BjaWUgYm9hcmQgaXMgYW4g
ZW5kcG9pbnQgZGV2aWNlLCBhbmQgaXQgZG9lcyd0IG5lZWQgUE0uDQo+ID4gPg0KPiA+ID4gU2ln
bmVkLW9mZi1ieTogSG91IFpoaXFpYW5nIDxCNDgyODZAZnJlZXNjYWxlLmNvbT4NCj4gPiA+IC0t
LQ0KPiA+ID4gIGFyY2gvcG93ZXJwYy9wbGF0Zm9ybXMvODV4eC9jMjkzcGNpZS5jIHwgMSAtDQo+
ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDEgZGVsZXRpb24oLSkNCj4gPiA+DQo+ID4gPiBkaWZmIC0t
Z2l0IGEvYXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy84NXh4L2MyOTNwY2llLmMNCj4gPiA+IGIvYXJj
aC9wb3dlcnBjL3BsYXRmb3Jtcy84NXh4L2MyOTNwY2llLmMNCj4gPiA+IGluZGV4IDg0NDc2YjYu
LjIxM2Q1YjggMTAwNjQ0DQo+ID4gPiAtLS0gYS9hcmNoL3Bvd2VycGMvcGxhdGZvcm1zLzg1eHgv
YzI5M3BjaWUuYw0KPiA+ID4gKysrIGIvYXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy84NXh4L2MyOTNw
Y2llLmMNCj4gPiA+IEBAIC02OCw3ICs2OCw2IEBAIGRlZmluZV9tYWNoaW5lKGMyOTNfcGNpZSkg
ew0KPiA+ID4gICAgIC5pbml0X0lSUSAgICAgICAgICAgICAgID0gYzI5M19wY2llX3BpY19pbml0
LA0KPiA+ID4gICNpZmRlZiBDT05GSUdfUENJDQo+ID4gPiAgICAgLnBjaWJpb3NfZml4dXBfYnVz
ICAgICAgPSBmc2xfcGNpYmlvc19maXh1cF9idXMsDQo+ID4gPiAtICAgLnBjaWJpb3NfZml4dXBf
cGhiICAgICAgPSBmc2xfcGNpYmlvc19maXh1cF9waGIsDQo+ID4gPiAgI2VuZGlmDQo+ID4gPiAg
ICAgLmdldF9pcnEgICAgICAgICAgICAgICAgPSBtcGljX2dldF9pcnEsDQo+ID4gPiAgICAgLnJl
c3RhcnQgICAgICAgICAgICAgICAgPSBmc2xfcnN0Y3JfcmVzdGFydCwNCj4gDQo+IElmIHRoaXMg
aXMgYW4gZW5kcG9pbnQgd2h5IGRvIHlvdSBuZWVkIHBjaWJpb3NfZml4dXBfYnVzPw0KPiANCg0K
VGhhbmtzIGFuZCB5ZXMsIGl0IGlzbid0IHVzZWQgaW4gZW5kcG9pbnQgbW9kZS4NClJlbW92ZWQg
aXQgaW4gcGF0Y2ggdmVyc2lvbiAyLg0KDQo+IC1TY290dA0KDQpUaGFua3MsDQpaaGlxaWFuZw0K
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help