[PATCH] powerpc: mpc512x: drop bogus and unused psc register bit definitions

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE3947d

3 messages, 2 authors, 2015-10-22 · open the first message on its own page

[PATCH] powerpc: mpc512x: drop bogus and unused psc register bit definitions

From: Uwe Kleine-König <hidden>
Date: 2015-07-21 07:21:29

These were introduced in commit 25ae3a0739c6 ("[POWERPC] mpc512x: Add
MPC512x PSC support to MPC52xx psc driver") and never used. Moreover
according to the datasheet[1] MEMERROR is bit 25 (0x40) and ORERR is
bit 27 (0x10).

[1] MPC5125RM Rev. 2; 11/2009

Signed-off-by: Uwe Kleine-König <redacted>
---
 arch/powerpc/include/asm/mpc52xx_psc.h | 2 --
 1 file changed, 2 deletions(-)
diff --git a/arch/powerpc/include/asm/mpc52xx_psc.h b/arch/powerpc/include/asm/mpc52xx_psc.h
index d0ece257d310..92806c24c2c5 100644
--- a/arch/powerpc/include/asm/mpc52xx_psc.h
+++ b/arch/powerpc/include/asm/mpc52xx_psc.h
@@ -258,8 +258,6 @@ struct mpc52xx_psc_fifo {
 #define MPC512x_PSC_FIFO_FULL		0x2
 #define MPC512x_PSC_FIFO_ALARM		0x4
 #define MPC512x_PSC_FIFO_URERR		0x8
-#define MPC512x_PSC_FIFO_ORERR		0x01
-#define MPC512x_PSC_FIFO_MEMERROR	0x02
 
 struct mpc512x_psc_fifo {
 	u32		reserved1[10];
-- 
2.1.4

Re: [PATCH] powerpc: mpc512x: drop bogus and unused psc register bit definitions

From: Uwe Kleine-König <hidden>
Date: 2015-09-18 06:52:17

Hello,

On Tue, Jul 21, 2015 at 09:21:13AM +0200, Uwe Kleine-König wrote:
These were introduced in commit 25ae3a0739c6 ("[POWERPC] mpc512x: Add
MPC512x PSC support to MPC52xx psc driver") and never used. Moreover
according to the datasheet[1] MEMERROR is bit 25 (0x40) and ORERR is
bit 27 (0x10).

[1] MPC5125RM Rev. 2; 11/2009
I didn't get any feedback for this patch yet. Do you still consider it?

Best regards
Uwe
quoted hunk
Signed-off-by: Uwe Kleine-König <redacted>
---
 arch/powerpc/include/asm/mpc52xx_psc.h | 2 --
 1 file changed, 2 deletions(-)
diff --git a/arch/powerpc/include/asm/mpc52xx_psc.h b/arch/powerpc/include/asm/mpc52xx_psc.h
index d0ece257d310..92806c24c2c5 100644
--- a/arch/powerpc/include/asm/mpc52xx_psc.h
+++ b/arch/powerpc/include/asm/mpc52xx_psc.h
@@ -258,8 +258,6 @@ struct mpc52xx_psc_fifo {
 #define MPC512x_PSC_FIFO_FULL		0x2
 #define MPC512x_PSC_FIFO_ALARM		0x4
 #define MPC512x_PSC_FIFO_URERR		0x8
-#define MPC512x_PSC_FIFO_ORERR		0x01
-#define MPC512x_PSC_FIFO_MEMERROR	0x02
 
 struct mpc512x_psc_fifo {
 	u32		reserved1[10];
-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Re: [PATCH] powerpc: mpc512x: drop bogus and unused psc register bit definitions

From: Anatolij Gustschin <agust@denx.de>
Date: 2015-10-22 14:08:21

On Tue, 21 Jul 2015 09:21:13 +0200
Uwe Kleine-K=C3=B6nig [off-list ref] wrote:
These were introduced in commit 25ae3a0739c6 ("[POWERPC] mpc512x: Add
MPC512x PSC support to MPC52xx psc driver") and never used. Moreover
according to the datasheet[1] MEMERROR is bit 25 (0x40) and ORERR is
bit 27 (0x10).
=20
[1] MPC5125RM Rev. 2; 11/2009
=20
Signed-off-by: Uwe Kleine-K=C3=B6nig <redacted>
---
 arch/powerpc/include/asm/mpc52xx_psc.h | 2 --
 1 file changed, 2 deletions(-)
applied to mpc5xxx/next.

Thanks,

Anatolij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help