DORMANTno replies

[PATCH] freescale:Make receive and transmit functions have a return type of void

From: Nicholas Krause <hidden>
Date: 2015-07-07 18:07:21
Also in: netdev
Subsystem: freescale quicc engine ucc ethernet driver, networking drivers, the rest · Maintainers: Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

This makes various receive and transmit functions that always run
successfully to be declared to have a return of void for the driver
file, ucc_geth.c.

Signed-off-by: Nicholas Krause <redacted>
---
 drivers/net/ethernet/freescale/ucc_geth.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c
index 4dd40e0..78ebd73 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.c
+++ b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -1398,7 +1398,7 @@ static int adjust_enet_interface(struct ucc_geth_private *ugeth)
 	return 0;
 }
 
-static int ugeth_graceful_stop_tx(struct ucc_geth_private *ugeth)
+static void ugeth_graceful_stop_tx(struct ucc_geth_private *ugeth)
 {
 	struct ucc_fast_private *uccf;
 	u32 cecr_subblock;
@@ -1424,11 +1424,9 @@ static int ugeth_graceful_stop_tx(struct ucc_geth_private *ugeth)
 	} while (!(temp & UCC_GETH_UCCE_GRA) && --i);
 
 	uccf->stopped_tx = 1;
-
-	return 0;
 }
 
-static int ugeth_graceful_stop_rx(struct ucc_geth_private *ugeth)
+static void ugeth_graceful_stop_rx(struct ucc_geth_private *ugeth)
 {
 	struct ucc_fast_private *uccf;
 	u32 cecr_subblock;
@@ -1456,11 +1454,9 @@ static int ugeth_graceful_stop_rx(struct ucc_geth_private *ugeth)
 	} while (!(temp & GRACEFUL_STOP_ACKNOWLEDGE_RX) && --i);
 
 	uccf->stopped_rx = 1;
-
-	return 0;
 }
 
-static int ugeth_restart_tx(struct ucc_geth_private *ugeth)
+static void ugeth_restart_tx(struct ucc_geth_private *ugeth)
 {
 	struct ucc_fast_private *uccf;
 	u32 cecr_subblock;
@@ -1471,8 +1467,6 @@ static int ugeth_restart_tx(struct ucc_geth_private *ugeth)
 	    ucc_fast_get_qe_cr_subblock(ugeth->ug_info->uf_info.ucc_num);
 	qe_issue_cmd(QE_RESTART_TX, cecr_subblock, QE_CR_PROTOCOL_ETHERNET, 0);
 	uccf->stopped_tx = 0;
-
-	return 0;
 }
 
 static int ugeth_restart_rx(struct ucc_geth_private *ugeth)
-- 
2.1.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help