[PATCH] windfarm: make wf_critical_overtemp() static

Subsystems: linux for power macintosh, the rest

STALE4018d

2 messages, 2 authors, 2015-08-10 · open the first message on its own page

[PATCH] windfarm: make wf_critical_overtemp() static

From: Paul Bolle <hidden>
Date: 2015-07-31 12:12:35

wf_critical_overtemp() is exported. But nothing uses that export.
That's unsurprising because there's no header that defines it. Stop
exporting that function and make it static.

Signed-off-by: Paul Bolle <redacted>
---
Cross compiled only.

(And I really hope evolution didn't mangle this patch.)

 drivers/macintosh/windfarm_core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/macintosh/windfarm_core.c b/drivers/macintosh/windfarm_core.c
index cc7ece1712b5..681e5b4d4b6a 100644
--- a/drivers/macintosh/windfarm_core.c
+++ b/drivers/macintosh/windfarm_core.c
@@ -72,7 +72,7 @@ static inline void wf_notify(int event, void *param)
 	blocking_notifier_call_chain(&wf_client_list, event, param);
 }
 
-int wf_critical_overtemp(void)
+static int wf_critical_overtemp(void)
 {
 	static char * critical_overtemp_path = "/sbin/critical_overtemp";
 	char *argv[] = { critical_overtemp_path, NULL };
@@ -84,7 +84,6 @@ int wf_critical_overtemp(void)
 	return call_usermodehelper(critical_overtemp_path,
 				   argv, envp, UMH_WAIT_EXEC);
 }
-EXPORT_SYMBOL_GPL(wf_critical_overtemp);
 
 static int wf_thread_func(void *data)
 {
-- 
2.4.3

Re: windfarm: make wf_critical_overtemp() static

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2015-08-10 09:28:33

On Fri, 2015-31-07 at 12:12:20 UTC, Paul Bolle wrote:
wf_critical_overtemp() is exported. But nothing uses that export.
That's unsurprising because there's no header that defines it. Stop
exporting that function and make it static.

Signed-off-by: Paul Bolle <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/ca94bbab1a0336f34066

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help