[PATCH] cxl: Remove use of macro DEFINE_PCI_DEVICE_TABLE

Subsystems: char and misc drivers, the rest

STALE4007d

4 messages, 4 authors, 2015-08-27 · open the first message on its own page

[PATCH] cxl: Remove use of macro DEFINE_PCI_DEVICE_TABLE

From: Vaishali Thakkar <hidden>
Date: 2015-07-19 17:24:01

Macro DEFINE_PCI_DEVICE_TABLE is deprecated. So, here use
struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with
the goal of getting rid of this macro completely.

The Coccinelle semantic patch that performs this transformation
is as follows:

@@
identifier a;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer i;
@@
- DEFINE_PCI_DEVICE_TABLE(a)
+ const struct pci_device_id a[]
= i;

Signed-off-by: Vaishali Thakkar <redacted>
---
 drivers/misc/cxl/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
index 32ad097..3ed0621 100644
--- a/drivers/misc/cxl/pci.c
+++ b/drivers/misc/cxl/pci.c
@@ -133,7 +133,7 @@ u8 cxl_afu_cr_read8(struct cxl_afu *afu, int cr, u64 off)
 	return (val >> ((off & 0x3) * 8)) & 0xff;
 }
 
-static DEFINE_PCI_DEVICE_TABLE(cxl_pci_tbl) = {
+static const struct pci_device_id cxl_pci_tbl[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x0477), },
 	{ PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x044b), },
 	{ PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x04cf), },
-- 
1.9.1

Re: [PATCH] cxl: Remove use of macro DEFINE_PCI_DEVICE_TABLE

From: Michael Neuling <hidden>
Date: 2015-07-20 02:42:28

On Sun, 2015-07-19 at 22:53 +0530, Vaishali Thakkar wrote:
Macro DEFINE_PCI_DEVICE_TABLE is deprecated. So, here use
struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with
the goal of getting rid of this macro completely.
=20
The Coccinelle semantic patch that performs this transformation
is as follows:
=20
@@
identifier a;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer i;
@@
- DEFINE_PCI_DEVICE_TABLE(a)
+ const struct pci_device_id a[]
=3D i;
=20
Signed-off-by: Vaishali Thakkar <redacted>
Looks good, thanks!

Acked-by: Michael Neuling <redacted>

quoted hunk
---
 drivers/misc/cxl/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
=20
diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
index 32ad097..3ed0621 100644
--- a/drivers/misc/cxl/pci.c
+++ b/drivers/misc/cxl/pci.c
@@ -133,7 +133,7 @@ u8 cxl_afu_cr_read8(struct cxl_afu *afu, int cr, u64 =
off)
 	return (val >> ((off & 0x3) * 8)) & 0xff;
 }
=20
-static DEFINE_PCI_DEVICE_TABLE(cxl_pci_tbl) =3D {
+static const struct pci_device_id cxl_pci_tbl[] =3D {
 	{ PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x0477), },
 	{ PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x044b), },
 	{ PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x04cf), },

Re: [PATCH] cxl: Remove use of macro DEFINE_PCI_DEVICE_TABLE

From: Ian Munsie <hidden>
Date: 2015-07-20 02:47:07

Acked-by: Ian Munsie <redacted>

Re: cxl: Remove use of macro DEFINE_PCI_DEVICE_TABLE

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2015-08-27 21:58:37

On Sun, 2015-19-07 at 17:23:52 UTC, Vaishali Thakkar wrote:
Macro DEFINE_PCI_DEVICE_TABLE is deprecated. So, here use
struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with
the goal of getting rid of this macro completely.

The Coccinelle semantic patch that performs this transformation
is as follows:

@@
identifier a;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer i;
@@
- DEFINE_PCI_DEVICE_TABLE(a)
+ const struct pci_device_id a[]
= i;

Signed-off-by: Vaishali Thakkar <redacted>
Acked-by: Michael Neuling <redacted>
Acked-by: Ian Munsie <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/f47f966fbe0aaff4ebbdb83d

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help