[PATCH] cxl: Fix typo in debug print

Subsystems: char and misc drivers, the rest

STALE4074d

4 messages, 3 authors, 2015-06-18 · open the first message on its own page

[PATCH] cxl: Fix typo in debug print

From: Michael Neuling <hidden>
Date: 2015-06-18 05:15:10

Fix typo in debug print.  p1->p2.  No functional change.

Signed-off-by: Michael Neuling <redacted>
diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
index 1ef0164..8515791 100644
--- a/drivers/misc/cxl/pci.c
+++ b/drivers/misc/cxl/pci.c
@@ -204,7 +204,7 @@ static void dump_cxl_config_space(struct pci_dev *dev)
 	dev_info(&dev->dev, "p1 regs: %#llx, len: %#llx\n",
 		p1_base(dev), p1_size(dev));
 	dev_info(&dev->dev, "p2 regs: %#llx, len: %#llx\n",
-		p1_base(dev), p2_size(dev));
+		p2_base(dev), p2_size(dev));
 	dev_info(&dev->dev, "BAR 4/5: %#llx, len: %#llx\n",
 		pci_resource_start(dev, 4), pci_resource_len(dev, 4));
=20

Re: [PATCH] cxl: Fix typo in debug print

From: Ian Munsie <hidden>
Date: 2015-06-18 05:32:55

Acked-by: Ian Munsie <redacted>

Re: [PATCH] cxl: Fix typo in debug print

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2015-06-18 05:57:45

On Thu, 2015-06-18 at 15:15 +1000, Michael Neuling wrote:
Fix typo in debug print.  p1->p2.  No functional change.
That's not "no functional change", it changes the behaviour, unless p2_base()
implements the same logic as p1_base()?

cheers
quoted hunk
diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
index 1ef0164..8515791 100644
--- a/drivers/misc/cxl/pci.c
+++ b/drivers/misc/cxl/pci.c
@@ -204,7 +204,7 @@ static void dump_cxl_config_space(struct pci_dev *dev)
 	dev_info(&dev->dev, "p1 regs: %#llx, len: %#llx\n",
 		p1_base(dev), p1_size(dev));
 	dev_info(&dev->dev, "p2 regs: %#llx, len: %#llx\n",
-		p1_base(dev), p2_size(dev));
+		p2_base(dev), p2_size(dev));
 	dev_info(&dev->dev, "BAR 4/5: %#llx, len: %#llx\n",
 		pci_resource_start(dev, 4), pci_resource_len(dev, 4));
 

Re: [PATCH] cxl: Fix typo in debug print

From: Michael Neuling <hidden>
Date: 2015-06-18 06:12:08

On Thu, 2015-06-18 at 15:57 +1000, Michael Ellerman wrote:
On Thu, 2015-06-18 at 15:15 +1000, Michael Neuling wrote:
quoted
Fix typo in debug print.  p1->p2.  No functional change.
=20
That's not "no functional change", it changes the behaviour, unless p2_ba=
se()
implements the same logic as p1_base()?
Maybe I should change it to "Only debug output printing change"?

Mikey
=20
cheers
=20
quoted
diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
index 1ef0164..8515791 100644
--- a/drivers/misc/cxl/pci.c
+++ b/drivers/misc/cxl/pci.c
@@ -204,7 +204,7 @@ static void dump_cxl_config_space(struct pci_dev *d=
ev)
quoted
 	dev_info(&dev->dev, "p1 regs: %#llx, len: %#llx\n",
 		p1_base(dev), p1_size(dev));
 	dev_info(&dev->dev, "p2 regs: %#llx, len: %#llx\n",
-		p1_base(dev), p2_size(dev));
+		p2_base(dev), p2_size(dev));
 	dev_info(&dev->dev, "BAR 4/5: %#llx, len: %#llx\n",
 		pci_resource_start(dev, 4), pci_resource_len(dev, 4));
=20
=20
=20
=20
=20
=20
=20
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help