The sdhci framework disables SDR104/SDR50/DDR50 based on only quirk.
This patch adds the support to disable SDR104/SDR50/DDR50 based on
reading the capability register 0.
Signed-off-by: Suman Tripathi <redacted>
---
---
drivers/mmc/host/sdhci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
On Thu, May 21, 2015 at 2:13 PM, Suman Tripathi [off-list ref] wrote:
quoted hunk
The sdhci framework disables SDR104/SDR50/DDR50 based on only quirk.
This patch adds the support to disable SDR104/SDR50/DDR50 based on
reading the capability register 0.
Signed-off-by: Suman Tripathi <redacted>
---
---
drivers/mmc/host/sdhci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
On 21 May 2015 at 10:43, Suman Tripathi [off-list ref] wrote:
quoted hunk
The sdhci framework disables SDR104/SDR50/DDR50 based on only quirk.
This patch adds the support to disable SDR104/SDR50/DDR50 based on
reading the capability register 0.
Signed-off-by: Suman Tripathi <redacted>
---
---
drivers/mmc/host/sdhci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
@@ -3118,7 +3118,8 @@ int sdhci_add_host(struct sdhci_host *host)}}-if(host->quirks2&SDHCI_QUIRK2_NO_1_8_V)+if(host->quirks2&SDHCI_QUIRK2_NO_1_8_V||+!(caps[0]&SDHCI_CAN_VDD_180))caps[1]&=~(SDHCI_SUPPORT_SDR104|SDHCI_SUPPORT_SDR50|SDHCI_SUPPORT_DDR50);--
1.8.2.1
I have no problem with this patch, except that it would be nice to get
a few "tested by" to make sure it doesn't break UHS support for some
SoCs.
Kind regards
Uffe
On Tue, May 26, 2015 at 6:06 PM, Ulf Hansson [off-list ref] wrote:
On 21 May 2015 at 10:43, Suman Tripathi [off-list ref] wrote:
quoted
The sdhci framework disables SDR104/SDR50/DDR50 based on only quirk.
This patch adds the support to disable SDR104/SDR50/DDR50 based on
reading the capability register 0.
Signed-off-by: Suman Tripathi <redacted>
---
---
drivers/mmc/host/sdhci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
@@ -3118,7 +3118,8 @@ int sdhci_add_host(struct sdhci_host *host)}}-if(host->quirks2&SDHCI_QUIRK2_NO_1_8_V)+if(host->quirks2&SDHCI_QUIRK2_NO_1_8_V||+!(caps[0]&SDHCI_CAN_VDD_180))caps[1]&=~(SDHCI_SUPPORT_SDR104|SDHCI_SUPPORT_SDR50|SDHCI_SUPPORT_DDR50);--
1.8.2.1
I have no problem with this patch, except that it would be nice to get
a few "tested by" to make sure it doesn't break UHS support for some
SoCs.
Kind regards
Uffe
Can anyone test this in some other SoC ? Appreciate your help ..
--
Thanks,
with regards,
Suman Tripathi
Hi Aisheng,
On Wed, May 27, 2015 at 7:46 PM, Suman Tripathi [off-list ref] wrote:
On Tue, May 26, 2015 at 6:06 PM, Ulf Hansson [off-list ref]
wrote:
quoted
On 21 May 2015 at 10:43, Suman Tripathi [off-list ref] wrote:
quoted
The sdhci framework disables SDR104/SDR50/DDR50 based on only quirk.
This patch adds the support to disable SDR104/SDR50/DDR50 based on
reading the capability register 0.
Signed-off-by: Suman Tripathi <redacted>
---
---
drivers/mmc/host/sdhci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
@@ -3118,7 +3118,8 @@ int sdhci_add_host(struct sdhci_host *host)}}-if(host->quirks2&SDHCI_QUIRK2_NO_1_8_V)+if(host->quirks2&SDHCI_QUIRK2_NO_1_8_V||+!(caps[0]&SDHCI_CAN_VDD_180))caps[1]&=~(SDHCI_SUPPORT_SDR104|SDHCI_SUPPORT_SDR50
|
quoted
SDHCI_SUPPORT_DDR50);
--
1.8.2.1
I have no problem with this patch, except that it would be nice to get
a few "tested by" to make sure it doesn't break UHS support for some
SoCs.
Kind regards
Uffe
Can anyone test this in some other SoC ? Appreciate your help ..
Can you test this patch on imx SoC ?
On Mon, Jun 01, 2015 at 01:38:47PM +0530, Suman Tripathi wrote:
Hi Aisheng,
On Wed, May 27, 2015 at 7:46 PM, Suman Tripathi <[1]stripathi@apm.com>
wrote:
On Tue, May 26, 2015 at 6:06 PM, Ulf Hansson <[2]ulf.hansson@linaro.org>
wrote:
On 21 May 2015 at 10:43, Suman Tripathi <[3]stripathi@apm.com> wrote:
> The sdhci framework disables SDR104/SDR50/DDR50 based on only quirk.
> This patch adds the support to disable SDR104/SDR50/DDR50 based on
> reading the capability register 0.
>
> Signed-off-by: Suman Tripathi <[4]stripathi@apm.com>
> ---
> ---
> drivers/mmc/host/sdhci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 58c1770..a3d9b8a 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -3118,7 +3118,8 @@ int sdhci_add_host(struct sdhci_host *host)
> }
> }
>
> - if (host->quirks2 & SDHCI_QUIRK2_NO_1_8_V)
> + if (host->quirks2 & SDHCI_QUIRK2_NO_1_8_V ||
> + !(caps[0] & SDHCI_CAN_VDD_180))
> caps[1] &= ~(SDHCI_SUPPORT_SDR104 |
SDHCI_SUPPORT_SDR50 |
> SDHCI_SUPPORT_DDR50);
>
> --
> 1.8.2.1
>
I have no problem with this patch, except that it would be nice to get
a few "tested by" to make sure it doesn't break UHS support for some
SoCs.
Kind regards
Uffe
Can anyone test this in some other SoC ? Appreciate your help ..
Can you test this patch on imx SoC ?
(Your email have some format issue.)
I have tested this patch and it does not break imx SoC.
You can add my tag.
Tested-by: Dong Aisheng <redacted>
However, it looks to me SDHCI_CAN_VDD_180 is only indicating the host VDD
capabiliies, not IO voltage capability.
SD3.0 cards require 1.8v IO voltage support.
So should this bit affect SD3.0 support?
e.g. some hosts can only work at VDD_330 (most VDD of SD slot on IMX boards
is using external regulator and is fixed to 3.3v), but it can support 1.8v
IO voltage, so it can support SD3.0 cards as well.
Ulf,
Can you help confirm it?
Regards
Dong Aisheng
--
Thanks,
with regards,
Suman Tripathi
--
Thanks,
with regards,
Suman Tripathi
References
Visible links
1. mailto:stripathi@apm.com
2. mailto:ulf.hansson@linaro.org
3. mailto:stripathi@apm.com
4. mailto:stripathi@apm.com
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_TIME = "zh_CN.UTF-8",
LC_MONETARY = "zh_CN.UTF-8",
LC_ADDRESS = "zh_CN.UTF-8",
LC_TELEPHONE = "zh_CN.UTF-8",
LC_NAME = "zh_CN.UTF-8",
LC_MEASUREMENT = "zh_CN.UTF-8",
LC_IDENTIFICATION = "zh_CN.UTF-8",
LC_NUMERIC = "zh_CN.UTF-8",
LC_PAPER = "zh_CN.UTF-8",
LANG = "en_US.UTF-8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
On Fri, Jun 5, 2015 at 8:23 PM, Dong Aisheng [off-list ref] wrote:
On Mon, Jun 01, 2015 at 01:38:47PM +0530, Suman Tripathi wrote:
quoted
Hi Aisheng,
On Wed, May 27, 2015 at 7:46 PM, Suman Tripathi <[1]stripathi@apm.com>
wrote:
On Tue, May 26, 2015 at 6:06 PM, Ulf Hansson <[2]ulf.hansson@linaro.org>
wrote:
On 21 May 2015 at 10:43, Suman Tripathi <[3]stripathi@apm.com> wrote:
> The sdhci framework disables SDR104/SDR50/DDR50 based on only quirk.
> This patch adds the support to disable SDR104/SDR50/DDR50 based on
> reading the capability register 0.
>
> Signed-off-by: Suman Tripathi <[4]stripathi@apm.com>
> ---
> ---
> drivers/mmc/host/sdhci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 58c1770..a3d9b8a 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -3118,7 +3118,8 @@ int sdhci_add_host(struct sdhci_host *host)
> }
> }
>
> - if (host->quirks2 & SDHCI_QUIRK2_NO_1_8_V)
> + if (host->quirks2 & SDHCI_QUIRK2_NO_1_8_V ||
> + !(caps[0] & SDHCI_CAN_VDD_180))
> caps[1] &= ~(SDHCI_SUPPORT_SDR104 |
SDHCI_SUPPORT_SDR50 |
> SDHCI_SUPPORT_DDR50);
>
> --
> 1.8.2.1
>
I have no problem with this patch, except that it would be nice to get
a few "tested by" to make sure it doesn't break UHS support for some
SoCs.
Kind regards
Uffe
Can anyone test this in some other SoC ? Appreciate your help ..
Can you test this patch on imx SoC ?
(Your email have some format issue.)
Yeah missed to sent in plain text mode.
I have tested this patch and it does not break imx SoC.
You can add my tag.
Tested-by: Dong Aisheng <redacted>
Thanks Dong !!
However, it looks to me SDHCI_CAN_VDD_180 is only indicating the host VDD
capabiliies, not IO voltage capability.
Are you sure on this ?? If SDHCI host VDD is 1.8V then the cards are
also capable to operate at 1.8V ? Didn't understand what you mean by
IO voltage capability
SD3.0 cards require 1.8v IO voltage support.
So should this bit affect SD3.0 support?
The preset value resgister says that SDR modes requires 1.8V and we
disable the modes based on capability or quirk.
e.g. some hosts can only work at VDD_330 (most VDD of SD slot on IMX boards
is using external regulator and is fixed to 3.3v), but it can support 1.8v
IO voltage, so it can support SD3.0 cards as well.
Same for us but somehow 1.8v is broken in our version. Yeah so those
host can still use 1.8V by not setting the quirk or not setting the
capability register.
Ulf,
Can you help confirm it?
Regards
Dong Aisheng
quoted
--
Thanks,
with regards,
Suman Tripathi
--
Thanks,
with regards,
Suman Tripathi
References
Visible links
1. mailto:stripathi@apm.com
2. mailto:ulf.hansson@linaro.org
3. mailto:stripathi@apm.com
4. mailto:stripathi@apm.com
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_TIME = "zh_CN.UTF-8",
LC_MONETARY = "zh_CN.UTF-8",
LC_ADDRESS = "zh_CN.UTF-8",
LC_TELEPHONE = "zh_CN.UTF-8",
LC_NAME = "zh_CN.UTF-8",
LC_MEASUREMENT = "zh_CN.UTF-8",
LC_IDENTIFICATION = "zh_CN.UTF-8",
LC_NUMERIC = "zh_CN.UTF-8",
LC_PAPER = "zh_CN.UTF-8",
LANG = "en_US.UTF-8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
I have tested this patch and it does not break imx SoC.
You can add my tag.
Tested-by: Dong Aisheng <redacted>
Thanks Dong !!
quoted
However, it looks to me SDHCI_CAN_VDD_180 is only indicating the host VDD
capabiliies, not IO voltage capability.
I think Dong is correct. I don't think SDHCI_CAN_VDD_180 is not
related to UHS modes at all.
At least the name of the field (SDHCI_CAN_VDD_180) indicates it's
about VDD/VCC, the core power and not the IO voltage.
Are you sure on this ?? If SDHCI host VDD is 1.8V then the cards are
also capable to operate at 1.8V ? Didn't understand what you mean by
IO voltage capability
quoted
SD3.0 cards require 1.8v IO voltage support.
So should this bit affect SD3.0 support?
The preset value resgister says that SDR modes requires 1.8V and we
disable the modes based on capability or quirk.
It requires 1.8V *IO voltage*, not VDD/VCC.
[...]
Kind regards
Uffe