[PATCH v2] powerpc/dts: Add and fix 1588 timer node for eTSEC

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE4030d

6 messages, 2 authors, 2015-07-29 · open the first message on its own page

[PATCH v2] powerpc/dts: Add and fix 1588 timer node for eTSEC

From: Yangbo Lu <hidden>
Date: 2015-05-07 03:32:53

Add 1588 timer node in files:
arch/powerpc/boot/dts/bsc9131rdb.dtsi
arch/powerpc/boot/dts/bsc9132qds.dtsi
arch/powerpc/boot/dts/p1010rdb.dtsi
arch/powerpc/boot/dts/p1020rdb-pd.dts
arch/powerpc/boot/dts/p1021rdb-pc.dtsi
arch/powerpc/boot/dts/p1022ds.dtsi
arch/powerpc/boot/dts/p1025twr.dtsi
Fix 1588 timer node in file:
arch/powerpc/boot/dts/p2020rdb-pc.dtsi

Signed-off-by: Yangbo Lu <redacted>
---
Changes for v2:
	- Changed hex value to decimal value in dts
	- Modified commit message
	- Modified 1588 node in p2020rdb-pc.dtsi
---
 arch/powerpc/boot/dts/bsc9131rdb.dtsi  | 12 ++++++++++++
 arch/powerpc/boot/dts/bsc9132qds.dtsi  | 12 ++++++++++++
 arch/powerpc/boot/dts/p1010rdb.dtsi    | 12 ++++++++++++
 arch/powerpc/boot/dts/p1020rdb-pd.dts  | 12 ++++++++++++
 arch/powerpc/boot/dts/p1021rdb-pc.dtsi | 12 ++++++++++++
 arch/powerpc/boot/dts/p1022ds.dtsi     | 12 ++++++++++++
 arch/powerpc/boot/dts/p1025twr.dtsi    | 12 ++++++++++++
 arch/powerpc/boot/dts/p2020rdb-pc.dtsi | 12 ++++++------
 8 files changed, 90 insertions(+), 6 deletions(-)

diff --git a/arch/powerpc/boot/dts/bsc9131rdb.dtsi b/arch/powerpc/boot/dts/bsc9131rdb.dtsi
index 45efcba..a6d533e 100644
--- a/arch/powerpc/boot/dts/bsc9131rdb.dtsi
+++ b/arch/powerpc/boot/dts/bsc9131rdb.dtsi

@@ -80,6 +80,18 @@
 		status = "disabled";
 	};
 
+	ptp_clock@b0e00 {
+		compatible = "fsl,etsec-ptp";
+		reg = <0xb0e00 0xb0>;
+		interrupts = <68 2 0 0 69 2 0 0>;
+		fsl,tclk-period	= <5>;
+		fsl,tmr-prsc	= <2>;
+		fsl,tmr-add	= <3435973837>;
+		fsl,tmr-fiper1	= <999999995>;
+		fsl,tmr-fiper2	= <99990>;
+		fsl,max-adj	= <249999999>;
+	};
+
 	enet0: ethernet@b0000 {
 		phy-handle = <&phy0>;
 		phy-connection-type = "rgmii-id";

diff --git a/arch/powerpc/boot/dts/bsc9132qds.dtsi b/arch/powerpc/boot/dts/bsc9132qds.dtsi
index af8e888..ef75804 100644
--- a/arch/powerpc/boot/dts/bsc9132qds.dtsi
+++ b/arch/powerpc/boot/dts/bsc9132qds.dtsi

@@ -87,6 +87,18 @@
 		};
 	};
 
+	ptp_clock@b0e00 {
+		compatible = "fsl,etsec-ptp";
+		reg = <0xb0e00 0xb0>;
+		interrupts = <68 2 0 0 69 2 0 0>;
+		fsl,tclk-period	= <5>;
+		fsl,tmr-prsc	= <2>;
+		fsl,tmr-add	= <3435973837>;
+		fsl,tmr-fiper1	= <999999995>;
+		fsl,tmr-fiper2	= <99990>;
+		fsl,max-adj	= <249999999>;
+	};
+
 	enet0: ethernet@b0000 {
 		phy-handle = <&phy0>;
 		tbi-handle = <&tbi0>;

diff --git a/arch/powerpc/boot/dts/p1010rdb.dtsi b/arch/powerpc/boot/dts/p1010rdb.dtsi
index ea534ef..1613678 100644
--- a/arch/powerpc/boot/dts/p1010rdb.dtsi
+++ b/arch/powerpc/boot/dts/p1010rdb.dtsi

@@ -186,6 +186,18 @@
 		};
 	};
 
+	ptp_clock@b0e00 {
+		compatible = "fsl,etsec-ptp";
+		reg = <0xb0e00 0xb0>;
+		interrupts = <68 2 0 0 69 2 0 0>;
+		fsl,tclk-period	= <10>;
+		fsl,tmr-prsc	= <2>;
+		fsl,tmr-add	= <2147483670>;
+		fsl,tmr-fiper1	= <999999990>;
+		fsl,tmr-fiper2	= <99990>;
+		fsl,max-adj	= <199999999>;
+	};
+
 	enet0: ethernet@b0000 {
 		phy-handle = <&phy0>;
 		phy-connection-type = "rgmii-id";

diff --git a/arch/powerpc/boot/dts/p1020rdb-pd.dts b/arch/powerpc/boot/dts/p1020rdb-pd.dts
index 987017e..52e8fe8 100644
--- a/arch/powerpc/boot/dts/p1020rdb-pd.dts
+++ b/arch/powerpc/boot/dts/p1020rdb-pd.dts

@@ -225,6 +225,18 @@
 			};
 		};
 
+		ptp_clock@b0e00 {
+			compatible = "fsl,etsec-ptp";
+			reg = <0xb0e00 0xb0>;
+			interrupts = <68 2 0 0 69 2 0 0>;
+			fsl,tclk-period	= <10>;
+			fsl,tmr-prsc	= <2>;
+			fsl,tmr-add	= <2147483670>;
+			fsl,tmr-fiper1	= <999999990>;
+			fsl,tmr-fiper2	= <99990>;
+			fsl,max-adj	= <199999999>;
+		};
+
 		enet0: ethernet@b0000 {
 			fixed-link = <1 1 1000 0 0>;
 			phy-connection-type = "rgmii-id";

diff --git a/arch/powerpc/boot/dts/p1021rdb-pc.dtsi b/arch/powerpc/boot/dts/p1021rdb-pc.dtsi
index d6274c5..a29c84a 100644
--- a/arch/powerpc/boot/dts/p1021rdb-pc.dtsi
+++ b/arch/powerpc/boot/dts/p1021rdb-pc.dtsi

@@ -224,6 +224,18 @@
 		};
 	};
 
+	ptp_clock@b0e00 {
+		compatible = "fsl,etsec-ptp";
+		reg = <0xb0e00 0xb0>;
+		interrupts = <68 2 0 0 69 2 0 0>;
+		fsl,tclk-period	= <10>;
+		fsl,tmr-prsc	= <2>;
+		fsl,tmr-add	= <2147483670>;
+		fsl,tmr-fiper1	= <999999990>;
+		fsl,tmr-fiper2	= <99990>;
+		fsl,max-adj	= <199999999>;
+	};
+
 	enet0: ethernet@b0000 {
 		fixed-link = <1 1 1000 0 0>;
 		phy-connection-type = "rgmii-id";

diff --git a/arch/powerpc/boot/dts/p1022ds.dtsi b/arch/powerpc/boot/dts/p1022ds.dtsi
index 957e0dc..50f915f 100644
--- a/arch/powerpc/boot/dts/p1022ds.dtsi
+++ b/arch/powerpc/boot/dts/p1022ds.dtsi

@@ -215,6 +215,18 @@
 		};
 	};
 
+	ptp_clock@b0e00 {
+		compatible = "fsl,etsec-ptp";
+		reg = <0xb0e00 0xb0>;
+		interrupts = <68 2 0 0 69 2 0 0>;
+		fsl,tclk-period	= <5>;
+		fsl,tmr-prsc	= <2>;
+		fsl,tmr-add	= <3223239997>;
+		fsl,tmr-fiper1	= <999999995>;
+		fsl,tmr-fiper2	= <99990>;
+		fsl,max-adj	= <266499999>;
+	};
+
 	ethernet@b0000 {
 		phy-handle = <&phy0>;
 		phy-connection-type = "rgmii-id";

diff --git a/arch/powerpc/boot/dts/p1025twr.dtsi b/arch/powerpc/boot/dts/p1025twr.dtsi
index 8453501..52a6c7e 100644
--- a/arch/powerpc/boot/dts/p1025twr.dtsi
+++ b/arch/powerpc/boot/dts/p1025twr.dtsi

@@ -138,6 +138,18 @@
 		};
 	};
 
+	ptp_clock@b0e00 {
+		compatible = "fsl,etsec-ptp";
+		reg = <0xb0e00 0xb0>;
+		interrupts = <68 2 0 0 69 2 0 0>;
+		fsl,tclk-period	= <10>;
+		fsl,tmr-prsc	= <2>;
+		fsl,tmr-add	= <3221225505>;
+		fsl,tmr-fiper1	= <999999990>;
+		fsl,tmr-fiper2	= <99990>;
+		fsl,max-adj	= <133333332>;
+	};
+
 	enet0: ethernet@b0000 {
 		phy-handle = <&phy0>;
 		phy-connection-type = "rgmii-id";

diff --git a/arch/powerpc/boot/dts/p2020rdb-pc.dtsi b/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
index c21d1c7..363172d 100644
--- a/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
+++ b/arch/powerpc/boot/dts/p2020rdb-pc.dtsi

@@ -215,12 +215,12 @@
 	};
 
 	ptp_clock@24e00 {
-		fsl,tclk-period = <5>;
-		fsl,tmr-prsc = <200>;
-		fsl,tmr-add = <0xCCCCCCCD>;
-		fsl,tmr-fiper1 = <0x3B9AC9FB>;
-		fsl,tmr-fiper2 = <0x0001869B>;
-		fsl,max-adj = <249999999>;
+		fsl,tclk-period	= <5>;
+		fsl,tmr-prsc	= <2>;
+		fsl,tmr-add	= <2863311531>;
+		fsl,tmr-fiper1	= <999999995>;
+		fsl,tmr-fiper2	= <99990>;
+		fsl,max-adj	= <299999999>;
 	};
 
 	enet0: ethernet@24000 {

-- 
2.1.0.27.g96db324

RE: [PATCH v2] powerpc/dts: Add and fix 1588 timer node for eTSEC

From: Lu Y.B. <hidden>
Date: 2015-07-16 02:53:56

Any comments?
Thanks.

quoted hunk

-----Original Message-----
From: Yangbo Lu [mailto:yangbo.lu@freescale.com]
Sent: Thursday, May 07, 2015 11:29 AM
To: linuxppc-dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; Wood
Scott-B07421
Cc: Lu Yangbo-B47093
Subject: [PATCH v2] powerpc/dts: Add and fix 1588 timer node for eTSEC
=20
Add 1588 timer node in files:
arch/powerpc/boot/dts/bsc9131rdb.dtsi
arch/powerpc/boot/dts/bsc9132qds.dtsi
arch/powerpc/boot/dts/p1010rdb.dtsi
arch/powerpc/boot/dts/p1020rdb-pd.dts
arch/powerpc/boot/dts/p1021rdb-pc.dtsi
arch/powerpc/boot/dts/p1022ds.dtsi
arch/powerpc/boot/dts/p1025twr.dtsi
Fix 1588 timer node in file:
arch/powerpc/boot/dts/p2020rdb-pc.dtsi
=20
Signed-off-by: Yangbo Lu <redacted>
---
Changes for v2:
	- Changed hex value to decimal value in dts
	- Modified commit message
	- Modified 1588 node in p2020rdb-pc.dtsi
---
 arch/powerpc/boot/dts/bsc9131rdb.dtsi  | 12 ++++++++++++
arch/powerpc/boot/dts/bsc9132qds.dtsi  | 12 ++++++++++++
 arch/powerpc/boot/dts/p1010rdb.dtsi    | 12 ++++++++++++
 arch/powerpc/boot/dts/p1020rdb-pd.dts  | 12 ++++++++++++
arch/powerpc/boot/dts/p1021rdb-pc.dtsi | 12 ++++++++++++
 arch/powerpc/boot/dts/p1022ds.dtsi     | 12 ++++++++++++
 arch/powerpc/boot/dts/p1025twr.dtsi    | 12 ++++++++++++
 arch/powerpc/boot/dts/p2020rdb-pc.dtsi | 12 ++++++------
 8 files changed, 90 insertions(+), 6 deletions(-)
=20

diff --git a/arch/powerpc/boot/dts/bsc9131rdb.dtsi

b/arch/powerpc/boot/dts/bsc9131rdb.dtsi
index 45efcba..a6d533e 100644

--- a/arch/powerpc/boot/dts/bsc9131rdb.dtsi
+++ b/arch/powerpc/boot/dts/bsc9131rdb.dtsi

@@ -80,6 +80,18 @@
 		status =3D "disabled";
 	};

=20
+	ptp_clock@b0e00 {
+		compatible =3D "fsl,etsec-ptp";
+		reg =3D <0xb0e00 0xb0>;
+		interrupts =3D <68 2 0 0 69 2 0 0>;
+		fsl,tclk-period	=3D <5>;
+		fsl,tmr-prsc	=3D <2>;
+		fsl,tmr-add	=3D <3435973837>;
+		fsl,tmr-fiper1	=3D <999999995>;
+		fsl,tmr-fiper2	=3D <99990>;
+		fsl,max-adj	=3D <249999999>;
+	};
+
 	enet0: ethernet@b0000 {
 		phy-handle =3D <&phy0>;
 		phy-connection-type =3D "rgmii-id";

diff --git a/arch/powerpc/boot/dts/bsc9132qds.dtsi

b/arch/powerpc/boot/dts/bsc9132qds.dtsi
index af8e888..ef75804 100644

--- a/arch/powerpc/boot/dts/bsc9132qds.dtsi
+++ b/arch/powerpc/boot/dts/bsc9132qds.dtsi

@@ -87,6 +87,18 @@
 		};
 	};

=20
+	ptp_clock@b0e00 {
+		compatible =3D "fsl,etsec-ptp";
+		reg =3D <0xb0e00 0xb0>;
+		interrupts =3D <68 2 0 0 69 2 0 0>;
+		fsl,tclk-period	=3D <5>;
+		fsl,tmr-prsc	=3D <2>;
+		fsl,tmr-add	=3D <3435973837>;
+		fsl,tmr-fiper1	=3D <999999995>;
+		fsl,tmr-fiper2	=3D <99990>;
+		fsl,max-adj	=3D <249999999>;
+	};
+
 	enet0: ethernet@b0000 {
 		phy-handle =3D <&phy0>;
 		tbi-handle =3D <&tbi0>;

diff --git a/arch/powerpc/boot/dts/p1010rdb.dtsi

b/arch/powerpc/boot/dts/p1010rdb.dtsi
index ea534ef..1613678 100644

--- a/arch/powerpc/boot/dts/p1010rdb.dtsi
+++ b/arch/powerpc/boot/dts/p1010rdb.dtsi

@@ -186,6 +186,18 @@
 		};
 	};

=20
+	ptp_clock@b0e00 {
+		compatible =3D "fsl,etsec-ptp";
+		reg =3D <0xb0e00 0xb0>;
+		interrupts =3D <68 2 0 0 69 2 0 0>;
+		fsl,tclk-period	=3D <10>;
+		fsl,tmr-prsc	=3D <2>;
+		fsl,tmr-add	=3D <2147483670>;
+		fsl,tmr-fiper1	=3D <999999990>;
+		fsl,tmr-fiper2	=3D <99990>;
+		fsl,max-adj	=3D <199999999>;
+	};
+
 	enet0: ethernet@b0000 {
 		phy-handle =3D <&phy0>;
 		phy-connection-type =3D "rgmii-id";

diff --git a/arch/powerpc/boot/dts/p1020rdb-pd.dts

b/arch/powerpc/boot/dts/p1020rdb-pd.dts
index 987017e..52e8fe8 100644

--- a/arch/powerpc/boot/dts/p1020rdb-pd.dts
+++ b/arch/powerpc/boot/dts/p1020rdb-pd.dts

@@ -225,6 +225,18 @@
 			};
 		};

=20
+		ptp_clock@b0e00 {
+			compatible =3D "fsl,etsec-ptp";
+			reg =3D <0xb0e00 0xb0>;
+			interrupts =3D <68 2 0 0 69 2 0 0>;
+			fsl,tclk-period	=3D <10>;
+			fsl,tmr-prsc	=3D <2>;
+			fsl,tmr-add	=3D <2147483670>;
+			fsl,tmr-fiper1	=3D <999999990>;
+			fsl,tmr-fiper2	=3D <99990>;
+			fsl,max-adj	=3D <199999999>;
+		};
+
 		enet0: ethernet@b0000 {
 			fixed-link =3D <1 1 1000 0 0>;
 			phy-connection-type =3D "rgmii-id";

diff --git a/arch/powerpc/boot/dts/p1021rdb-pc.dtsi

b/arch/powerpc/boot/dts/p1021rdb-pc.dtsi
index d6274c5..a29c84a 100644

--- a/arch/powerpc/boot/dts/p1021rdb-pc.dtsi
+++ b/arch/powerpc/boot/dts/p1021rdb-pc.dtsi

@@ -224,6 +224,18 @@
 		};
 	};

=20
+	ptp_clock@b0e00 {
+		compatible =3D "fsl,etsec-ptp";
+		reg =3D <0xb0e00 0xb0>;
+		interrupts =3D <68 2 0 0 69 2 0 0>;
+		fsl,tclk-period	=3D <10>;
+		fsl,tmr-prsc	=3D <2>;
+		fsl,tmr-add	=3D <2147483670>;
+		fsl,tmr-fiper1	=3D <999999990>;
+		fsl,tmr-fiper2	=3D <99990>;
+		fsl,max-adj	=3D <199999999>;
+	};
+
 	enet0: ethernet@b0000 {
 		fixed-link =3D <1 1 1000 0 0>;
 		phy-connection-type =3D "rgmii-id";

diff --git a/arch/powerpc/boot/dts/p1022ds.dtsi

b/arch/powerpc/boot/dts/p1022ds.dtsi
index 957e0dc..50f915f 100644

--- a/arch/powerpc/boot/dts/p1022ds.dtsi
+++ b/arch/powerpc/boot/dts/p1022ds.dtsi

@@ -215,6 +215,18 @@
 		};
 	};

=20
+	ptp_clock@b0e00 {
+		compatible =3D "fsl,etsec-ptp";
+		reg =3D <0xb0e00 0xb0>;
+		interrupts =3D <68 2 0 0 69 2 0 0>;
+		fsl,tclk-period	=3D <5>;
+		fsl,tmr-prsc	=3D <2>;
+		fsl,tmr-add	=3D <3223239997>;
+		fsl,tmr-fiper1	=3D <999999995>;
+		fsl,tmr-fiper2	=3D <99990>;
+		fsl,max-adj	=3D <266499999>;
+	};
+
 	ethernet@b0000 {
 		phy-handle =3D <&phy0>;
 		phy-connection-type =3D "rgmii-id";

diff --git a/arch/powerpc/boot/dts/p1025twr.dtsi

b/arch/powerpc/boot/dts/p1025twr.dtsi
index 8453501..52a6c7e 100644

--- a/arch/powerpc/boot/dts/p1025twr.dtsi
+++ b/arch/powerpc/boot/dts/p1025twr.dtsi

@@ -138,6 +138,18 @@
 		};
 	};

=20
+	ptp_clock@b0e00 {
+		compatible =3D "fsl,etsec-ptp";
+		reg =3D <0xb0e00 0xb0>;
+		interrupts =3D <68 2 0 0 69 2 0 0>;
+		fsl,tclk-period	=3D <10>;
+		fsl,tmr-prsc	=3D <2>;
+		fsl,tmr-add	=3D <3221225505>;
+		fsl,tmr-fiper1	=3D <999999990>;
+		fsl,tmr-fiper2	=3D <99990>;
+		fsl,max-adj	=3D <133333332>;
+	};
+
 	enet0: ethernet@b0000 {
 		phy-handle =3D <&phy0>;
 		phy-connection-type =3D "rgmii-id";

diff --git a/arch/powerpc/boot/dts/p2020rdb-pc.dtsi

b/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
index c21d1c7..363172d 100644

--- a/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
+++ b/arch/powerpc/boot/dts/p2020rdb-pc.dtsi

@@ -215,12 +215,12 @@
 	};

=20
 	ptp_clock@24e00 {
-		fsl,tclk-period =3D <5>;
-		fsl,tmr-prsc =3D <200>;
-		fsl,tmr-add =3D <0xCCCCCCCD>;
-		fsl,tmr-fiper1 =3D <0x3B9AC9FB>;
-		fsl,tmr-fiper2 =3D <0x0001869B>;
-		fsl,max-adj =3D <249999999>;
+		fsl,tclk-period	=3D <5>;
+		fsl,tmr-prsc	=3D <2>;
+		fsl,tmr-add	=3D <2863311531>;
+		fsl,tmr-fiper1	=3D <999999995>;
+		fsl,tmr-fiper2	=3D <99990>;
+		fsl,max-adj	=3D <299999999>;
 	};
=20
 	enet0: ethernet@24000 {
--
2.1.0.27.g96db324

Re: [PATCH v2] powerpc/dts: Add and fix 1588 timer node for eTSEC

From: Scott Wood <hidden>
Date: 2015-07-16 20:53:59

On Wed, 2015-07-15 at 21:37 -0500, Lu Yangbo-B47093 wrote:

Any comments?
Thanks.

Sorry, I must have missed this on my last time through the patch queue.  I 
see you've decimalized the fiper and max-adj properties, which is good... but 
does it really make sense for tmr-add?  I'm not familiar with what this value 
represents, but the numbers look more natural as hex (e.g. 0xaaaaaaab versus 
2863311531).

quoted

diff --git a/arch/powerpc/boot/dts/p2020rdb-pc.dtsi

b/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
index c21d1c7..363172d 100644

--- a/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
+++ b/arch/powerpc/boot/dts/p2020rdb-pc.dtsi

@@ -215,12 +215,12 @@
    };

     ptp_clock@24e00{
-           fsl,tclk-period = <5>;
-           fsl,tmr-prsc = <200>;
-           fsl,tmr-add = <0xCCCCCCCD>;
-           fsl,tmr-fiper1 = <0x3B9AC9FB>;
-           fsl,tmr-fiper2 = <0x0001869B>;
-           fsl,max-adj = <249999999>;
+           fsl,tclk-period = <5>;
+           fsl,tmr-prsc    = <2>;
+           fsl,tmr-add     = <2863311531>;
+           fsl,tmr-fiper1  = <999999995>;
+           fsl,tmr-fiper2  = <99990>;
+           fsl,max-adj     = <299999999>;
    };

And here, you're changing the value of fsl,tmr-add and fsl,max-adj.  Why?

-Scott

RE: [PATCH v2] powerpc/dts: Add and fix 1588 timer node for eTSEC

From: Lu Y.B. <hidden>
Date: 2015-07-20 06:33:55

PiBPbiBXZWQsIDIwMTUtMDctMTUgYXQgMjE6MzcgLTA1MDAsIEx1IFlhbmdiby1CNDcwOTMgd3Jv
dGU6DQo+ID4gQW55IGNvbW1lbnRzPw0KPiA+IFRoYW5rcy4NCj4gDQo+IFNvcnJ5LCBJIG11c3Qg
aGF2ZSBtaXNzZWQgdGhpcyBvbiBteSBsYXN0IHRpbWUgdGhyb3VnaCB0aGUgcGF0Y2ggcXVldWUu
DQo+IEkgc2VlIHlvdSd2ZSBkZWNpbWFsaXplZCB0aGUgZmlwZXIgYW5kIG1heC1hZGogcHJvcGVy
dGllcywgd2hpY2ggaXMNCj4gZ29vZC4uLiBidXQgZG9lcyBpdCByZWFsbHkgbWFrZSBzZW5zZSBm
b3IgdG1yLWFkZD8gIEknbSBub3QgZmFtaWxpYXIgd2l0aA0KPiB3aGF0IHRoaXMgdmFsdWUgcmVw
cmVzZW50cywgYnV0IHRoZSBudW1iZXJzIGxvb2sgbW9yZSBuYXR1cmFsIGFzIGhleCAoZS5nLg0K
PiAweGFhYWFhYWFiIHZlcnN1cyAyODYzMzExNTMxKS4NCg0KWWVzLCB0aGUgZmlwZXIgdmFsdWUg
d291bGQgYmUgd3JpdGVkIGludG8gZmlwZXIgcmVnaXN0ZXJzLiBBbmQgbWF4LWFkaiB2YWx1ZSB3
b3VsZCBiZSB1c2VkIGluIHB0cCBkcml2ZXIgaW4gZHJpdmVyL3B0cC8uDQpCdXQgeW91IGluc2lz
dGVkIHRoYXQgdmFsdWVzIHNob3VsZCBiZSBpbiBkZWNpbWFsaXNtIGluIHRoZSB2MSBwYXRjaC4u
LiA6KQ0KDQpTZWUgdGhlIGhpc3RvcnkgOikNCg0KIyMjIyMjIyMjIyMjIyMjIyMgaGlzdG9yeSAj
IyMjIyMjIyMjIyMjIyMjIyMNCj4gPiArCXB0cF9jbG9ja0BiMGUwMCB7DQo+ID4gKwkJY29tcGF0
aWJsZSA9ICJmc2wsZXRzZWMtcHRwIjsNCj4gPiArCQlyZWcgPSA8MHhiMGUwMCAweGIwPjsNCj4g
PiArCQlpbnRlcnJ1cHRzID0gPDY4IDIgMCAwIDY5IDIgMCAwPjsNCj4gPiArCQlmc2wsdGNsay1w
ZXJpb2QJPSA8NT47DQo+ID4gKwkJZnNsLHRtci1wcnNjCT0gPDI+Ow0KPiA+ICsJCWZzbCx0bXIt
YWRkCT0gPDB4Y2NjY2NjY2Q+Ow0KPiA+ICsJCWZzbCx0bXItZmlwZXIxCT0gPDB4M2I5YWM5ZmI+
Ow0KPiA+ICsJCWZzbCx0bXItZmlwZXIyCT0gPDB4MDAwMTg2OTY+Ow0KPiA+ICsJCWZzbCxtYXgt
YWRqCT0gPDI0OTk5OTk5OT47DQo+IA0KPiBQbGVhc2UgZG9uJ3QgdXNlIGhleCBmb3IgbnVtYmVy
cyB0aGF0IG1ha2UgbW9yZSBzZW5zZSBhcyBkZWNpbWFsLg0KPiBbTHUgWWFuZ2JvLUI0NzA5M10g
VGhlIGhleCB2YWx1ZSBpcyByZWdpc3RlciB2YWx1ZSwgSSB0aGluayBpdCdzIGJldHRlciB0byB1
c2UgaGV4Lg0KDQpXaGV0aGVyIGl0IGdvZXMgaW50byBhIHJlZ2lzdGVyIGRvZXNuJ3QgbWF0dGVy
LiAgSGV4IHZhbHVlcyBhcmUgdXNlZnVsIGZvciB2YWx1ZXMgd2hpY2ggYXJlIHN1YmRpdmlkZWQg
aW50byB2YXJpb3VzIGJpdGZpZWxkcywgb3Igd2hvc2UgaGV4IHJlcHJlc2VudGF0aW9uIGlzIHNp
bXBsZXIgdGhhbiBkZWNpbWFsLiAgSSdtIG5vdCBmYW1pbGlhciB3aXRoIHRoZSBkZXRhaWxzIG9m
IHRoaXMgaGFyZHdhcmUsIGJ1dCBJIGRvdWJ0IHRoZSBmb3JtZXIgaXMgdGhlIGNhc2UgZm9yIDB4
M2I5YWM5ZmIgPT0gOTk5OTk5OTk5NSBvciAweDE4Njk2ID09IDk5OTkwLg0KDQotU2NvdHQNCiMj
IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjDQoNCg0KPiANCj4gPiA+IGRpZmYg
LS1naXQgYS9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvcDIwMjByZGItcGMuZHRzaQ0KPiA+ID4gYi9h
cmNoL3Bvd2VycGMvYm9vdC9kdHMvcDIwMjByZGItcGMuZHRzaQ0KPiA+ID4gaW5kZXggYzIxZDFj
Ny4uMzYzMTcyZCAxMDA2NDQNCj4gPiA+IC0tLSBhL2FyY2gvcG93ZXJwYy9ib290L2R0cy9wMjAy
MHJkYi1wYy5kdHNpDQo+ID4gPiArKysgYi9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvcDIwMjByZGIt
cGMuZHRzaQ0KPiA+ID4gQEAgLTIxNSwxMiArMjE1LDEyIEBADQo+ID4gPiAgICAgfTsNCj4gPiA+
DQo+ID4gPiAgICAgIHB0cF9jbG9ja0AyNGUwMHsNCj4gPiA+IC0gICAgICAgICAgIGZzbCx0Y2xr
LXBlcmlvZCA9IDw1PjsNCj4gPiA+IC0gICAgICAgICAgIGZzbCx0bXItcHJzYyA9IDwyMDA+Ow0K
PiA+ID4gLSAgICAgICAgICAgZnNsLHRtci1hZGQgPSA8MHhDQ0NDQ0NDRD47DQo+ID4gPiAtICAg
ICAgICAgICBmc2wsdG1yLWZpcGVyMSA9IDwweDNCOUFDOUZCPjsNCj4gPiA+IC0gICAgICAgICAg
IGZzbCx0bXItZmlwZXIyID0gPDB4MDAwMTg2OUI+Ow0KPiA+ID4gLSAgICAgICAgICAgZnNsLG1h
eC1hZGogPSA8MjQ5OTk5OTk5PjsNCj4gPiA+ICsgICAgICAgICAgIGZzbCx0Y2xrLXBlcmlvZCA9
IDw1PjsNCj4gPiA+ICsgICAgICAgICAgIGZzbCx0bXItcHJzYyAgICA9IDwyPjsNCj4gPiA+ICsg
ICAgICAgICAgIGZzbCx0bXItYWRkICAgICA9IDwyODYzMzExNTMxPjsNCj4gPiA+ICsgICAgICAg
ICAgIGZzbCx0bXItZmlwZXIxICA9IDw5OTk5OTk5OTU+Ow0KPiA+ID4gKyAgICAgICAgICAgZnNs
LHRtci1maXBlcjIgID0gPDk5OTkwPjsNCj4gPiA+ICsgICAgICAgICAgIGZzbCxtYXgtYWRqICAg
ICA9IDwyOTk5OTk5OTk+Ow0KPiA+ID4gICAgIH07DQo+IA0KPiBBbmQgaGVyZSwgeW91J3JlIGNo
YW5naW5nIHRoZSB2YWx1ZSBvZiBmc2wsdG1yLWFkZCBhbmQgZnNsLG1heC1hZGouICBXaHk/DQoN
ClRoZSBvbGQgdmFsdWVzIG1heWJlIG5vdCBjYWxjdWxhdGVkIGJhc2Ugb24gdGhlIGRlZmF1bHQg
ZVRTRUMgc3lzdGVtIGNsb2NrIHZhbHVlLg0KMTU4OCB0aW1lciBjb3VsZG7igJl0IGJlIGFkanVz
dGVkIGNvcnJlY3RseSBieSBvbGQgdmFsdWVzLg0KDQo+IA0KPiAtU2NvdHQNCg0K

Re: [PATCH v2] powerpc/dts: Add and fix 1588 timer node for eTSEC

From: Scott Wood <hidden>
Date: 2015-07-24 15:07:53

On Mon, 2015-07-20 at 01:33 -0500, Lu Yangbo-B47093 wrote:

quoted

On Wed, 2015-07-15 at 21:37 -0500, Lu Yangbo-B47093 wrote:

quoted

Any comments?
Thanks.

Sorry, I must have missed this on my last time through the patch queue.
I see you've decimalized the fiper and max-adj properties, which is
good... but does it really make sense for tmr-add?  I'm not familiar with
what this value represents, but the numbers look more natural as hex (e.g.
0xaaaaaaab versus 2863311531).

Yes, the fiper value would be writed into fiper registers. And max-adj 
value would be used in ptp driver in driver/ptp/.
But you insisted that values should be in decimalism in the v1 patch... :)

See the history :)

I didn't insist on decimals for *everything*, just where it makes sense, and 
that "it goes in a register" doesn't *automatically* mean that it doesn't 
make sense.

################# history ##################

quoted

+  ptp_clock@b0e00{
+         compatible = "fsl,etsec-ptp";
+         reg = <0xb0e00 0xb0>;
+         interrupts = <68 2 0 0 69 2 0 0>;
+         fsl,tclk-period = <5>;
+         fsl,tmr-prsc    = <2>;
+         fsl,tmr-add     = <0xcccccccd>;
+         fsl,tmr-fiper1  = <0x3b9ac9fb>;
+         fsl,tmr-fiper2  = <0x00018696>;
+         fsl,max-adj     = <249999999>;

Please don't use hex for numbers that make more sense as decimal.
[Lu Yangbo-B47093] The hex value is register value, I think it's better 
to use hex.

Whether it goes into a register doesn't matter.  Hex values are useful for 
values which are subdivided into various bitfields, or whose hex 
representation is simpler than decimal.  I'm not familiar with the details 
of this hardware, but I doubt the former is the case for 0x3b9ac9fb == 
9999999995 or 0x18696 == 99990.

-Scott
######################################

quoted

diff --git a/arch/powerpc/boot/dts/p2020rdb-pc.dtsi

b/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
index c21d1c7..363172d 100644

--- a/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
+++ b/arch/powerpc/boot/dts/p2020rdb-pc.dtsi

@@ -215,12 +215,12 @@
    };

     ptp_clock@24e00{
-           fsl,tclk-period = <5>;
-           fsl,tmr-prsc = <200>;
-           fsl,tmr-add = <0xCCCCCCCD>;
-           fsl,tmr-fiper1 = <0x3B9AC9FB>;
-           fsl,tmr-fiper2 = <0x0001869B>;
-           fsl,max-adj = <249999999>;
+           fsl,tclk-period = <5>;
+           fsl,tmr-prsc    = <2>;
+           fsl,tmr-add     = <2863311531>;
+           fsl,tmr-fiper1  = <999999995>;
+           fsl,tmr-fiper2  = <99990>;
+           fsl,max-adj     = <299999999>;
    };

And here, you're changing the value of fsl,tmr-add and fsl,max-adj.  Why?

The old values maybe not calculated base on the default eTSEC system clock 
value.
1588 timer couldn’t be adjusted correctly by old values.

Explain in the changelog what was wrong with the old values (don't just say 
"Fix 1588 timer node in file").

-Scott

RE: [PATCH v2] powerpc/dts: Add and fix 1588 timer node for eTSEC

From: Lu Y.B. <hidden>
Date: 2015-07-29 07:37:14

SGkgU2NvdHQsDQoNCkkgc3VibWl0dGVkIGEgdjMgcGF0Y2ggZm9yIHRoaXMuDQpTb3JyeSBmb3Ig
bXkgbWlzdW5kZXJzdGFuZGluZyBhbmQgdGhhbmsgYSBsb3QuDQoNCg0KDQpCZXN0IHJlZ2FyZHMs
DQpZYW5nYm8gTHUNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBXb29k
IFNjb3R0LUIwNzQyMQ0KPiBTZW50OiBGcmlkYXksIEp1bHkgMjQsIDIwMTUgMTE6MDggUE0NCj4g
VG86IEx1IFlhbmdiby1CNDcwOTMNCj4gQ2M6IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3Jn
OyBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjJd
IHBvd2VycGMvZHRzOiBBZGQgYW5kIGZpeCAxNTg4IHRpbWVyIG5vZGUgZm9yDQo+IGVUU0VDDQo+
IA0KPiBPbiBNb24sIDIwMTUtMDctMjAgYXQgMDE6MzMgLTA1MDAsIEx1IFlhbmdiby1CNDcwOTMg
d3JvdGU6DQo+ID4gPiBPbiBXZWQsIDIwMTUtMDctMTUgYXQgMjE6MzcgLTA1MDAsIEx1IFlhbmdi
by1CNDcwOTMgd3JvdGU6DQo+ID4gPiA+IEFueSBjb21tZW50cz8NCj4gPiA+ID4gVGhhbmtzLg0K
PiA+ID4NCj4gPiA+IFNvcnJ5LCBJIG11c3QgaGF2ZSBtaXNzZWQgdGhpcyBvbiBteSBsYXN0IHRp
bWUgdGhyb3VnaCB0aGUgcGF0Y2gNCj4gcXVldWUuDQo+ID4gPiBJIHNlZSB5b3UndmUgZGVjaW1h
bGl6ZWQgdGhlIGZpcGVyIGFuZCBtYXgtYWRqIHByb3BlcnRpZXMsIHdoaWNoIGlzDQo+ID4gPiBn
b29kLi4uIGJ1dCBkb2VzIGl0IHJlYWxseSBtYWtlIHNlbnNlIGZvciB0bXItYWRkPyAgSSdtIG5v
dCBmYW1pbGlhcg0KPiA+ID4gd2l0aCB3aGF0IHRoaXMgdmFsdWUgcmVwcmVzZW50cywgYnV0IHRo
ZSBudW1iZXJzIGxvb2sgbW9yZSBuYXR1cmFsIGFzDQo+IGhleCAoZS5nLg0KPiA+ID4gMHhhYWFh
YWFhYiB2ZXJzdXMgMjg2MzMxMTUzMSkuDQo+ID4NCj4gPiBZZXMsIHRoZSBmaXBlciB2YWx1ZSB3
b3VsZCBiZSB3cml0ZWQgaW50byBmaXBlciByZWdpc3RlcnMuIEFuZCBtYXgtYWRqDQo+ID4gdmFs
dWUgd291bGQgYmUgdXNlZCBpbiBwdHAgZHJpdmVyIGluIGRyaXZlci9wdHAvLg0KPiA+IEJ1dCB5
b3UgaW5zaXN0ZWQgdGhhdCB2YWx1ZXMgc2hvdWxkIGJlIGluIGRlY2ltYWxpc20gaW4gdGhlIHYx
DQo+ID4gcGF0Y2guLi4gOikNCj4gPg0KPiA+IFNlZSB0aGUgaGlzdG9yeSA6KQ0KPiANCj4gSSBk
aWRuJ3QgaW5zaXN0IG9uIGRlY2ltYWxzIGZvciAqZXZlcnl0aGluZyosIGp1c3Qgd2hlcmUgaXQg
bWFrZXMgc2Vuc2UsDQo+IGFuZCB0aGF0ICJpdCBnb2VzIGluIGEgcmVnaXN0ZXIiIGRvZXNuJ3Qg
KmF1dG9tYXRpY2FsbHkqIG1lYW4gdGhhdCBpdA0KPiBkb2Vzbid0IG1ha2Ugc2Vuc2UuDQo+IA0K
PiAjIyMjIyMjIyMjIyMjIyMjIyBoaXN0b3J5ICMjIyMjIyMjIyMjIyMjIyMjIw0KPiA+ID4gPiAr
ICBwdHBfY2xvY2tAYjBlMDB7DQo+ID4gPiA+ICsgICAgICAgICBjb21wYXRpYmxlID0gImZzbCxl
dHNlYy1wdHAiOw0KPiA+ID4gPiArICAgICAgICAgcmVnID0gPDB4YjBlMDAgMHhiMD47DQo+ID4g
PiA+ICsgICAgICAgICBpbnRlcnJ1cHRzID0gPDY4IDIgMCAwIDY5IDIgMCAwPjsNCj4gPiA+ID4g
KyAgICAgICAgIGZzbCx0Y2xrLXBlcmlvZCA9IDw1PjsNCj4gPiA+ID4gKyAgICAgICAgIGZzbCx0
bXItcHJzYyAgICA9IDwyPjsNCj4gPiA+ID4gKyAgICAgICAgIGZzbCx0bXItYWRkICAgICA9IDww
eGNjY2NjY2NkPjsNCj4gPiA+ID4gKyAgICAgICAgIGZzbCx0bXItZmlwZXIxICA9IDwweDNiOWFj
OWZiPjsNCj4gPiA+ID4gKyAgICAgICAgIGZzbCx0bXItZmlwZXIyICA9IDwweDAwMDE4Njk2PjsN
Cj4gPiA+ID4gKyAgICAgICAgIGZzbCxtYXgtYWRqICAgICA9IDwyNDk5OTk5OTk+Ow0KPiA+ID4N
Cj4gPiA+IFBsZWFzZSBkb24ndCB1c2UgaGV4IGZvciBudW1iZXJzIHRoYXQgbWFrZSBtb3JlIHNl
bnNlIGFzIGRlY2ltYWwuDQo+ID4gPiBbTHUgWWFuZ2JvLUI0NzA5M10gVGhlIGhleCB2YWx1ZSBp
cyByZWdpc3RlciB2YWx1ZSwgSSB0aGluayBpdCdzDQo+ID4gPiBiZXR0ZXIgdG8gdXNlIGhleC4N
Cj4gPg0KPiA+IFdoZXRoZXIgaXQgZ29lcyBpbnRvIGEgcmVnaXN0ZXIgZG9lc24ndCBtYXR0ZXIu
ICBIZXggdmFsdWVzIGFyZSB1c2VmdWwNCj4gPiBmb3IgdmFsdWVzIHdoaWNoIGFyZSBzdWJkaXZp
ZGVkIGludG8gdmFyaW91cyBiaXRmaWVsZHMsIG9yIHdob3NlIGhleA0KPiA+IHJlcHJlc2VudGF0
aW9uIGlzIHNpbXBsZXIgdGhhbiBkZWNpbWFsLiAgSSdtIG5vdCBmYW1pbGlhciB3aXRoIHRoZQ0K
PiA+IGRldGFpbHMgb2YgdGhpcyBoYXJkd2FyZSwgYnV0IEkgZG91YnQgdGhlIGZvcm1lciBpcyB0
aGUgY2FzZSBmb3INCj4gPiAweDNiOWFjOWZiID09DQo+ID4gOTk5OTk5OTk5NSBvciAweDE4Njk2
ID09IDk5OTkwLg0KPiA+DQo+ID4gLVNjb3R0DQo+ID4gIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj
IyMjIyMjIyMjIyMjIyMNCj4gPg0KPiA+DQo+ID4gPg0KPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9h
cmNoL3Bvd2VycGMvYm9vdC9kdHMvcDIwMjByZGItcGMuZHRzaQ0KPiA+ID4gPiA+IGIvYXJjaC9w
b3dlcnBjL2Jvb3QvZHRzL3AyMDIwcmRiLXBjLmR0c2kNCj4gPiA+ID4gPiBpbmRleCBjMjFkMWM3
Li4zNjMxNzJkIDEwMDY0NA0KPiA+ID4gPiA+IC0tLSBhL2FyY2gvcG93ZXJwYy9ib290L2R0cy9w
MjAyMHJkYi1wYy5kdHNpDQo+ID4gPiA+ID4gKysrIGIvYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL3Ay
MDIwcmRiLXBjLmR0c2kNCj4gPiA+ID4gPiBAQCAtMjE1LDEyICsyMTUsMTIgQEANCj4gPiA+ID4g
PiAgICAgfTsNCj4gPiA+ID4gPg0KPiA+ID4gPiA+ICAgICAgcHRwX2Nsb2NrQDI0ZTAwew0KPiA+
ID4gPiA+IC0gICAgICAgICAgIGZzbCx0Y2xrLXBlcmlvZCA9IDw1PjsNCj4gPiA+ID4gPiAtICAg
ICAgICAgICBmc2wsdG1yLXByc2MgPSA8MjAwPjsNCj4gPiA+ID4gPiAtICAgICAgICAgICBmc2ws
dG1yLWFkZCA9IDwweENDQ0NDQ0NEPjsNCj4gPiA+ID4gPiAtICAgICAgICAgICBmc2wsdG1yLWZp
cGVyMSA9IDwweDNCOUFDOUZCPjsNCj4gPiA+ID4gPiAtICAgICAgICAgICBmc2wsdG1yLWZpcGVy
MiA9IDwweDAwMDE4NjlCPjsNCj4gPiA+ID4gPiAtICAgICAgICAgICBmc2wsbWF4LWFkaiA9IDwy
NDk5OTk5OTk+Ow0KPiA+ID4gPiA+ICsgICAgICAgICAgIGZzbCx0Y2xrLXBlcmlvZCA9IDw1PjsN
Cj4gPiA+ID4gPiArICAgICAgICAgICBmc2wsdG1yLXByc2MgICAgPSA8Mj47DQo+ID4gPiA+ID4g
KyAgICAgICAgICAgZnNsLHRtci1hZGQgICAgID0gPDI4NjMzMTE1MzE+Ow0KPiA+ID4gPiA+ICsg
ICAgICAgICAgIGZzbCx0bXItZmlwZXIxICA9IDw5OTk5OTk5OTU+Ow0KPiA+ID4gPiA+ICsgICAg
ICAgICAgIGZzbCx0bXItZmlwZXIyICA9IDw5OTk5MD47DQo+ID4gPiA+ID4gKyAgICAgICAgICAg
ZnNsLG1heC1hZGogICAgID0gPDI5OTk5OTk5OT47DQo+ID4gPiA+ID4gICAgIH07DQo+ID4gPg0K
PiA+ID4gQW5kIGhlcmUsIHlvdSdyZSBjaGFuZ2luZyB0aGUgdmFsdWUgb2YgZnNsLHRtci1hZGQg
YW5kIGZzbCxtYXgtYWRqLg0KPiBXaHk/DQo+ID4NCj4gPiBUaGUgb2xkIHZhbHVlcyBtYXliZSBu
b3QgY2FsY3VsYXRlZCBiYXNlIG9uIHRoZSBkZWZhdWx0IGVUU0VDIHN5c3RlbQ0KPiA+IGNsb2Nr
IHZhbHVlLg0KPiA+IDE1ODggdGltZXIgY291bGRu4oCZdCBiZSBhZGp1c3RlZCBjb3JyZWN0bHkg
Ynkgb2xkIHZhbHVlcy4NCj4gDQo+IEV4cGxhaW4gaW4gdGhlIGNoYW5nZWxvZyB3aGF0IHdhcyB3
cm9uZyB3aXRoIHRoZSBvbGQgdmFsdWVzIChkb24ndCBqdXN0DQo+IHNheSAiRml4IDE1ODggdGlt
ZXIgbm9kZSBpbiBmaWxlIikuDQo+IA0KPiAtU2NvdHQNCg0K

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help