Re: [PATCH] spi: fsl-spi: use of_iomap() to map parameter ram on CPM1
From: Mark Brown <broonie@kernel.org>
Date: 2015-03-18 12:03:26
Also in:
linux-spi, lkml
On Thu, Mar 12, 2015 at 07:52:53AM +0100, leroy christophe wrote:
Le 06/03/2015 12:44, Mark Brown a écrit :
quoted
It's legacy, all that code is really old. Modern code is written in as architecture and firmware neutral a fashion as possible to make things more consistent and maintainable.
This patch is only a small bug fix. That driver already contains calls to of_iomap() and other related of_ functions. Is it worth rewriting the driver for just a small bug fix ?
I don't think you need to fix other usages but I'd rather not introduce new usages of legacy APIs that just need to be fixed up.
Attachments
- signature.asc [application/pgp-signature] 473 bytes