Re: [PATCH 4/4] powerpc/mpic: remove unused functions

If I just get a patch saying "removed unused foo()", I have to go and dig=

 and

find out:
  - was it recently added and will be used soon?
  - is it ancient and never used, if so can we work out why, ie. feature X
    never landed so this code is no longer needed.
  - is it old code that *was* used but isn't now because commit ... remov=

ed the

    last user.
  - is it code that *should* be used, but isn't for some odd reason?


So if you can provide that sort of detail for me, that really adds value =

to the

patch. Otherwise the patch is basically just a TODO for me, to go and wor=

k out

why the code is unused.

Got it. Will resend the whole series one of these days.

Ars=C3=A9ny

cheers

On Fri, 2015-02-20 at 11:40 +0700, Arseny Solokha wrote:

quoted

If I just get a patch saying "removed unused foo()", I have to go and dig and
find out:
  - was it recently added and will be used soon?
  - is it ancient and never used, if so can we work out why, ie. feature X
    never landed so this code is no longer needed.
  - is it old code that *was* used but isn't now because commit ... removed the
    last user.
  - is it code that *should* be used, but isn't for some odd reason?


So if you can provide that sort of detail for me, that really adds value to the
patch. Otherwise the patch is basically just a TODO for me, to go and work out
why the code is unused.

Got it. Will resend the whole series one of these days.

Thanks.

cheers