On Mon, Jan 12, 2015 at 06:03:22PM +1100, Stephen Rothwell wrote:
Hi all,
Changes since 20150109:
The usb-gadget-fixes tree gained a conflict against the usb.current tree.
The net-next tree gained a build failure for which I reverted a commit.
The pinctrl tree gained a build failure so I used the version from
next-20150109.
The akpm tree lost a few patches that turned up elsewhere.
Non-merge commits (relative to Linus' tree): 2202
2272 files changed, 69868 insertions(+), 38441 deletions(-)
Build failures, seen since next-20150109:
m68k:allmodconfig
powerpc:ppc6xx_defconfig
Due to:
ERROR: "__get_user_bad" [drivers/gpu/drm/drm.ko] undefined!
make[1]: *** [__modpost] Error 1
Caused by commit d34f20d6e2f (drm: Atomic modeset ioctl).
Bisect results:
# bad: [39b673bba50275b516543d32ef78767a524b9f26] Add linux-next specific files for 20150109
# good: [b1940cd21c0f4abdce101253e860feff547291b0] Linux 3.19-rc3
git bisect start 'HEAD' 'v3.19-rc3'
# good: [d01312ff089667b0b996228ca165d4a9c124b28f] Merge remote-tracking branch 'net-next/master'
git bisect good d01312ff089667b0b996228ca165d4a9c124b28f
# bad: [b90b3ee4f96067f9eb2edf9e61c9f6356b796232] Merge remote-tracking branch 'device-mapper/for-next'
git bisect bad b90b3ee4f96067f9eb2edf9e61c9f6356b796232
# bad: [d4a32441dd063fd10f41826a69dea2b3f410501a] Merge remote-tracking branch 'drm-intel/for-linux-next'
git bisect bad d4a32441dd063fd10f41826a69dea2b3f410501a
# good: [d01203fd1b8c822adbadb0f0e417a7d344456150] Merge remote-tracking branch 'crypto/master'
git bisect good d01203fd1b8c822adbadb0f0e417a7d344456150
# good: [2be57922d46fdec4360ced2eb108832c5a90bc0e] drm/i915: Fix CRC support for DP port D on CHV
git bisect good 2be57922d46fdec4360ced2eb108832c5a90bc0e
# bad: [4baddea51fe5d73a4f2226e9febc6da21e11bac0] Merge remote-tracking branch 'drm/drm-next'
git bisect bad 4baddea51fe5d73a4f2226e9febc6da21e11bac0
# good: [72a3697097b8dc92f5b8362598f5730a9986eb83] Merge branch 'topic/core-stuff' into topic/atomic-core
git bisect good 72a3697097b8dc92f5b8362598f5730a9986eb83
# bad: [a97df1ccd3c30f16385696964767adf854878021] drm/atomic: Hide drm.ko internal interfaces
git bisect bad a97df1ccd3c30f16385696964767adf854878021
# good: [88a48e297b3a3bac6022c03babfb038f1a886cea] drm: add atomic properties
git bisect good 88a48e297b3a3bac6022c03babfb038f1a886cea
# good: [6b4959f43a04e12d39c5700607727f2cbcfeac31] drm/atomic: atomic plane properties
git bisect good 6b4959f43a04e12d39c5700607727f2cbcfeac31
# bad: [d34f20d6e2f21bd3531b969dc40913181a8ae31a] drm: Atomic modeset ioctl
git bisect bad d34f20d6e2f21bd3531b969dc40913181a8ae31a
# good: [ae16c597b61ae4613b13a0c3fac302e8d8827ac7] drm/atomic: atomic connector properties
git bisect good ae16c597b61ae4613b13a0c3fac302e8d8827ac7
# first bad commit: [d34f20d6e2f21bd3531b969dc40913181a8ae31a] drm: Atomic modeset ioctl
On Mon, Jan 12, 2015 at 5:24 PM, Guenter Roeck [off-list ref] wrote:
On Mon, Jan 12, 2015 at 06:03:22PM +1100, Stephen Rothwell wrote:
quoted
Hi all,
Changes since 20150109:
The usb-gadget-fixes tree gained a conflict against the usb.current tree.
The net-next tree gained a build failure for which I reverted a commit.
The pinctrl tree gained a build failure so I used the version from
next-20150109.
The akpm tree lost a few patches that turned up elsewhere.
Non-merge commits (relative to Linus' tree): 2202
2272 files changed, 69868 insertions(+), 38441 deletions(-)
Build failures, seen since next-20150109:
m68k:allmodconfig
powerpc:ppc6xx_defconfig
Due to:
ERROR: "__get_user_bad" [drivers/gpu/drm/drm.ko] undefined!
make[1]: *** [__modpost] Error 1
Caused by commit d34f20d6e2f (drm: Atomic modeset ioctl).
Yeah, it needs a get_user() that supports 64-bit data.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Mon, Jan 12, 2015 at 05:27:08PM +0100, Geert Uytterhoeven wrote:
On Mon, Jan 12, 2015 at 5:24 PM, Guenter Roeck [off-list ref] wrote:
quoted
On Mon, Jan 12, 2015 at 06:03:22PM +1100, Stephen Rothwell wrote:
quoted
Hi all,
Changes since 20150109:
The usb-gadget-fixes tree gained a conflict against the usb.current tree.
The net-next tree gained a build failure for which I reverted a commit.
The pinctrl tree gained a build failure so I used the version from
next-20150109.
The akpm tree lost a few patches that turned up elsewhere.
Non-merge commits (relative to Linus' tree): 2202
2272 files changed, 69868 insertions(+), 38441 deletions(-)
Build failures, seen since next-20150109:
m68k:allmodconfig
powerpc:ppc6xx_defconfig
Due to:
ERROR: "__get_user_bad" [drivers/gpu/drm/drm.ko] undefined!
make[1]: *** [__modpost] Error 1
Caused by commit d34f20d6e2f (drm: Atomic modeset ioctl).
Yeah, it needs a get_user() that supports 64-bit data.
Hi Geert,
I assume you mean m68k, where 64 bit support for get_user has been disabled.
The problem on powerpc is different though: __get_user_nocheck()
and __get_user_check() use
unsigned long __gu_val;
followed by
__get_user_size(__gu_val, __gu_addr, (size), __gu_err);
__get_user_size() fails in
if (size > sizeof(x))
(x) = __get_user_bad();
Presumably "unsigned long" is 32 bit on 32 bit powerpc, not 64 bit.
Overall, the explicit 64-bit use of get_user() seems to be quite unusual.
Thanks,
Guenter
Due to:
ERROR: "__get_user_bad" [drivers/gpu/drm/drm.ko] undefined!
make[1]: *** [__modpost] Error 1
Caused by commit d34f20d6e2f (drm: Atomic modeset ioctl).
Yeah, it needs a get_user() that supports 64-bit data.
Hi Geert,
I assume you mean m68k, where 64 bit support for get_user has been disabled.
The problem on powerpc is different though: __get_user_nocheck()
and __get_user_check() use
unsigned long __gu_val;
followed by
__get_user_size(__gu_val, __gu_addr, (size), __gu_err);
__get_user_size() fails in
if (size > sizeof(x))
(x) = __get_user_bad();
Presumably "unsigned long" is 32 bit on 32 bit powerpc, not 64 bit.
Overall, the explicit 64-bit use of get_user() seems to be quite unusual.
I noticed you've sent a fix for DRM.
Doh, and I was just fixing m68k...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Due to:
ERROR: "__get_user_bad" [drivers/gpu/drm/drm.ko] undefined!
make[1]: *** [__modpost] Error 1
Caused by commit d34f20d6e2f (drm: Atomic modeset ioctl).
Yeah, it needs a get_user() that supports 64-bit data.
Hi Geert,
I assume you mean m68k, where 64 bit support for get_user has been disabled.
The problem on powerpc is different though: __get_user_nocheck()
and __get_user_check() use
unsigned long __gu_val;
followed by
__get_user_size(__gu_val, __gu_addr, (size), __gu_err);
__get_user_size() fails in
if (size > sizeof(x))
(x) = __get_user_bad();
Presumably "unsigned long" is 32 bit on 32 bit powerpc, not 64 bit.
Overall, the explicit 64-bit use of get_user() seems to be quite unusual.
I noticed you've sent a fix for DRM.
Doh, and I was just fixing m68k...