[PATCH] arch: powerpc: kvm: book3s_paired_singles.c: Remove unused function

Subsystems: kernel virtual machine for powerpc (kvm/powerpc), linux for powerpc (32-bit and 64-bit), the rest

STALE4252d

2 messages, 2 authors, 2014-12-17 · open the first message on its own page

[PATCH] arch: powerpc: kvm: book3s_paired_singles.c: Remove unused function

From: Rickard Strandqvist <hidden>
Date: 2014-12-07 22:26:38

Remove the function inst_set_field() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <redacted>
---
 arch/powerpc/kvm/book3s_paired_singles.c |    8 --------
 1 file changed, 8 deletions(-)
diff --git a/arch/powerpc/kvm/book3s_paired_singles.c b/arch/powerpc/kvm/book3s_paired_singles.c
index bfb8035..bd6ab16 100644
--- a/arch/powerpc/kvm/book3s_paired_singles.c
+++ b/arch/powerpc/kvm/book3s_paired_singles.c
@@ -352,14 +352,6 @@ static inline u32 inst_get_field(u32 inst, int msb, int lsb)
 	return kvmppc_get_field(inst, msb + 32, lsb + 32);
 }
 
-/*
- * Replaces inst bits with ordering according to spec.
- */
-static inline u32 inst_set_field(u32 inst, int msb, int lsb, int value)
-{
-	return kvmppc_set_field(inst, msb + 32, lsb + 32, value);
-}
-
 bool kvmppc_inst_is_paired_single(struct kvm_vcpu *vcpu, u32 inst)
 {
 	if (!(vcpu->arch.hflags & BOOK3S_HFLAG_PAIRED_SINGLE))
-- 
1.7.10.4

Re: [PATCH] arch: powerpc: kvm: book3s_paired_singles.c: Remove unused function

From: Alexander Graf <hidden>
Date: 2014-12-17 12:13:53


On 07.12.14 23:29, Rickard Strandqvist wrote:
Remove the function inst_set_field() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <redacted>
Thanks, applied all unused function patches in KVM PPC code to
kvm-ppc-queue.


Alex
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help