[PATCH] cpuidle/powernv: Re-enable fastsleep at boot time

Subsystems: cpu idle time management framework, the rest

STALE4352d

3 messages, 2 authors, 2014-11-19 · open the first message on its own page

[PATCH] cpuidle/powernv: Re-enable fastsleep at boot time

From: Preeti U Murthy <hidden>
Date: 2014-11-18 06:56:24

Commit dcb18694 "Fix ipi on palmeto" disabled fastsleep at boot time.
Revert this commit since we no longer need this fix. However we can
continue to use powersave_nap parameter to control entry into deep
idle states beyond snooze.

Signed-off-by: Preeti U. Murthy <redacted>
---

 drivers/cpuidle/cpuidle-powernv.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/cpuidle/cpuidle-powernv.c b/drivers/cpuidle/cpuidle-powernv.c
index b57681d..b430e76 100644
--- a/drivers/cpuidle/cpuidle-powernv.c
+++ b/drivers/cpuidle/cpuidle-powernv.c
@@ -69,8 +69,9 @@ static int fastsleep_loop(struct cpuidle_device *dev,
 	unsigned long old_lpcr = mfspr(SPRN_LPCR);
 	unsigned long new_lpcr;
 
-	if (powersave_nap < 2)
-		return;
+	if (!(powersave_nap > 0))
+		return index;
+
 	if (unlikely(system_state < SYSTEM_RUNNING))
 		return index;
 

Re: [PATCH] cpuidle/powernv: Re-enable fastsleep at boot time

From: Joel Stanley <joel@jms.id.au>
Date: 2014-11-19 02:34:50

Hey Preeti,

On Tue, Nov 18, 2014 at 5:26 PM, Preeti U Murthy
[off-list ref] wrote:
Commit dcb18694 "Fix ipi on palmeto" disabled fastsleep at boot time.
I couldn't find this commit in any tree; upstream, mpe's next, nor powerkvm.

I remember testing this as a workaround for the palmetto, but I don't
recall sending it upstream.

Cheers,

Joel

Re: [PATCH] cpuidle/powernv: Re-enable fastsleep at boot time

From: Preeti U Murthy <hidden>
Date: 2014-11-19 07:09:18

Hi Joel,

On 11/19/2014 08:04 AM, Joel Stanley wrote:
Hey Preeti,

On Tue, Nov 18, 2014 at 5:26 PM, Preeti U Murthy
[off-list ref] wrote:
quoted
Commit dcb18694 "Fix ipi on palmeto" disabled fastsleep at boot time.
I couldn't find this commit in any tree; upstream, mpe's next, nor powerkvm.
Oh yes you are right. I must have been looking at the wrong git branch.
I verified upstream now. The commit dcb18694 is not present.So we are
good. Thanks for pointing this out :)

Sorry for the noise!
I remember testing this as a workaround for the palmetto, but I don't
recall sending it upstream.

Cheers,

Joel
Regards
Preeti U Murthy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help