[PATCH] powerpc/pseries: Quieten relocation on exceptions warning

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE4383d

2 messages, 2 authors, 2014-10-19 · open the first message on its own page

[PATCH] powerpc/pseries: Quieten relocation on exceptions warning

From: Anton Blanchard <hidden>
Date: 2014-10-19 21:51:30

The hypervisor returns H_P2 if relocation on exceptions are
not supported. If we get this, just print a lower priority
informational message.

Signed-off-by: Anton Blanchard <redacted>
---
 arch/powerpc/platforms/pseries/setup.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c
index 125c589..fcc9227 100644
--- a/arch/powerpc/platforms/pseries/setup.c
+++ b/arch/powerpc/platforms/pseries/setup.c

@@ -499,7 +499,11 @@ static void __init pSeries_setup_arch(void)
 
 	if (firmware_has_feature(FW_FEATURE_SET_MODE)) {
 		long rc;
-		if ((rc = pSeries_enable_reloc_on_exc()) != H_SUCCESS) {
+
+		rc = pSeries_enable_reloc_on_exc();
+		if (rc == H_P2) {
+			pr_info("Relocation on exceptions not supported\n");
+		} else if (rc != H_SUCCESS) {
 			pr_warn("Unable to enable relocation on exceptions: "
 				"%ld\n", rc);
 		}

-- 
1.9.1

Re: [PATCH] powerpc/pseries: Quieten relocation on exceptions warning

From: Michael Neuling <hidden>
Date: 2014-10-19 23:03:20

The hypervisor returns H_P2 if relocation on exceptions are
not supported. If we get this, just print a lower priority
informational message.

Can you add something about why this is needed?  Something about
h_set_mode being available so we can enable LE but not supporting any of
the other calls like AIL?

Mikey

quoted hunk

Signed-off-by: Anton Blanchard <redacted>
---
 arch/powerpc/platforms/pseries/setup.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
=20

diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platfo=

rms/pseries/setup.c

quoted hunk

index 125c589..fcc9227 100644

--- a/arch/powerpc/platforms/pseries/setup.c
+++ b/arch/powerpc/platforms/pseries/setup.c

@@ -499,7 +499,11 @@ static void __init pSeries_setup_arch(void)

=20
 	if (firmware_has_feature(FW_FEATURE_SET_MODE)) {
 		long rc;
-		if ((rc =3D pSeries_enable_reloc_on_exc()) !=3D H_SUCCESS) {
+
+		rc =3D pSeries_enable_reloc_on_exc();
+		if (rc =3D=3D H_P2) {
+			pr_info("Relocation on exceptions not supported\n");
+		} else if (rc !=3D H_SUCCESS) {
 			pr_warn("Unable to enable relocation on exceptions: "
 				"%ld\n", rc);
 		}

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help