# Re: \[PATCH 2/2\] clk: ppc-corenet: don't use platform\_driver to init the clock device

- From: Kevin Hao \<hidden\>
- Date: 2014-10-19 05:52:17 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2014/10/9481311
- Thread: https://ratatoskr.run/linuxppc-dev/2014/10/9481289/t.md

```text
On Fri, Oct 17, 2014 at 07:58:55AM +0200, Scott Wood wrote:
> On Fri, 2014-10-17 at 06:55 +0800, Kevin Hao wrote:
> > I have thought about to put it in a more common place such as time_init(),
> > but this will be in conflict with mpc512x board. How about add an
> > arch_initcall(mpc85xx_clk_init) in arch/powerpc/platforms/85xx/common.c?
> 
> Gerhard, does 512x really require of_clk_init() to be called at that
> specific time, or can it be replaced by a common of_clk_init()?

I have took a look at the mpc5121_clk_init() and it seems that the
of_clk_init() is only used to scan the 'fixed-clock' in the DT. So I think
it should be safe to invoke it a bit earlier in a common place. I will create
v2 to use this method.

Gerhard, please correct me if I am wrong.

Thanks,
Kevin
```

## Attachments

- [(unnamed)](https://ratatoskr.run/linuxppc-dev/2014/10/9481311/attachment/0) (application/pgp-signature, 473 bytes)