# Re: \[PATCHv9 2/5\] ppc/cell: trivial: replace get\_unused\_fd() by get\_unused\_fd\_flags(0)

- From: Yann Droneaud \<hidden\>
- Date: 2014-10-16 09:10:24 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2014/10/89015
- Thread: https://ratatoskr.run/linuxppc-dev/2014/10/88931/t.md

```text
Hi,

Le mardi 14 octobre 2014 à 12:57 +1100, Michael Ellerman a écrit :
> On Mon, 2014-10-13 at 21:30 +0200, Yann Droneaud wrote:
> > This patch replaces calls to get_unused_fd() with equivalent call to
> > get_unused_fd_flags(0) to preserve current behavor for existing code.
> > 
> > In a further patch, get_unused_fd() will be removed so that new code
> > start using get_unused_fd_flags(), with the hope O_CLOEXEC could be
> > used, either by default or choosen by userspace.
> > 
> > Link: http://lkml.kernel.org/r/cover.1413223900.git.ydroneaud@opteya.com
> > Cc: Al Viro <viro@zeniv.linux.org.uk>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: trivial@kernel.org
> > Signed-off-by: Yann Droneaud <redacted>
> 
> This is fine by me, do you want an ack, or do you want us to take it via the
> powerpc tree?
> 

The patch was added in -mm by Andrew, so I guess the patch will be
merged sooner or later.

Anyway, you could investigate to check if O_CLOEXEC could be used
instead of 0 in call to get_unused_fd_flags().

> If the former:
> 
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
> 

Thanks a lot.

Regards.

-- 
Yann Droneaud
OPTEYA
```