[PATCH] powerpc/pci: remove duplicate declaration of pci_bus_find_capability
Subsystems:
linux for powerpc (32-bit and 64-bit) , the rest
4340d
4 messages,
2 authors,
2014-10-14 · open the first message on its own page
pci_bus_find_capability() is decleared in pci.h, so it is not necessary to do
it again.
This patch removes it.
Signed-off-by: Wei Yang <redacted>
---
arch/powerpc/kernel/pci-common.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
index b2814e2..9cfa069 100644
--- a/arch/powerpc/kernel/pci-common.c
+++ b/arch/powerpc/kernel/pci-common.c @@ -1561,7 +1561,6 @@ EARLY_PCI_OP(write, byte, u8)
EARLY_PCI_OP ( write , word , u16 )
EARLY_PCI_OP ( write , dword , u32 )
- extern int pci_bus_find_capability ( struct pci_bus * bus , unsigned int devfn , int cap ); int early_find_capability ( struct pci_controller * hose , int bus , int devfn ,
int cap )
{ --
1.7.9.5
On Fri, Sep 19, 2014 at 05:25:22PM +0800, Wei Yang wrote: pci_bus_find_capability() is decleared in pci.h, so it is not necessary to do
it again.
This patch removes it.
Signed-off-by: Wei Yang <redacted>
Reviewed-by: Gavin Shan <redacted>
Thanks,
Gavin
quoted hunk ---
arch/powerpc/kernel/pci-common.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
index b2814e2..9cfa069 100644
--- a/arch/powerpc/kernel/pci-common.c
+++ b/arch/powerpc/kernel/pci-common.c @@ -1561,7 +1561,6 @@ EARLY_PCI_OP(write, byte, u8) EARLY_PCI_OP(write, word, u16)
EARLY_PCI_OP(write, dword, u32)
-extern int pci_bus_find_capability (struct pci_bus *bus, unsigned int devfn, int cap);
int early_find_capability(struct pci_controller *hose, int bus, int devfn,
int cap)
{
--
1.7.9.5
On Fri, Sep 19, 2014 at 08:18:02PM +1000, Gavin Shan wrote: On Fri, Sep 19, 2014 at 05:25:22PM +0800, Wei Yang wrote: quoted pci_bus_find_capability() is decleared in pci.h, so it is not necessary to do
it again.
This patch removes it.
Signed-off-by: Wei Yang <redacted>
Reviewed-by: Gavin Shan <redacted>
Thanks,
Gavin
Hi, Michael
I see this is not merged in your tree. Do you have some comment?
quoted ---
arch/powerpc/kernel/pci-common.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
index b2814e2..9cfa069 100644
--- a/arch/powerpc/kernel/pci-common.c
+++ b/arch/powerpc/kernel/pci-common.c @@ -1561,7 +1561,6 @@ EARLY_PCI_OP(write, byte, u8) EARLY_PCI_OP(write, word, u16)
EARLY_PCI_OP(write, dword, u32)
-extern int pci_bus_find_capability (struct pci_bus *bus, unsigned int devfn, int cap);
int early_find_capability(struct pci_controller *hose, int bus, int devfn,
int cap)
{
--
1.7.9.5
--
Richard Yang
Help you, Help me
On Tue, Oct 14, 2014 at 02:25:39PM +0800, Wei Yang wrote: On Fri, Sep 19, 2014 at 08:18:02PM +1000, Gavin Shan wrote: quoted On Fri, Sep 19, 2014 at 05:25:22PM +0800, Wei Yang wrote: quoted pci_bus_find_capability() is decleared in pci.h, so it is not necessary to do
it again.
This patch removes it.
Signed-off-by: Wei Yang <redacted>
Reviewed-by: Gavin Shan <redacted>
Thanks,
Gavin
Hi, Michael
I see this is not merged in your tree. Do you have some comment?
Oops,
As pointed by Gavin, it is in the next branch.
quoted quoted ---
arch/powerpc/kernel/pci-common.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
index b2814e2..9cfa069 100644
--- a/arch/powerpc/kernel/pci-common.c
+++ b/arch/powerpc/kernel/pci-common.c @@ -1561,7 +1561,6 @@ EARLY_PCI_OP(write, byte, u8) EARLY_PCI_OP(write, word, u16)
EARLY_PCI_OP(write, dword, u32)
-extern int pci_bus_find_capability (struct pci_bus *bus, unsigned int devfn, int cap);
int early_find_capability(struct pci_controller *hose, int bus, int devfn,
int cap)
{
--
1.7.9.5
--
Richard Yang
Help you, Help me
--
Richard Yang
Help you, Help me